code-corps / code-corps-api

95%

develop: 96%

LAST BUILD ON BRANCH 1253-fix-github-issue-nulling

branch: 1253-fix-github-issue-nulling

CHANGE BRANCH

x

Reset

• 1253-fix-github-issue-nulling
• develop
• 349-add-ja-resource
• 181-switch-to-bodyguard
• remove-model-helpers
• upgrade-arc
• 181-switch-to-bodyguard-take-2
• 341-get-rid-of-organization/memberships_endpoint
• fix-segment-tests
• 340-fix-comment-endpoints-to-match-ember
• 339-fix-task-by-project-id-and-number-endpoint
• use-read-after-writes-for-task-number
• 368-363-add-stripe-customer-stripe-card-models
• 362-add-stripe-account-model
• 381-apiblueprint-donationgoals
• 361-367-add-stripe-plans-subscriptions
• refactor-comment-controller-tests
• 385-apiblueprint-stripecard
• sb-update-project-skill-test
• 394-add-issue-and-pr-templates
• 387-apiblueprint-stripeplan
• fix-api-blueprint-warnings
• 389-apiblueprint-stripecustomer
• 391-apiblueprint-stripesubscription
• 390-apiblueprint-stripeaccount
• refactor-comment-controller-test
• refactor-analytics-identify-plug
• 406-refactor-preview-controller-test
• 408-projectskills-controller-test
• 409-refactor-user-role-controller-test
• 414-roleskills-controller-test
• 418-projectcategory-controller-test
• refactor-requestcreate
• 419-refactor-organization-membership-controller-test
• 421-userskills-controller-test
• 427-category-controller-test
• 428-refactor-donation-goals-controller-tests
• 432-refactor-page-controller-tests
• 437-project-controller-test
• 436-refactor-skill-controller-tests
• 439-sluggedroutes-controller-test
• 443-refactor-user-controller-tests
• 442-task-controller-test
• 450-stripeaccount-policy
• 453-stripecustomer-policy
• 454-write-policy-stripe-card
• rileytaylor-doc-edit
• 459-stripe-account-controller
• 466-update-api-blueprint
• 471-rename-stripe-customer
• 472-rename-stripe-connect-plans
• 473-rename-stripe-subscription
• 457-write-policy-for-stripe-connect-subscription
• 479-set-current-donation-goal
• 370-stripe-webhooks
• improve-stripe-connect-plan
• 261-add-donations-active-to-projects
• improve-docs
• 480-send-params-on-stripe-account-creation
• 489-pass-parameters-to-stripe-customer
• add-test-for-stripe-connect-subscription-find-or-create
• 499-set-statement-description-on-stripe-plans
• 504-set-redirect-uri-based-on-environment
• 509-handle-customer-subscription-deleted
• 511-add-verification-status-to-connect-account
• civic-json
• 524-add-bamboo-integration
• update-dependencies
• fix-chars-in-statement-descriptor
• 475-handle-customer-updated
• 512-add-stripe-events
• 540-report-stripe-errors-to-sentry
• fix-issues-with-charges-enabled
• spike-for-managed-accounts
• task-redesign
• stripe_file_upload
• 556-remove-stripe-auth
• 571-stripe-external-account-model-and-tests
• 573-webhook-for-account-external-account-created
• 550-fetch-webhook-events-from-stripe
• 568-add-verification
• 572-add-connect-account-update
• add-legal-entity-fields-to-stripe-connect-account
• remove-pagination-on-tasks
• remove-status-field-code-connect-accounts
• 525-add-stripe-tracking
• update-stripe-connect-account-view
• update-deps
• 597
• 597-save-bank-account-last4-and-routing-number
• fix-account-adapter
• change-bank-accounts
• remove-pagination-from-tasks
• add-inbox-flag-to-task-lists
• consolidate-stripe-connect-account-crud-code
• cleanup-formatting-and-error-handling-in-stripe-services
• project-can-activate-donations
• fix-validator
• 617-track-event-object-ids
• dleve123-djl-order-task-lists
• bridge-gap-with-mirage-seeds
• add-structure.sql
• update-token-controller
• 634-explicitly-ignore-events
• 640-create-external-account-when-updating-connect-account
• remove-docker-and-update-docs
• update-docs
• fix-errors
• 645-split-up-event-handler
• 535-add-unique-constraint-to-membership-create-changeset
• add-stripe-connect-charge
• 651-add-user-id-to-processor
• master
• fix-migrations
• 659-add-postmark-adapter
• 595-update-credo-to-make-it-runnable
• 590-simplify-subscription-creation
• np-update-api-docs
• 670-task-skill-model-policies-endpoints
• 667-user-tasks
• add-dialyzer
• update-cloudinary-url
• remove-unused-arc-code
• 682-upgrade-earmark
• 689-fix-event-aving-on-webhook-for-balance-object
• update-stripity-stripe
• cloudex-test-support
• expose-task-skills-on-task
• fix-user-tasks
• add-user-task-update
• add-user-filter
• fix-cloudex-config
• remove-task-types
• add-project-acceptance-email
• 709-make-user-owner-of-organization
• add-note-to-docs-on-elixir-version-mgmt
• 711-add-project-users
• 712-add-migration-task-for-organization-memberships-to-project-memberships
• 717-change-project-permissions
• 739-add-website-field
• reset-password
• auth-token-changeset
• auth-token-model
• update-project-controller
• add-approved-to-projects-index
• reset-password-route
• fix-seeds
• 748-remove-project-owner
• 757-update-ja-resource
• add-syntax-highlighting-to-markdown
• update-api-blueprint
• fix-description-clearing
• 718-remove-organization-memberships
• forgot-password
• fix-and-simplify-seeds
• allow-setting-user-state-to-donating-on-creation
• add-sign-up-context
• np-github-connect
• np-github-webhooks
• fix-reset-controller
• np-github-ids
• np-github-create-task
• github-connect
• update-password-reset
• fix-500
• update-github-oauth
• add-github-user-information
• add-github-app-installation
• add-github-webhook-endpoint
• add-installation-event-support
• 826-installation-repositories-webhook
• mock-out-pem-access
• 838-cleanup-installation-event
• 842-add-organization-github-app-installation
• 832-diff-repo-processing
• update-views
• add-controllers-and-blueprints
• 828-issues-opened-webhook
• 827-issue-comment-webhook
• 851-add-account-fields-to-installation
• 853-retrieve-available-user-github-app-installations
• misc-github-flow-fixes
• 858-associate-connected-user-with-installations
• github-app-installation-changes-required-for-integration-tab
• upgrade-to-phoenix-1-3-final
• 864-switch-comment-controller-off-ja-resource
• fix-canaryless-policies
• fix-github-app-installations-on-user
• refactor-github-api-layer
• add-task-to-task-list
• user-controller-no-jaresource
• 867-addendum-correct-bad-moduledoc
• user-task-controller-refactor
• 922-reverse-order-of-user-policy-arguments
• 801-802-propagate-comment-changes-to-github-comments
• user-skill-controller-ja-resource
• 874-remove-source-field
• 790-connect-action-error-handling
• cleanup-project-controller-add-project-query
• 779-scheme-missing-when-images-are-placed-into-email-dynamically-from-cloudinary
• rewrite-controller-tests-to-use-string-ids-as-ember
• remove-test-watch
• fix-compiler-warnings
• 948-add-signup-context-to-github-user
• 941-942-connect-github-user-to-tasks-comments
• update-changeset-builder
• 939-correct-user-assignment-when-syncing-task
• 969-add-payload-to-github-events
• 940-fail-on-changeset-errors-in-task-syncer
• 873-track-github-event-failure-reason
• add-comment-changes
• fix-minor-issues-with-seeds
• fix-warnings
• fix-issues-with-stripe-connect-account-controller
• 980-fix-email-overwriting-by-github
• 888-modify-task-timestamps-for-github-sync
• 981-add-unique-constraint-to-user-github-id
• 887-modify-comment-timestamps-for-github-sync
• 947-set-default-color-for-github-users
• reinstate-markdown-restrictions-on-comment
• update-seeds
• 889-switch-donation-goal-controller-away-from-jaresource-and-canary
• update-github-user-avatar
• update-task-view
• 1027-fix-issues-with-undead-async-tasks
• 1035-modified-at-task
• 1044-standardize-issues-webhook
• 1045-standardize-issue-comment-webhook
• remove-unused-model-function
• 1042-github-installations
• add-intercom-user-hash
• 1043-standardize-output-for-installation-repositories
• 983-refactor-webhook-handler
• 1070-github-issue
• 1070-github-comment
• add-github-pull-request
• 928-add-info-to-github-issue-when-codecorps-user-created-via-bot
• 1078-fix-order-from-github
• 1076-add-missing-github-id-indexes
• 1077-find-or-create-github-comment-issue-and-repo
• code-and-comment-cleanups-for-issue-comment
• 1038-analytics-track-connected-to-github
• move-api-code
• reorganize-github-syncing
• refactor-events
• implement-user-context-logger-plug
• 1100-delete-comments-and-github-comments
• 1038-add-analytics-tracking-for-core-actions
• fetch-github-env-variables-at-runtime
• github-pagination
• fix-issues-with-policies
• fix-identifiers-in-views
• fix-performance-issues
• add-scout-apm
• update-scout-config
• refactor-github-api-to-use-gateway
• jsonapi
• 1135-add-syncing-statuses-to-github-repo
• 1111-sync-comments
• jsonapi-test
• include-tasks
• syncing-does-not-match-result-aggregator-errors
• 1130-add-tests-for-time-validator
• optimize-task-list-performance
• task-list-modify
• 1053-assign-task-lists-and-archived-during-sync
• fix-migration-for-adding-done-to-task-lists
• 1108-add-pagination-support-to-installation-repositories
• 1145-set-modified-from
• 1166-add-github-events-endpoint
• 1159-fix-github-oauth-user-connect
• github-event-sort
• fix-order-of-github-events
• add-processor
• fix-partially-supported-github-errored-events
• fix-webhook-validation-events
• security-improvements
• restrict-github-repo-to-single-project
• 1191-remove-project-github-repo
• 1192-save-changeset-errors
• 1202-fix-modified-at-comparisons
• send-stripe-message
• add-github-issue-assignee
• report-all-errors
• remove-unnecessary-fn
• 1217-eliminate-duplicative-logic-in-github-sync-issue-github-issue
• add-overall-status-to-task
• update-stripity-stripe-headers
• fix-project-users
• fix-dialyzer-1
• add-categories-to-user-and-project
• fix-project-website
• add-project-user-request-email
• fix-issues
• stricter-builds
• fix-sync-dialyzer-errors
• add-processor-typespecs
• update-cloudex
• issue-1221
• improve-organization-creation
• 1264-fix-invite-url
• fix-sync-test
• add-organization-invite-approval
• make-acceptance-filter-optional
• add-project-approval-requests
• add-mix-test-watch
• temporarily-fix-seeds
• add-messages
• fix-timber-dialyzer-error
• 1286-conversation-models
• 1288-conversation-index
• add-organizations-to-user
• 1287-add-conversation-show
• 1291-conversation-part-controller
• 1293-accomodating-messages-api-to-match-client
• task_list_include
• fix-messages
• update-conversation
• 1294-cleanup-messages-index
• part-type
• 1304-validate-new-routes-against-usernames
• add-check-origin-to-user-socket
• fix-contributors-url
• 1331-switch-to-sparkpost
• 1317-update-conversation-for-conversation-part
• counter-cache
• limit-part-scope
• fix-project-user-issue
• include-parts
• include-convo-parts
• user-invites
• add-status-filtering-to-github-events
• alias-user-on-create
• fix-organization-icons
• move-tasks-context
• upgrade-comeonin
• reorganize-github-modules
• minor-cleanup-of-github-sync
• switch-to-circle-2.0
• close-reopen-conversation-types
• chore/test-github-sync-installation
• chore/test-pull-request-event
• feature/track-installation-created-from-github

Build # 3464

Build Type

Pull #1257

circle-ci

Committed by joshsmith

Commit Message

Fix accidental nulling of pull request in Task.Service

Pull Request Pull Request #1257: Fix accidental nulling of pull request in Task.Service

Run Details

5 of 5 new or added lines in 2 files covered. (100.0%)

2493 of 2617 relevant lines covered (95.26%)

46.59 hits per line