cljoly / rusqlite_migration

96%

master: 95%

LAST BUILD ON BRANCH fix-docs

branch: fix-docs

CHANGE BRANCH

x

Reset

Sync Branches

• fix-docs
• coverage
• master
• nightly-coverage
• tweak-coverage
• add-coveralls-badge
• error-tests
• eq-tests
• cljoly-codeowner
• readme-sourcehut
• doc-readme-sync
• remove-badge
• misc-improvements
• changelog-1.0.2
• optimize-from_directory
• doc-fixes
• add-benchmarks
• deprecate-new_iter
• ignore-artefacts
• pedantic-fixes
• dependabot/cargo/criterion-0.5
• fix-readme-deps-badge
• changelog-update
• refs/tags/v1.1.0-alpha.2
• bump-v110a2
• doc-improvements
• simpler-doc-generation
• mutants-fixes
• multi-errors-fkc
• async-pkg
• doc-updates
• cljoly-patch-1
• update-cargo-mutants
• insta-doc
• docsrs-list-features
• test-fmt
• rename-async-feature-to-alpha
• keep-api-compat-tests
• release-110-beta1
• refs/tags/v1.1.0-beta.1
• v1.1.0
• refs/tags/v1.1.0
• manifest-fresh-paint
• dependabot/cargo/env_logger-0.11
• update-mutants-24.2
• dependabot/cargo/env_logger-0.11.1
• dependabot/cargo/mio-0.8.11
• dependabot/cargo/zerocopy-0.7.32
• fix-and-shard-mutants
• dependabot/cargo/anyhow-1.0.81
• dependabot/cargo/tokio-test-0.4.4
• dependabot/cargo/tokio-1.36.0
• dependabot/cargo/log-0.4.21
• md-links
• version-120-beta1
• refs/tags/v1.2.0-beta.1
• version-120
• doc-badges
• badges-update
• refs/tags/v1.2.0
• 1.3.0-alpha
• dependabot/cargo/insta-1.37.0
• dependabot/cargo/insta-1.38.0
• dependabot/cargo/tokio-1.37.0
• cargo-locked
• dependabot/cargo/anyhow-1.0.82
• dependabot/cargo/anyhow-1.0.83
• dependabot/cargo/insta-1.39.0
• dependabot/cargo/anyhow-1.0.86
• dependabot/cargo/tokio-1.38.0
• dependabot/cargo/include_dir-0.7.4
• dependabot/cargo/lazy_static-1.5.0
• dependabot/cargo/log-0.4.22
• refresh-cargo-toml
• fix-deprecated-insta-macro
• dependabot/cargo/tokio-1.38.1
• arc-async
• dependabot/cargo/tokio-1.39.1
• modernize-cargo-toml
• rust-180
• clippy-fixes
• dependabot/cargo/tokio-1.39.2
• handle-extra_check
• alpha-130-without-async
• prep-without-tokio
• refs/tags/v1.3.0-alpha-without-tokio.1
• dependabot/cargo/env_logger-0.11.5
• dependabot/cargo/tokio-1.39.3
• rusqlite-033
• openssf
• dependabot/cargo/tokio-1.40.0
• dependabot/cargo/insta-1.40.0
• dependabot/cargo/anyhow-1.0.87
• dependabot/cargo/anyhow-1.0.88
• dependabot/cargo/anyhow-1.0.89
• fix-typo-feature-name
• dependabot/cargo/rusqlite-0.32.1
• version-130-beta-1
• refs/tags/v1.3.0-beta.1
• version-130
• refs/tags/v1.3.0
• fix-deprs-shield
• 1.3.1
• refs/tags/v1.3.1
• dependabot/cargo/anyhow-1.0.90
• bump-test-coverage
• dependabot/cargo/tokio-1.41.0
• dependabot/cargo/anyhow-1.0.91
• dependabot/cargo/insta-1.41.0
• dependabot/cargo/insta-1.41.1
• dependabot/cargo/anyhow-1.0.92
• dependabot/cargo/anyhow-1.0.93
• dependabot/cargo/tokio-1.41.1

Build # 8341987493

Build Type

Pull #139

github

Committed by cljoly

Commit Message

fix: failing examples with rusqlite “extra_check” feature

As reported in [1], in the documentation and examples, the following:

```conn.pragma_update(None, "journal_mode", &"WAL").unwrap();```

panics with `ExecuteReturnedResults` when the “extra_check” feature of
rusqlite is enabled.

This wasn’t caught automatically because it turns out our examples
aren’t run in CI, because the Cargo manifests weren’t properly
referenced.

This includes the manifests properly and fixes the CI.

[1] https://github.com/cljoly/rusqlite_migration/issues/15#issuecomment-1868524798

Pull Request Pull Request #139: Fix broken docs and examples when some rusqlite features are used

Run Details

319 of 333 relevant lines covered (95.8%)

7.93 hits per line