clay / claycli

87%

master: 87%

LAST BUILD ON BRANCH jordan/fix-client-init-mounting-docs

branch: jordan/fix-client-init-mounting-docs

CHANGE BRANCH

x

Reset

• jordan/fix-client-init-mounting-docs
• 4.x
• action_update
• action_version
• amelvisfranco-patch-2
• amelvisfranco-patch-3
• async-await
• async-defer
• autoprefixer-config-support
• babel
• babel-modules
• bare-exports
• browserified
• browserslist
• bump-handlebars
• bumping-version
• change_pr_templates
• circle2
• clay-pack-spike
• clayconfigjs-readme
• clayhandlebars_pin_hbs
• compilation
• compilation-bugs
• compile
• config_fix
• coveralls-3
• default-key-order
• dependabot/npm_and_yarn/fstream-1.0.12
• dependabot/npm_and_yarn/handlebars-4.7.3
• dependabot/npm_and_yarn/js-yaml-3.13.1
• dependabot/npm_and_yarn/lodash.mergewith-4.6.2
• dependabot/npm_and_yarn/mixin-deep-1.3.2
• devdep
• disable-common-shake
• doc_update
• docs-update
• docs_update
• downgrade-handlebars
• env-var
• fix-dev-builds
• fix-release-script
• fix-url
• fix_version_page
• fixing-compilation
• freeze-event-stream
• git_action
• headers
• icon_issue
• import-obj
• init-regexp
• issues_awnsers
• jordan/fix-aws-region-fallback
• jordan/fix-url-imports
• jordan/fix-vite-env-collector-destructure
• jordan/fix-vite-env-hydration-order
• jordan/improve-vite-coverage
• jordan/migrate-to-github-actions
• jordan/upgrade-claycli
• jordan/vite-css-sites-targeting
• jordan/yolo-update
• jowen/font_files
• kilnjs
• layouts
• lint-ext
• love2doc
• master
• mem-safe-load
• moberle/fix-minify-envvar
• moberle/update-dependencies
• no-public-font-files
• npm-templates
• nyancat
• parse-bootstraps
• parseBootstrapJson
• postcss-plugin-reorder
• precss
• prerelease
• public-fonts
• pull_request_template
• realfixforcompilation
• redesign_task
• rf.scannable-readme
• ronin
• search_bar
• single-page-export
• subsite-support
• test-deploy
• testing-fixes
• two-oh
• underscore
• update-readme-export
• update_action
• update_actions
• upgrade-dependencies
• v5-rc
• v6.0.0-rc.0
• v6.0.0-rc.1
• version_update
• vueify-sass-bump
• webpack-dev

Build # 25932771886

Build Type

Pull #250

github

Committed by jjpaulino

Commit Message

🍕 Clarify _client-init.js component-mounting semantics in docs

Several places in CLAY-VITE.md and BUNDLER-COMPARISON.md described the
legacy Browserify component loader as "mounts every .client module
loaded — no DOM check" or "DOM or not". That overstates what
_client-init.js actually does.

Per lib/cmd/compile/_client-init.js, mountComponentModules() iterates
every .client key in window.modules and calls window.require(key) on
each — which executes the module body and walks its dependency graph
regardless of DOM presence — but the exported controller function is
only invoked via tryToMount() for elements matching the
[data-uri*="_components/<name>/"] / [data-uri$="_components<name>"]
selectors. So the mount call itself IS DOM-gated; what isn't gated is
module evaluation.

The Vite improvement is therefore narrower but still real: vite-bootstrap
scans the DOM first and skips the dynamic import() entirely if no
matching element exists, so neither the module body nor any of its
transitive dependencies execute. Updated all four prose locations to
reflect this; the mermaid diagrams already used the more precise
"calls window.require(key) for every .client / regardless of DOM
presence" wording and were left as-is.

Co-authored-by: Cursor <cursoragent@cursor.com>

Pull Request Pull Request #250: 🍕 Clarify _client-init.js component-mounting semantics in docs

Coverage Stats

757 of 941 branches covered (80.45%)

Branch coverage included in aggregate %.

1581 of 1751 relevant lines covered (90.29%)

10.28 hits per line