charmbracelet / ssh

62%

master: 62%

LAST BUILD ON BRANCH fix/conpty-handle-leak

branch: fix/conpty-handle-leak

CHANGE BRANCH

x

Reset

Sync Branches

• fix/conpty-handle-leak
• charm-proxy-protocol
• chore/charm-conventions
• contain-connection-panics
• fix/pty-job-control
• master
• slog-errors
• upstream-fixes
• upstream-fixes-2

Build # 30503519225

Build Type

Pull #49

github

Committed by taciturnaxolotl

Commit Message

fix: close leaked process and pipe handles on Windows PTY sessions

Each PTY session on Windows leaked roughly one handle because the raw
process handle returned by ConPty.Spawn was never closed. Upgrade
charmbracelet/x/conpty to v0.2.0 which closes all four pipe handles
properly, and close the spawned process handle once the process exits
or the session context is cancelled.

Pull Request Pull Request #49: fix: close leaked process and pipe handles on Windows PTY sessions

Coverage Stats

772 of 1238 relevant lines covered (62.36%)

6669.61 hits per line