chapel-lang / sphinxcontrib-chapeldomain

60%

master: 60%

LAST BUILD ON BRANCH 0.0.19

branch: 0.0.19

CHANGE BRANCH

x

Reset

• 0.0.19
• 0.0.10
• 0.0.11
• 0.0.12
• 0.0.13
• 0.0.14
• 0.0.15
• 0.0.16
• 0.0.17
• 0.0.18
• 0.0.2
• 0.0.20
• 0.0.3
• 0.0.4
• 0.0.5
• master

Build # 154

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Merge pull request #45 from mppf/fix-sphinx-incremental-build-issue

Fix problem: dictionary changed size during iteration

The issue comes up when using sphinx to do an incremental
docs build (see https://github.com/chapel-lang/chapel/pull/16835 )

I encountered an error along these lines:
```
Exception occurred:
  File "CHPL_HOME/third-party/chpl-venv/install/chpldeps/sphinxcontrib/chapeldomain/__init__.py", line 810, in clear_doc
    for fullname, (fn, x) in self.data['objects'].items():
RuntimeError: dictionary changed size during iteration
The full traceback has been saved in /var/folders/b6/1lwlz22n5d53878_x52vp3kr0007pg/T/sphinx-err-xabz0j9_.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
```

To fix, this PR adjusts `clear_doc` to save the keys to remove in a list and then remove them.

Reviewed by @lydia-duncan - thanks!

Run Details

494 of 817 relevant lines covered (60.47%)

0.6 hits per line