catmaid / CATMAID
47%
master: 45%

LAST BUILD BRANCH: dev
DEFAULT BRANCH: master
Repo Added
Files 111
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH maintenance/2016.12.16
branch: maintenance/2016.12.16
CHANGE BRANCH
x

2853

push

travis-ci

tomka 
Graph widget: fix SVG export and add SVG factory

The recent update of Cytoscape.js broke SVG export. Cytoscape.js changed
their CanvasRenderer quite a bit and so our hacks to allow SVG export
had to be updated. Instead of adding yet another heack to make SVG
export work through SVGKit, a custom SVG factory has been created, which
is used to create SVG documents manually. It currently supports basic
text, circle, line and polygon geometries plus labels. This allows us to
create Graph Widget SVGs ourselves and to remove MochiKit along with
SVGKit as a dependency.

The following Graph Widget elements have been tested:

- regular nodes, circle (with label)
- group node, hexagon (with label)
- directed edge, line (with label)
- split node edges
- different colors

Labels are optional, but are centered on top of an element. The
generated SVG file groups nodes/edges along with their labels, this
makes later editing easier. Color, font and font-size are obtained from
Cytoscape.js.

Node that the Graph Widget uses this SVG factory by making use of some
of Cytoscape.js' internal renderer cache. For the sake of quickly fixing
the broken SVG export, our own version of the math (e.g. where are Bezer
control points) has been skipped. This can be done later if we want to
be more independent from Cytoscape.js or if changes in their renderer
break our export again.

Fixes catmaid/CATMAID#1450

5918 of 12479 relevant lines covered (47.42%)

0.47 hits per line

Relevant lines Covered
12479 RELEVANT LINES 5918 COVERED LINES
0.47 HITS PER LINE
Source Files on maintenance/2016.12.16
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
2853 maintenance/2016.12.16 Graph widget: fix SVG export and add SVG factory The recent update of Cytoscape.js broke SVG export. Cytoscape.js changed their CanvasRenderer quite a bit and so our hacks to allow SVG export had to be updated. Instead of adding yet another heack... push tomka travis-ci pending completion  
2788 maintenance/2016.12.16 Make 3D viewer resize with window in split/merge dialog This prevents some corner cases where the 3D viewer would be pushed down in the dialog, because the screen isn't wide enough for the default size settings. push tomka travis-ci pending completion  
2784 maintenance/2016.12.16 Graph widget: explicitely use bezier edges With Cytoscape.js 2.7 the default edge style changed to haystack, which doesn't support arrows. This is changed back to to bezier, losing a little bit of the performance gains for large graphs. push tomka travis-ci pending completion  
2783 maintenance/2016.12.16 Graph widget: fix batch mode enabling/disabling push tomka travis-ci pending completion  
See All Builds (4802)