bugsnag / bugsnag-node

79%

master: 40%

LAST BUILD ON BRANCH mongo-objectid-serialization

branch: mongo-objectid-serialization

CHANGE BRANCH

x

Reset

• mongo-objectid-serialization
• api-key-body
• app-type
• bengourley/session-payload-missing-props
• bengourley/sessions-on-by-default
• better-logging
• coveralls-debug
• dedupe-logging
• gracecheung-seo
• handled-unhandled
• improve-filters
• kattrali/add-node-9
• master
• sessions
• v1.12.2
• v2.0.0
• v2.0.1
• v2.1.0
• v2.1.0-0
• v2.1.1
• v2.1.2
• v2.1.3
• v2.2.0
• v2.3.0
• v2.3.1
• v2.4.0
• v2.4.1
• v2.4.2
• v2.4.3

Build # 285

Build Type

push

travis-ci

Committed by bengourley

Commit Message

Better preparation for cloned object serialization

When Utils.cloneObject() was called on an instance of a class,
such as the mongo driver's `ObjectId` instance, the copy would
bring across its enumerable private properties, but none of its
methods, resulting in a bad serialization like so:

      "id": {
        "id": {
          "0": 88,
          "1": 129,
          "2": 222,
          "3": 117,
          "4": 187,
          "5": 221,
          "6": 189,
          "7": 57,
          "8": 86,
          "9": 86,
          "10": 65,
          "11": 202
        },
        "bsontype": "ObjectID"
      }

Now just before cloning, objects are checked for a toJSON() method.
If they have one, the result of that is used for the clone resulting
in better serialization, such as:

      { "oid": "5a9045f5be123c8c5d811d35" }

Run Details

331 of 439 branches covered (75.4%)

Branch coverage included in aggregate %.

459 of 557 relevant lines covered (82.41%)

717.44 hits per line