box / ClusterRunner

76%

master: 5%

LAST BUILD ON BRANCH clean_up_build_tests

branch: clean_up_build_tests

CHANGE BRANCH

x

Reset

• clean_up_build_tests
• 0.5.436
• 0.5.443
• 0.5.445
• 0.5.449
• 0.5.451
• 0.5.453
• 0.5.455
• 0.5.457
• 0.5.461
• 0.5.462
• 0.5.463
• 0.5.464
• 0.5.466
• 0.5.467
• 0.5.471
• 0.5.473
• 0.5.474
• 0.5.477
• 0.5.478
• 0.5.479
• 0.5.480
• 0.5.481
• 0.5.482
• 0.5.484
• 0.5.499
• 0.5.500
• 0.5.501
• 0.5.502
• 0.5.503
• 0.5.504
• 0.5.505
• 0.5.507
• 0.5.509
• 0.5.511
• 0.5.512
• 0.5.515
• 0.5.516
• 0.5.517
• 0.5.518
• 0.5.519
• 0.5.520
• 0.5.521
• 0.5.522
• 0.5.524
• 0.5.526
• 0.5.527
• 0.5.532
• 0.5.534
• 0.5.537
• 0.5.539
• 0.5.541
• 0.5.543
• 0.5.545
• 0.5.546
• 0.5.547
• 0.5.548
• 0.5.550
• 0.5.551
• 0.5.553
• 0.5.564
• 0.5.566
• 0.5.568
• PE-12553
• _wip_build_fsm_refactor
• accept_formatted_json_config_in_build_request
• add-appveyor
• add-atom-state
• add-exit-code
• add-install-ps1
• add-kill-logging
• add-metrics
• add-mypy
• add-secret-randomness
• add-slave-remove-endpoint
• add-typing
• add_atom_field_for_custom_atoms_in_build_endpoint
• add_build_timing_fields
• add_function_for_calculating_artifact_paths
• add_hyposthesis_tests
• add_master_endpoint_for_console_output
• add_master_endpoint_for_console_output_test
• add_more_methods_to_unittest_blacklist
• add_slave_endpoint_for_console_output
• add_slave_endpoint_for_reading_console_output
• add_slave_to_subjob_api
• add_status_fields_to_atom_endpoint
• adding-subjob_id-to-atom
• adopt-popen-with-delayed-expansion
• allow_certain_headers_for_cors_ajax
• allow_structured_json_job_config_in_build_request
• auto-versioning-windows
• auto_succeed_build_if_no_atoms_to_run
• autoscaling-scripts
• autoversion
• autoversioning_fix
• be-more-assertive
• build-cancel-functional-tests
• build-fsm-refactor
• build_scheduler
• building-state-cancel
• cancel-build-at-slave
• catch-zippy-bugs
• chkconfig
• clean-up-test-conf-file
• clean_up_build_tests2
• config-none
• cors
• create-cr-rpm
• cross-platform-functional
• cx-freeze-cacert
• deallocating_and_reallocating_slaves_shouldnt_break
• delete_artifact_directory_for_build_on_master
• deprecate_hash_parameter
• disable-zip-file
• docker-rpm
• done_allocate_more_executors_to_build_than_subjobs
• dont-choke-on-offline-nodes
• dont-kill-slave
• dont-raise-error-on-subjob-failure
• draft-remove-disconnected-slaves
• enable-https
• enable_coveralls_2
• env-setter
• errors
• exe
• exit_build_preparation_if_no_atoms
• expose_regular_atom_in_api_representation
• fail_build_if_no_atoms_found
• failed_atoms_api_representation_should_be_original_atomization
• fetch_deep_on_master
• fix-all-tests-on-windows
• fix-appveyor-badge
• fix-broken-windows-tests
• fix-commands-chaining
• fix-dead-metric
• fix-lint-error
• fix-more-git
• fix-open-connections-issue
• fix-rpm
• fix-service-runner
• fix-slave-reconnection
• fix-slave-reconnection2
• fix-snapshot-ver
• fix-test-atomizer
• fix-test-fs
• fix-test-subjob
• fix-zips
• fixFailedSubjobResultSending
• fix_coveralls_windows_conflict
• fix_slave_setup_race_condition
• fix_yaml_name_docstrings
• fixing-atom-api
• fpm
• g-lgp
• generate_session_ids_on_master
• get-project-from-master
• gimme-logs
• git-diff
• handler-intercept-demo
• have_project_directory_be_kept_in_variable_form_during_atomization
• heartbeat
• heartbeat-404
• heartbeat-alive
• hide-version-errors
• https-config
• https-thoughts
• instantiate_new_slave_not_reuse_existing
• int-test
• is-alive
• is_windows-in-setup
• jenkinsfile
• josephharrington-patch-1
• linky-dev-setup
• lint
• log-subjob-postback-failure
• make-windows-tests-happier
• make_timing_data_file_additive_not_replaced
• master
• metrics
• more-metrics
• move-pid-file
• move_builds_waiting_for_slaves_queue
• move_job_config_construction_logic_to_class_method
• my-temp
• no-postbuild-crash
• nt-config-for-functional-tests
• only_do_shallow_clones_and_fetches
• pex
• pipefail
• piptools
• popen
• pylint151
• readme-polish
• refactor-thread-start
• refactor_build_prepare
• reintro-skip-cloning-from-master
• reject-bad-secret
• remove-extraneous-metric
• remove-slave
• rename-archive-methods
• revert_tj_testing
• rpm-shell-scripts
• rpm-sign
• sample_initd_script
• skip-check-status-code
• skip-file-mode-check
• skip-flaky
• slave-hostname
• slave-initd
• slave-reconnection-test
• slave-request-latency
• sleepy-windows
• split-dev-reqs
• sync_delete_build_result_directory
• test-branch
• test-git
• test-unit-via-cr
• testbranch
• testing-readme
• threads-are-too-safe
• tj_test_autosucceedbuild
• tj_test_tag
• tj_testing
• update-rpm-build
• update-tests
• ver-fix
• write_console_output_on_slave_to_final_path_directly
• zip-it

Build # 930

Build Type

push

travis-ci

Committed by josephharrington

Commit Message

Refactor and clean up tests for Build object

The Build class is the largest single class and the most complex object
in the application. Future planned refactorings will help this, but in
the meantime it is hard and usually verbose to create realistic build
objects for testing.

This change refactors some of the Build tests to use a build creation
helper that creates more realistic build objects. It has a side benefit
of making these tests more readable and maintainable.

The tradeoff is that these tests are now more "integration-y", but it
makes sense to move in this direction considering the complexity of the
Build class itself.

Run Details

2573 of 3391 relevant lines covered (75.88%)

0.76 hits per line