boto / boto3

98%

develop: 91%

LAST BUILD ON BRANCH model-collision

branch: model-collision

CHANGE BRANCH

x

Reset

• model-collision
• 0.0.1
• 0.0.10
• 0.0.11
• 0.0.13
• 0.0.14
• 0.0.15
• 0.0.17
• 0.0.18
• 0.0.19
• 0.0.2
• 0.0.20
• 0.0.22
• 0.0.3
• 0.0.4
• 0.0.5
• 0.0.6
• 0.0.7
• 0.0.8
• 0.0.9
• 1.0.0
• 1.0.1
• 1.1.0
• 1.1.2
• 1.1.3
• batch-actions
• collection-path-fix
• collections
• collisions
• config-docs
• deps
• develop
• doc-example
• doc-structure
• docs
• docs-fix
• docs-kwargs
• docs-refs
• equality
• error-info
• install-fix
• integ
• load-fix
• loader
• master
• meta-object
• migration-guide
• model
• model-update
• model-version-update
• plural-refs
• ref-load
• references
• region-config
• remove-six
• repr
• resource-model-update
• reverse-jmespath
• s3-high-level
• s3-ident-fix
• service-subresources
• threading-doc
• unique-meta
• useragent

Build # 240

Build Type

push

travis-ci

Committed by danielgtaylor

Commit Message

Move name collision logic to the model

This change moves and formalizes the name collision logic from the factory
to the resource model. The following has changed:

* Documentation now better matches the factory output.
* Collision renaming order is formalized in one place
  * Order: reserved names (meta), load action, identifiers, actions,
    subresources, references, collections, and then attributes.
* Renaming resource model attributes/methods now happens at model loading
  time rather than class creation time.

The way this works is by creating a mapping of (type, name) tuples to
the renamed value, if it exists. Typically this mapping will be very
sparse and it's fast to create / access. In practice we currently only
have one or two names that collide across all the resource models.

Tests have been updated, some of which needed to define proper Botocore
shapes as the code now looks more closely at those at model load time.

Run Details

447 of 457 relevant lines covered (97.81%)

4.87 hits per line