bodgit / sevenzip

77%

main: 77%

LAST BUILD ON BRANCH fix/reader-pool-leaks

branch: fix/reader-pool-leaks

CHANGE BRANCH

x

Reset

• fix/reader-pool-leaks
• aes_protect
• arm64
• bra-eof
• custom-decompressor
• delta-distance-256
• dependabot/github_actions/actions/checkout-5.0.0
• dependabot/github_actions/actions/setup-go-5.2.0
• dependabot/github_actions/actions/setup-go-5.4.0
• dependabot/github_actions/actions/setup-go-5.5.0
• dependabot/github_actions/actions/upload-artifact-4.5.0
• dependabot/github_actions/actions/upload-artifact-4.6.0
• dependabot/github_actions/actions/upload-artifact-4.6.1
• dependabot/github_actions/actions/upload-artifact-4.6.2
• dependabot/github_actions/actions/upload-artifact-5.0.0
• dependabot/github_actions/amannn/action-semantic-pull-request-6.1.0
• dependabot/github_actions/amannn/action-semantic-pull-request-6.1.1
• dependabot/github_actions/github/codeql-action-3.27.7
• dependabot/github_actions/github/codeql-action-3.27.9
• dependabot/github_actions/github/codeql-action-3.28.0
• dependabot/github_actions/github/codeql-action-3.28.1
• dependabot/github_actions/github/codeql-action-3.28.10
• dependabot/github_actions/github/codeql-action-3.28.11
• dependabot/github_actions/github/codeql-action-3.28.12
• dependabot/github_actions/github/codeql-action-3.28.13
• dependabot/github_actions/github/codeql-action-3.28.14
• dependabot/github_actions/github/codeql-action-3.28.15
• dependabot/github_actions/github/codeql-action-3.28.16
• dependabot/github_actions/github/codeql-action-3.28.17
• dependabot/github_actions/github/codeql-action-3.28.18
• dependabot/github_actions/github/codeql-action-3.28.19
• dependabot/github_actions/github/codeql-action-3.28.2
• dependabot/github_actions/github/codeql-action-3.28.3
• dependabot/github_actions/github/codeql-action-3.28.4
• dependabot/github_actions/github/codeql-action-3.28.5
• dependabot/github_actions/github/codeql-action-3.28.6
• dependabot/github_actions/github/codeql-action-3.28.8
• dependabot/github_actions/github/codeql-action-3.28.9
• dependabot/github_actions/github/codeql-action-3.29.0
• dependabot/github_actions/github/codeql-action-3.29.1
• dependabot/github_actions/github/codeql-action-3.29.11
• dependabot/github_actions/github/codeql-action-3.29.2
• dependabot/github_actions/github/codeql-action-3.29.3
• dependabot/github_actions/github/codeql-action-3.29.4
• dependabot/github_actions/github/codeql-action-3.29.5
• dependabot/github_actions/github/codeql-action-3.29.8
• dependabot/github_actions/github/codeql-action-3.29.9
• dependabot/github_actions/github/codeql-action-3.30.0
• dependabot/github_actions/github/codeql-action-3.30.1
• dependabot/github_actions/github/codeql-action-3.30.2
• dependabot/github_actions/github/codeql-action-3.30.3
• dependabot/github_actions/github/codeql-action-3.30.4
• dependabot/github_actions/github/codeql-action-3.30.5
• dependabot/github_actions/github/codeql-action-3.30.6
• dependabot/github_actions/github/codeql-action-4.30.7
• dependabot/github_actions/github/codeql-action-4.30.8
• dependabot/github_actions/github/codeql-action-4.31.0
• dependabot/github_actions/github/codeql-action-4.31.1
• dependabot/github_actions/github/codeql-action-4.31.2
• dependabot/github_actions/github/codeql-action-4.31.3
• dependabot/github_actions/golangci/golangci-lint-action-6.2.0
• dependabot/github_actions/golangci/golangci-lint-action-6.3.0
• dependabot/github_actions/golangci/golangci-lint-action-6.3.1
• dependabot/github_actions/golangci/golangci-lint-action-6.4.0
• dependabot/github_actions/golangci/golangci-lint-action-6.5.0
• dependabot/github_actions/golangci/golangci-lint-action-6.5.1
• dependabot/github_actions/golangci/golangci-lint-action-6.5.2
• dependabot/github_actions/golangci/golangci-lint-action-8.0.0
• dependabot/github_actions/golangci/golangci-lint-action-9.0.0
• dependabot/github_actions/marocchino/sticky-pull-request-comment-2.9.1
• dependabot/github_actions/marocchino/sticky-pull-request-comment-2.9.2
• dependabot/github_actions/marocchino/sticky-pull-request-comment-2.9.3
• dependabot/github_actions/marocchino/sticky-pull-request-comment-2.9.4
• dependabot/github_actions/ossf/scorecard-action-2.4.1
• dependabot/github_actions/ossf/scorecard-action-2.4.3
• dependabot/github_actions/shogo82148/actions-goveralls-1.10.0
• dependabot/github_actions/shogo82148/actions-goveralls-1.9.1
• dependabot/go_modules/github.com/andybalholm/brotli-1.2.0
• dependabot/go_modules/github.com/klauspost/compress-1.18.0
• dependabot/go_modules/github.com/klauspost/compress-1.18.1
• dependabot/go_modules/github.com/klauspost/compress-1.18.2
• dependabot/go_modules/github.com/pierrec/lz4/v4-4.1.22
• dependabot/go_modules/github.com/pierrec/lz4/v4-4.1.23
• dependabot/go_modules/github.com/spf13/afero-1.12.0
• dependabot/go_modules/github.com/spf13/afero-1.15.0
• dependabot/go_modules/github.com/stretchr/testify-1.11.1
• dependabot/go_modules/github.com/ulikunitz/xz-0.5.14
• dependabot/go_modules/github.com/ulikunitz/xz-0.5.15
• dependabot/go_modules/golang.org/x/sync-0.10.0
• dependabot/go_modules/golang.org/x/sync-0.11.0
• dependabot/go_modules/golang.org/x/sync-0.15.0
• dependabot/go_modules/golang.org/x/sync-0.16.0
• dependabot/go_modules/golang.org/x/sync-0.17.0
• dependabot/go_modules/golang.org/x/text-0.21.0
• dependabot/go_modules/golang.org/x/text-0.22.0
• dependabot/go_modules/golang.org/x/text-0.26.0
• dependabot/go_modules/golang.org/x/text-0.27.0
• dependabot/go_modules/golang.org/x/text-0.28.0
• dependabot/go_modules/golang.org/x/text-0.29.0
• dependabot/go_modules/golang.org/x/text-0.30.0
• dependabot/go_modules/golang.org/x/text-0.31.0
• dependabot/go_modules/golang.org/x/text-0.32.0
• fix/aes7z-iv-corruption
• fix/folder-reader-bounds
• fix/fs-open-empty-file
• fix/header-stream-validation
• fix/lzma2-shift
• fix/oom-check
• fix/read-coder-short-reads
• fix/skip-unknown-file-properties
• fuzz
• issue329
• issue400
• issue457
• main
• master
• multi
• optimized_xz
• ppmd
• refs/tags/v1.2.0
• refs/tags/v1.2.1
• refs/tags/v1.2.2
• refs/tags/v1.3.0
• refs/tags/v1.4.0
• refs/tags/v1.4.1
• refs/tags/v1.4.2
• refs/tags/v1.4.3
• release-please--branches--main
• renovate/actions-checkout-5.x
• renovate/actions-checkout-6.x
• renovate/actions-checkout-7.x
• renovate/commitizen-tools-commitizen-3.x
• renovate/commitizen-tools-commitizen-4.x
• renovate/configure
• renovate/github-codeql-action-4.x
• renovate/github.com-andybalholm-brotli-1.x
• renovate/github.com-klauspost-compress-1.x
• renovate/github.com-pierrec-lz4-v4-4.x
• renovate/github.com-spf13-afero-1.x
• renovate/github.com-stangelandcl-ppmd-0.x
• renovate/github.com-stretchr-testify-1.x
• renovate/github.com-ulikunitz-xz-0.x
• renovate/gitleaks-gitleaks-8.x
• renovate/go4.org-digest
• renovate/golang.org-x-sync-0.x
• renovate/golang.org-x-text-0.x
• renovate/golangci-golangci-lint-2.x
• renovate/major-github-artifact-actions
• renovate/marocchino-sticky-pull-request-comment-3.x
• renovate/ossf-scorecard-action-2.x
• renovate/pre-commit-pre-commit-hooks-4.x
• renovate/pre-commit-pre-commit-hooks-6.x
• v1.0.0
• v1.1.0
• workflows

Build # 37245007427

Build Type

Pull #500

github

Committed by bodgit

Commit Message

fix: close pooled readers instead of leaking them

Folder readers kept for reuse by File.Open could be leaked without
being closed, holding on to decompressor state such as LZMA
dictionaries, zstd decoder goroutines, and decoders that are only
returned to their sync.Pool on Close:

* Pool.Put silently dropped a reader if one was already pooled at the
  same offset.
* ReadCloser.Close never closed the pooled readers.
* A file closed after its archive returned its reader to the pool.
* File.Open didn't close a new folder reader if the initial Seek
  failed.

Close the reader in Pool.Put if it can't be pooled, add a Close method
to Pooler that closes all pooled readers and closes any later returned
ones immediately, call it from ReadCloser.Close before closing the
volumes, and close the reader on a failed Seek in File.Open.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Pull Request Pull Request #500: fix: close pooled readers instead of leaking them

Coverage Stats

28 of 29 new or added lines in 2 files covered. (96.55%)

1965 of 2559 relevant lines covered (76.79%)

0.87 hits per line