bitcoindevkit / bdk

79%

master: 78%

LAST BUILD ON BRANCH release/chain-0.23.x

branch: release/chain-0.23.x

CHANGE BRANCH

x

Reset

• release/chain-0.23.x
• 05-18-2025-smt-replenish
• 1704_build_fee
• 1705_mod
• 2025-02-14-coinbase-utxos
• 2026-04-electrum-txid-check
• 2026-04-fix-canonical-iter-missing-continue
• 2026-04-fix-spk-iterator-overflow
• 2026-04-genesis-protection
• 23.x/chore/remove-start-core-script
• ChainPosition
• add-first-seen
• add_persist_test_utils
• arm-ci
• assume_not_canonical
• backport/2058
• backport/pr-2167
• backport/pr-2195
• backport/send_recvd_txouts
• bench/reindex-tx-graph
• bgg
• box_changeset
• bugfix/i-1517-store-append-after-open-causes-overwrite
• bump-bitcoin-0.32.4
• bump/rusqlite-0.32
• canonical-txnode-refactor
• canonical-view
• canonical-view-docs
• canonical-view-extract-rbf
• canonicalization_improvements
• chain_0_23_x_msrv
• check-docs
• checkpointentry
• chore/add-rustfmt
• chore/bump-msrv-to-1.85.0
• chore/bump-rust-version
• chore/clippy
• chore/codeowners
• chore/fix_build_warnings
• chore/optional-change-descriptor-on-example
• chore/remove-start-core-script
• chore/remove_wallet
• chore/use-core-error
• ci-verify-build-without-workspace
• ci/20250221
• ci/add-secondary-msrv-build-test-job
• ci/apply-zizmor-security-audit
• ci/clippy
• ci/cron_update_rust
• ci/fix-coverage-job
• ci/fix-docs
• ci/fix_msrv_esplora
• ci/fix_nightly_docs
• ci/msrv
• ci/msrv-base64ct
• ci/pin-bzip2-sys-to-0.1.12
• ci/pin-code-coverage-to-0.6.15
• ci/pin-minreq
• ci/pin-proptest-dep-to-supported-msrv
• ci/pin-socket2-0.6.0-to-0.5.10
• ci/pin_home
• ci/publish-docs-job-fails-with-permission-denied
• ci/replace-grcov-by-cargo-llvm-cov
• ci/update-pinned-webpki-roots
• ci/use-explicit-ubuntu-version
• ci/zizmor
• clippy
• cmake_msrv
• confirmation-policy
• cp_entry
• create-pull-request/update-rust-version
• dependabot/github_actions/Swatinem/rust-cache-2.7.3
• dependabot/github_actions/Swatinem/rust-cache-2.7.5
• dependabot/github_actions/Swatinem/rust-cache-2.7.7
• dependabot/github_actions/Swatinem/rust-cache-2.7.8
• dependabot/github_actions/Swatinem/rust-cache-2.8.0
• dependabot/github_actions/Swatinem/rust-cache-2.8.1
• dependabot/github_actions/Swatinem/rust-cache-2.8.2
• dependabot/github_actions/Swatinem/rust-cache-2.9.1
• dependabot/github_actions/actions/checkout-4
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/create-github-app-token-3
• dependabot/github_actions/actions/download-artifact-4
• dependabot/github_actions/actions/setup-python-5
• dependabot/github_actions/actions/upload-artifact-4
• dependabot/github_actions/actions/upload-artifact-5
• dependabot/github_actions/actions/upload-artifact-6
• dependabot/github_actions/actions/upload-artifact-7
• dependabot/github_actions/crazy-max/ghaction-import-gpg-6
• dependabot/github_actions/crazy-max/ghaction-import-gpg-7
• dependabot/github_actions/github/codeql-action-4
• dependabot/github_actions/peter-evans/create-pull-request-7
• dependabot/github_actions/peter-evans/create-pull-request-8
• dependabot/github_actions/peter-evans/create-pull-request-8.1.0
• dependabot/github_actions/peter-evans/create-pull-request-8.1.1
• dependabot/github_actions/tibdex/github-app-token-2
• deps/bump-electrsd-0-38-0
• deps/bump-electrsd-version
• deps/bump-miniscript-to-12.x
• deps/bump-miniscript-to-13.x.x
• doc/adr
• doc/security
• doc/update-readme
• doc/wallet-changeset
• docs/add-new-filter-iter-example
• docs/first_time_contribs
• docs/fix-local-chain-genesis-replacement-docs
• docs/txupdate-temporal-context
• double_spend
• editorconfig
• electrum_anchor_fix
• electrum_clarify
• electrum_exploit_fixes
• esplora
• evicted_at
• example/cli-build-psbt
• example/cli-feerate
• feat/add-check-for-network-consistency
• feat/ancestor-bump-fee
• feat/blockid-impls
• feat/bump-esplora-client
• feat/cancel-tx-wallet
• feat/create-multipath
• feat/filter-iter
• feat/filter_iter_detects_reorgs
• feat/improved-sync
• feat/justfile
• feat/non_exhaustive_changesets
• feat/plan
• feat/replace-tx
• feat/send_recvd_txouts
• feat/sqlite_pre1_migration_helper
• feat/testnet4
• feat/toblockhash_prev
• feat/use-batch-transaction-get-merkle-api
• feature/add-last-evicted-to-txnode
• feature/allow_bdk_electrum_client_to_take_by_ref
• feature/bip322-support
• feature/bitcoind_rpc_emit_header
• feature/cp_data_with_mtp
• feature/mtp
• feature/relevant_conflicts
• feature/skiplist
• feature/spk_cache
• feature/testenv-mine-with-timestamp
• feature/tx-graph-get-last-evicted
• feature/tx_update_is_empty
• filter_iter
• fix
• fix-rpc-example-readme
• fix/1665
• fix/FilterIter-may-not-handle-reorgs-properly
• fix/better-chain-position-ord
• fix/bitcoind_rpc_mempool
• fix/build-fee-bump-single-desc
• fix/chain-0.23.x-better-chain-position-ord
• fix/check-foreign-utxos-are-foreign
• fix/checkpoint-drop-mem-leak
• fix/checkpoint-drop-memory-leak
• fix/ci-code-coverage-step
• fix/ci-msrv
• fix/ci-msrv-step
• fix/ci-ring-0_17_13
• fix/clippy-warnings
• fix/disallow-unconfirmed-coinbase
• fix/electrsd-timeout-on-tests
• fix/electrum_negative_height
• fix/esplora-chain-update
• fix/esplora-client-deprecated-method
• fix/esplora-compile
• fix/esplora-dedup-missing-txids-outpoints
• fix/forward-confirmation-height-upper-bound-anchor
• fix/full_scan
• fix/into-descriptor-key
• fix/keychain_txout_apply_changeset
• fix/merge-chains-docs
• fix/no-debug-on-display-impls
• fix/no-std-serde-json
• fix/off-by-one-error-in-coinbase-coin-selection
• fix/persistedwallet_send_sync
• fix/rpc-reorg
• fix/wait_until_electrum_sees_block
• fix/wallet-transactions-should-only-be-relevant
• fix/wallet-transactions-test
• fix_electrum_panics
• fix_populate_with_txids
• generic_checkpoint
• grcov_temp_fix
• improve_safety_on_finalize_psbt
• improve_triage
• index-spk-ref
• kwsantiago/1973-simplify-examples
• master
• mempool_evicted
• merkle_batching
• min_confirmations
• miniscript_bump
• missing_marker
• msrv_flate2
• msrv_once_cell
• one_liner_sync
• optimize-ci-caching
• optional_data
• owned-k
• patch-1
• perf/spends-hashmap-optimization
• persist_first_seen
• pin_chain_version_for_wallet
• pin_webpki
• populate-anchor-cache
• rayon_msrv
• redb
• refactor/canonical-iter-api
• refactor/cleanup_create_tx
• refactor/coin_selection_amounts
• refactor/core-rpc-to-client-lib
• refactor/make-chainoracle-infallible
• refactor/mv-txtemplate-to-testenv
• refactor/next-unused-address-rename-to-last-unused-address
• refactor/remove-chain-oracle-dependency-from-canonical-iter
• refactor/sans-io-mtp-chain-query
• refactor/use-bitcoind-client
• refactor/use-iterators-to-preselect-utxos
• refactor/wallet-tests
• refs/tags/before_1380
• refs/tags/bitcoind_rpc-0.18.0
• refs/tags/bitcoind_rpc-0.21.0
• refs/tags/bitcoind_rpc-0.22.0
• refs/tags/chain-0.23.1
• refs/tags/chain-0.23.2
• refs/tags/chain-0.23.3
• refs/tags/core-0.6.1
• refs/tags/core-0.6.2
• refs/tags/core-0.6.3
• refs/tags/electrum-0.21.0
• refs/tags/electrum-0.23.1
• refs/tags/electrum-0.23.2
• refs/tags/electrum-0.24.0
• refs/tags/esplora-0.22.1
• refs/tags/esplora-0.22.2
• refs/tags/file_store-0.19.0
• refs/tags/file_store-0.21.1
• refs/tags/file_store-0.22.0
• refs/tags/testenv-0.13.1
• refs/tags/v1.0.0-alpha.10
• refs/tags/v1.0.0-alpha.11
• refs/tags/v1.0.0-alpha.12
• refs/tags/v1.0.0-alpha.13
• refs/tags/v1.0.0-alpha.7
• refs/tags/v1.0.0-alpha.8
• refs/tags/v1.0.0-alpha.9
• refs/tags/v1.0.0-beta.1
• refs/tags/v1.0.0-beta.2
• refs/tags/v1.0.0-beta.3
• refs/tags/v1.0.0-beta.4
• refs/tags/v1.0.0-beta.5
• refs/tags/v1.0.0-beta.6
• refs/tags/wallet-1.1.0
• refs/tags/wallet-1.2.0
• release/0.23.2
• release/bdk-chain-0.23.1
• release/bitcoind_rpc_0_22_1
• release/bump-crates-version
• release/bump_dev_1.0.0
• release/bump_dev_1.0.0_beta.6
• release/chain-0.23.2
• release/chain-0.23.3
• release/electrum-0.24.0
• release/wallet-1.1
• release/wallet-1.2.0
• release_0_23_0
• release_chain_0_22_0
• remove-indexed-tx-graph
• sanitize_derivation_index_in_apply_changeset
• serde-sync-response
• socket2-msrv
• socket2_msrv
• superimposed_canonicalization
• test-arm-runner
• test-excluded-bound
• test/add-canonical-iter-topological-order-tests
• test/merge
• test/move-txtemplate-to-testenv
• test/tx-update-map-anchors
• test_coverage_workflow
• test_electrum_fee_calculation
• test_timelock_descriptors
• time_core_msrv
• tracing-core
• tracing_feature
• tx-builder-2-16
• tx-graph-from-changeset
• tx_builder_default_version
• tx_update_cleanup
• update-dependencies-1797

Build # 25599869850

Build Type

push

github

Committed by evanlinjin

Commit Message

Merge bitcoindevkit/bdk#2198: fix(bitcoind_rpc): backport PR#2167

<a class=hub.com/bitcoindevkit/bdk/commit/b5af3c78d08538645783dac15a84afbaffa4eabf">b5af3c78d fix(bitcoind_rpc): emit invalidated heights when start_height is above agreement point (志宇)

Pull request description:

  ### Description

  It's a backport for the the `bdk_bitcoind_rpc` fix introduced by #2167. If you're interested in the original fix, check the original PR for discussion/rationale.

  ### Notes to the reviewers

  The introduced tests needs a review, as I had to update it use the older Emitter and TestEnv APIs.

  ### Changelog notice

  ```
  ### Fixed:
  - `Emitter` producing un-connectable checkpoints when `start_height` is above the agreement point after a reorg.
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### Bugfixes:

  * [x] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    ACK b5af3c78d08538645783dac15a84afbaffa4eabf

Tree-SHA512: d9166fd37b3cc465fc54e823ef5fb8911a9

Coverage Stats

390 of 536 branches covered (72.76%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

4406 of 5532 relevant lines covered (79.65%)

2170.28 hits per line