binbashar / leverage

65%

Build Type

push

github

Committed by web-flow

Commit Message

Fix | Restore the unit test suite (#322)

* Fix | Restore the unit test suite

The unit test workflow has been failing on master since #316, across three
consecutive merges. This restores it on the whole 3.9 - 3.13 matrix.

Reconcile test_credentials.py with the dockerless design:

  #316 rewrote leverage/modules/credentials.py but left its tests untouched,
  so the module failed to import and pytest aborted during collection, which
  masked every other failure in the run. The tests now inject the runner,
  paths and config through the click context, as `pass_runner`, `pass_paths`
  and `pass_state` expect, and account for `Runner.exec` returning a
  (exit code, stdout, stderr) triple and for the `-mfa` profile suffix that
  `refresh_layer_credentials_mfa` looks up.

Fix _update_account_ids corrupting common.tfvars:

  #316 replaced the hcledit call with a non-greedy regex that stops at the
  first closing brace. On a nested `accounts` block, which is what the
  reference architecture ships, it replaced only the first account, left the
  remaining ones orphaned outside the block and produced invalid HCL with
  unbalanced braces. Replacement now scans for the matching brace, and is
  anchored so `external_accounts` is no longer a candidate match.

Fix mock target resolution on Python 3.9:

  `leverage/modules/__init__.py` re-exports the click Groups, so
  `leverage.modules.<name>` resolves to the Group rather than to the module.
  From 3.10 on mock resolves these targets through `pkgutil.resolve_name` and
  finds the module anyway, but on 3.9 it walks attributes and finds the Group,
  raising AttributeError during setup. The affected targets are now patched by
  object, which behaves the same on every supported version.

Update test_tf.py for the tfvars injected into init, added deliberately in
#316 for ref-arch v2. The tfvars are discovered by globbing, so their order
depends on the filesystem and is asserted as a set.

Use a raw string for the regex ... (continued)

Coverage Stats

514 of 1024 branches covered (50.2%)

Branch coverage included in aggregate %.

30 of 33 new or added lines in 2 files covered. (90.91%)

763 existing lines in 22 files now uncovered.

2778 of 4014 relevant lines covered (69.21%)

0.69 hits per line