ayazhafiz / hgb

96%

master: 95%

LAST BUILD ON BRANCH i/51-while

branch: i/51-while

CHANGE BRANCH

x

Reset

• i/51-while
• 15
• 15-ah-patch
• RemoveChar
• TestAdd
• codegen.c
• e/floating-point
• e/github
• e/pedantic
• e/scripts
• eval
• extend-parer
• final_expr
• i/32
• i/38-char-type
• i/38-lex-char
• i/38-parse-char
• i/38-string-type
• i/40
• i/43
• i/47
• i/51-for
• i/52
• i/52-bool
• i/69-ts
• i/71
• i/87
• i/fixup
• i/grammar-types
• i/hindent-incr
• i/lex-symbol
• i/scripts
• i/test-dsl
• i/ts-codegen-validate
• i/ts-string-char-ref-asgn
• lexer_change
• lukas
• master
• nomorebits
• numbertype
• parse-arrays
• patch-extend-parser
• r/return
• refactor-expectation
• refactor/lexer
• reorder
• scripts
• simplify_cond
• static-typing
• stopwastingtime
• style
• test/lexer
• ts-more
• ts/calls
• ts/fn-decl
• ts/types
• typecheck
• underscore

Build # 463

Build Type

push

travis-ci-com

Committed by ayazhafiz

Commit Message

Parse while loops

While adding this feature, I realized we have a problem in some of the
ways we parse expressions. Most expressions (e.g. binary operators)
return the token stream after the expression when they are finished
parsing, but block expressions stop at their terminating brace and the
returned token stream includes the close brace.

```
while true { doWork() }
      ^^^^              parsed expr
           ^^^^^^^^^^^^ rest of token stream

while if true {true} else {false} { doWork() }
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^              parsed expr
                                ^^^^^^^^^^^^^^ rest of token stream

Also fails with parened expressions:
while (if true {true} else {false}) { doWork() }
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^              parsed expr
                                  ^^^^^^^^^^^^^^ rest of token stream
```

This probably isn't a big deal for now, but I think the best way going
forward for consistency would be to parse the closing token with the
expression and require that blocks end with `!` in a statement context.
This could be kinda ugly though, so I'm interested in other ideas.

```
if true {
  doSomething()
} else {
  never()
}!
```

Part of #51

Run Details

447 of 464 relevant lines covered (96.34%)

0.96 hits per line