aws / karpenter-core

82%

main: 80%

LAST BUILD ON BRANCH fix-nodepool-validation-check

branch: fix-nodepool-validation-check

CHANGE BRANCH

x

Reset

Sync Branches

• fix-nodepool-validation-check
• 2902
• 3696
• Considering_LimitRanges_to_Daemonsets
• HostPortUsage-UT
• Implement_Structured_Logging
• Logs_Lower_Case_Start
• Remove-cel-test-for-1.24-and-less
• UnschedulablePods
• add-additional-exempt-labels
• add-ci-to-pr-template
• add-cloudprovider-readiness
• add-cluster-name
• add-debug-log-for-volume-requirements
• add-dependabot
• add-deprovisioning-logging
• add-k8s-27
• add-k8s-template-files
• add-machine-controller
• add-machine-requests
• add-more-visibility
• add-nodeclaim-state-informer
• add-nodepool-drifted-reason
• add-notice-file
• add-provisioner-context
• add-retracted-version
• add-stale-bot
• add-static-logging-config
• add-webhooks-for-machines
• adding_metadata_label
• addtemplates
• allow-disable-webhook
• allow-disabling-webhooks
• allow-logging-file-mount
• allow-node-restriction-label
• allow-nodepool-as-selector
• allow-testing-label
• alter-bindings-tracking
• annotateExpiry
• annotations
• async
• benchmark
• blocked-eventing
• boolean-parse
• bsoghigian/trunc
• budgetsAPI
• budgetsTesting
• bump-eviction-api-to-v1
• bump-k8s-1.26
• bump-onsi-gomega
• cache-speed-up
• cache-sync-finalization
• cache-syncing-client
• cel_requirements_cleanup
• cel_validation_nodeclaim_test
• cel_validation_v1beta1_nodepool_disruption
• change_env_parameters
• change_metav1Duration_to_timeDuration
• chore
• chore-IgnoreMachineNotFoundError-drift
• ci
• cleanup
• cloudProvider-errors_total-metrics
• cloudprovider-metrics-missing-list
• cluster-state-fix
• cluster-state-with-machine
• config-map-migration-v1beta1
• configure-controller-runtime-logger
• consider-existing-cap
• consider-pod-overhead
• consolidated-dirty-bit-clarity
• consolidationWaitFix
• constrain-action-perms
• constrain-on-labels
• controller-renames
• controller-runtime-ns-metrics
• conversion-utils-funcs
• countertest
• create-return-machine
• deadcode
• deepcopy-machine
• deepcopy-settings
• default-settings
• default-webhook-log-level
• deflake-consolidation-timeout-tests
• deflake-deprov-ordering-tests
• deflake-deprovisioning-tests
• deflake-test
• delete-watching-typed
• deletionwh
• dependabot/github_actions/actions-deps-8a9da2b879
• dependabot/go_modules/github.com/go-logr/logr-1.2.4
• dependabot/go_modules/github.com/go-logr/zapr-1.2.4
• dependabot/go_modules/github.com/go-playground/validator/v10-10.11.2
• dependabot/go_modules/github.com/imdario/mergo-0.3.15
• dependabot/go_modules/github.com/imdario/mergo-0.3.16
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.8.0
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.8.4
• dependabot/go_modules/github.com/onsi/ginkgo/v2-2.9.2
• dependabot/go_modules/github.com/onsi/gomega-1.26.0
• dependabot/go_modules/github.com/onsi/gomega-1.27.2
• dependabot/go_modules/github.com/onsi/gomega-1.27.6
• dependabot/go_modules/github.com/onsi/gomega-1.27.8
• dependabot/go_modules/github.com/prometheus/client_golang-1.14.0
• dependabot/go_modules/github.com/prometheus/client_golang-1.15.0
• dependabot/go_modules/github.com/prometheus/client_model-0.3.0
• dependabot/go_modules/github.com/prometheus/client_model-0.4.0
• dependabot/go_modules/github.com/samber/lo-1.37.0
• dependabot/go_modules/github.com/samber/lo-1.38.1
• dependabot/go_modules/go-deps-027c04c118
• dependabot/go_modules/go-deps-2e02be56b2
• dependabot/go_modules/go-deps-417260f0ce
• dependabot/go_modules/go-deps-4a9c59c9f6
• dependabot/go_modules/go-deps-6fea18231a
• dependabot/go_modules/go-deps-73f75109a5
• dependabot/go_modules/go-deps-b828c89960
• dependabot/go_modules/go-deps-c12498a31b
• dependabot/go_modules/go-deps-f0e5d3434b
• dependabot/go_modules/go-deps-f455f629c9
• dependabot/go_modules/go-deps-f89516ff8d
• dependabot/go_modules/go.uber.org/multierr-1.11.0
• dependabot/go_modules/go.uber.org/multierr-1.9.0
• dependabot/go_modules/go.uber.org/zap-1.24.0
• dependabot/go_modules/golang.org/x/net-0.17.0
• dependabot/go_modules/golang.org/x/time-0.3.0
• dependabot/go_modules/google.golang.org/grpc-1.53.0
• dependabot/go_modules/google.golang.org/grpc-1.56.3
• dependabot/go_modules/k8s-go-deps-1ad4ab4cba
• dependabot/go_modules/k8s-go-deps-77c1c3e4ac
• dependabot/go_modules/k8s-go-deps-99e2caa5ce
• dependabot/go_modules/k8s-go-deps-da71d5e976
• dependabot/go_modules/k8s.io/apimachinery-0.27.4
• dependabot/go_modules/k8s.io/klog/v2-2.100.1
• deprov-fallthru
• deprovDesign
• deprovInterface
• deprovLog
• deprovision-with-bad-provisioner
• deprovisioning
• disabled-rate-limiter
• disc
• discover-default-sc
• disruption-controller-rename
• do-not-evict-hanging
• drift
• driftDoc
• driftInterface
• driftorder
• drop-calling-named-twice
• drop-container-runtime
• drop-nodeclaim-key
• drop-nodepool-owner-key
• drop-shortname
• drop-usage-metric
• dual-tracking-inflight
• eks-128
• emitEvents
• emptiness-logs
• empty-storageclass-fix
• enable-actionlint
• enable-interruption-handling-ff
• enable-version-in-useragent
• enforce-strict-compat
• env
• ephemeral-taints-rem-for-init
• error-on-no-provider
• exact-limit-match
• existence-sub-reconciler
• expectation
• expiration
• expirationrequeue
• expiredrift
• extend-operator
• feature/optimize-performance-2
• feature/use-stack-when-listing-resources
• filter-offerings
• filterrefactor
• firstRemoval
• fix
• fix-1.26-taints
• fix-_invalide_knative_port
• fix-badge
• fix-batcher-settings-injection
• fix-bool-check
• fix-cache-syncing
• fix-caching
• fix-consolidation-issue
• fix-consolidation-metrics
• fix-consolidation-pause-bug
• fix-consolidation-trigger
• fix-cpu-fs-quota
• fix-data-race
• fix-dedupe-events
• fix-dereference-panic
• fix-disruption-method-printing
• fix-empty-machine-validation-check
• fix-ephemeral-volume-sc-validation
• fix-error-type
• fix-failed-scheduling-testing
• fix-fd-leak
• fix-fits-func
• fix-generic-controller
• fix-gomega-interface
• fix-grouping
• fix-hash-annotation-key
• fix-key-suffix
• fix-liveness-readiness
• fix-log-formatting
• fix-logging
• fix-memory-leak
• fix-metrics-bug
• fix-missed-1.26-deps
• fix-missed-pin-gha
• fix-must-parse
• fix-namespace-pdb-not-considerd
• fix-node-initialize
• fix-node-requeue
• fix-node-termination-summary-metric
• fix-provider-id-change
• fix-provisioner-requirement-restriction
• fix-rest-config
• fix-scheduling-profiling
• fix-spammy-startup-events
• fix-symlink
• fix-symlink-crds
• fix-termination-panic
• fix-terminator-multi-logging
• fix-validation-do-not-evict
• fix-volume-topology-issue
• fixEmptiness
• fixTest
• fix_volume_limit
• fixdefault
• flatten-v1alpha5
• fourthRemoval
• garbage-collect-separate
• gate-node-deletion-provider-id
• generate-deepcopy
• generic-controller
• generic-pod-filers
• getdaemonset-respects-pod-affinity-in-daemonset-template
• ginkgo
• ginkgo-parallel
• go-120
• go-121
• goupgrade
• grace
• group-dependabot-deps
• ha
• handle-beta-rollback
• handle-ephemeral-volume-topology
• handle-nil-status-resources
• helper-funcs
• ice_events
• ignore-machine-notfound
• ignore-permanently-pending-pods-for-consolidation
• improve-consolidation-visibility
• improve-error-messages
• improve-log-for-unsat-topology-constraint
• improve-scheduling-error-message
• improve-scheduling-speed
• inflight-checks
• info
• info-message-for-no-provisioners
• infoLevel
• inject-discovery-label
• insufficient-capacity
• isMachineDrifted_reason
• iss
• issue
• issue-157-fix
• it-struct
• k8s-version-cache-fix
• knative-broken-webhook
• kubeserver
• launch-separate
• launchfailuremetric
• leader-election
• leasegarbage_collection
• liveness
• local-settings-file
• log-cumulative-resource-request
• log-daemonset-overhead-on-failure
• log-more-clear-error-message
• log-pod-names-were-provisioning
• logFix
• logging
• machine-cluster-state
• machine-created-rename
• machine-delete
• machine-disruption
• machine-hydration
• machine-link-controller
• machine-metrics
• machine-migration
• machine-resources
• machine-spec
• machine-spec-in-memory
• machine-types
• machine_test_faliure
• main
• maintenance
• managed-by-annotation
• merged-cluster-state
• metrics
• metrics_disruption_controller
• migrate-event-recorder
• migrate-settings
• migrated-to-annotation
• minimize
• move-goveralls
• move-settings-init
• moveDrift
• move_env_for_v1bata1
• multi-node-consolidation
• nf
• no-constrain-nodeclaim-by-default
• noOwnerRef
• node-registration-label
• nodeMachine
• nodeRequirement_drift
• node_restriction_label_ns
• nodeclaim-controllers
• nodeclaim_template_kublet_cel
• nodeclaim_template_labels_cel
• nodeclaim_template_requirements_cel
• nodeclaim_template_taints_cel
• nodeclass-not-ready-error
• nodepool-informer
• nodepool-metrics-controller
• nodepool-status
• nodeshape-requested-resources
• noha
• noschedule
• nosimulate
• odd_casing
• options-injection
• orchestrate
• order-initialized-nodes
• panic
• pass-version-to-presubmit
• patch-v0.31.2
• patch-v0.31.x-release
• pdb
• pin-action-versions
• pr
• pr-temp
• preferrer-node-affinity-spread-issue
• presubmits-1.25-and-1.26
• printer-columns
• probe
• propagate-discovery-label
• propercordon
• provisioner-static-drift
• provisioner-v1beta1-support
• ptr
• quicker-counter-reaction
• ready
• reason-in-nodes
• reconcile-duration-metric
• reconcile-return-fix
• record-scheduling-duration-in-log
• reduce-event-spam-from-deprov
• reduce-log-spam
• register-machine-in-scheme
• release-v0.27.4
• release-v0.27.5
• release-v0.27.6
• release-v0.27.x
• remove-1.20-from-ci
• remove-autopatch
• remove-container-loglevel
• remove-dead-code
• remove-delete-verb
• remove-deprovisoining-reporter
• remove-eviction-observer
• remove-k8s-1.21
• remove-karpenter-core-charts
• remove-options
• remove-runtime-settings-changes
• remove-sets-usage
• remove-ttl-not-registered
• removeBeforeFive
• removeClientUtils
• removeOldTaint
• removeProvisionerUtils
• removeRemainder
• removeState
• remove_1.22_from-testing
• remove_NotDrifted
• rename-api-fields
• rename-deprovisioning
• rename-empty-node-consolidation
• rename-v1beta1-directories
• reorganize-dirs
• requeue
• require-template-for-nodepool
• retract-patch
• revert
• revert-25-knative-broken-webhook
• revert-283-remove-container-loglevel
• revert-event-filters
• revert-incompat-commit
• revert-machine-migration
• revert-machine-migration-changes
• revertBudgets1
• revertChange
• rfc
• rm-dup-log
• rm-rbac-wh
• rm/add-helm-charts
• rm/add-helm-ownership-metadata
• rm/bump-chart-version
• rm/chart-separation
• rm/exclude-machine-crd
• rm/fix-chart-names
• rm/fix-perm
• rm/fix-symlink
• rm/move-project-version
• sadath-dev-0
• sadath-dev-1
• sadath-v1
• scope-lease-to-node-namespace
• secondRemoval
• separate-lifecycle
• settings-defaults
• settings-store-testing
• settings-testings
• simplify-node-metrics
• single-init-capacity-taints
• singleton-controller
• speed-up-labels-to-string
• spot
• stage-v0.32.2
• staging
• static-hash-testing
• static_drift_annotation
• static_drift_for_provisioners
• support-pdb-policy
• sync-node-when-nodetemplate-DNE
• sync-shorter-requeue
• taint
• te
• terminate-separate
• terminate-sooner
• termination-delete-all-nodeclaims
• terminationTaint
• terminationcheck
• terminationmetric
• test-1
• test-replace-requirements
• testing-updates
• thirdRemoval
• timeoutmetric
• timeouts
• topo
• topologySpreadConstraints-minDomains
• translate-all-drivers
• trigger-verify
• truncate-instance-types
• try-other-provisioners
• ttl-after-not-registered
• typed-controller-key
• update-disruption-metric-description
• update-goveralls
• update-kubebuilder-install-path
• update-node-class-ref-name
• update-notice-file
• update-pr-staleness
• update-randomdelay
• updateK8sEnv
• update_drift_reason
• use-metric-store
• utils
• v1-operating-system
• v1alpha6
• v1beta1
• v1beta1-api-updates
• v1beta1-apis
• v1beta1-blocking-testing
• v1beta1-cloudprovider-conversion
• v1beta1-combined-deprovisioning-testing
• v1beta1-combined-provisioning-testing
• v1beta1-consistency-controller
• v1beta1-consolidation-testing
• v1beta1-counter-controller
• v1beta1-defaulting
• v1beta1-deprovisioning-testing
• v1beta1-hash-controller-testing
• v1beta1-instance-type-selection-test
• v1beta1-machine-testing
• v1beta1-nodeclaim-state
• v1beta1-nodepool-controller
• v1beta1-object-meta
• v1beta1-provisioning-controller-testing
• v1beta1-scheduling-benchmark-test
• v1beta1-scheduling-testing
• v1beta1-topology-test
• validate-volume-names
• vol
• volume-in-tree
• wait-for-cache-sync
• wait-for-cm-creation
• wait-for-instance-type-label
• wait-for-node-provider-id
• warn-on-no-provisioners
• webhooks
• well-known-label-reqs
• wh
• wk/daemon-metrix-swap-fix
• wk/per-provisioner-metrics

Build # 6898421559

Build Type

Pull #794

github

Committed by jonathan-innis

Commit Message

Fix linting failures

Pull Request Pull Request #794: fix: Fix `RuntimeValidate` check to only check NodePools

Run Details

3 of 6 new or added lines in 1 file covered. (50.0%)

9272 of 11242 relevant lines covered (82.48%)

433361.05 hits per line