avajs / ava

97%

master: 42%

LAST BUILD ON BRANCH fail-if-test-ends-with-pending-assertions

branch: fail-if-test-ends-with-pending-assertions

CHANGE BRANCH

x

Reset

• fail-if-test-ends-with-pending-assertions
• master
• v0.15.0
• v0.15.1
• browser-support
• 0.15
• v0.15.2
• lodash-difference
• v0.16.0
• failure-output
• fix-windows-cli
• update-ava-files
• no-power-assert
• pitfalls-eslint-plugin
• more-async-pitfalls
• test-arguments-correction
• cleanup-api
• switch-deep-equal
• link-to-contrib-post
• reduce-transpilation
• improve-travis-caching
• cleanup-caching-precompiler
• upgrade-xo
• ensure-test-files-load-correct-ava
• precompile-helpers-fixtures
• v0.17.0
• remove-duplicate-test
• add-avacasts
• pr1145
• bump-ava-files
• improving-languange-support
• extract-babel-presets
• magic-assert
• v0.18.0
• replace-snapshot
• v0.18.1
• stub-stderr-write
• faster-flow-check
• rethrow-watch-logger-errors
• document-helper-caveat-in-code
• clarify-api-directories
• avoid-helper-compilation-during-api-tests
• api-test-cleanup
• coverage-report-html
• babelrc-recipe-cleanup
• use-hullabaloo
• ensure-test-run-failures-crash-worker
• code-excerpt-fixes
• format-actual-objects
• v0.18.2
• change-babel-hook-test
• improve-tap-reporter
• refactor-assertions
• more-assertion-changes
• test-overhaul
• better-throws-helper
• make-snapshot-work
• fix-enhanced-formatting
• allow-assertions-while-pending
• no-color-disables-formatting-highlights
• use-kathryn
• fix-get-port-usage
• v0.19.0
• max-listeners
• cb-end-ts
• v0.19.1
• remove-dead-flow-types

Build # 3236

Build Type

push

travis-ci

Committed by novemberborn

Commit Message

Fail tests that finish with pending assertions

`t.throws()` and `t.notThrows()` can be called with an observable or
promise. This commit forces users to wait for the assertion to complete
before finishing the test. Usually this means the test has to be written
like:

```js
test(async t => {
  await t.throws(Promise.reject(new Error()))
})
```

Or for callback tests:

```js
test.cb(t => {
  t.throws(Promise.reject(new Error())).then(t.end)
})
```

This simplifies internal logic and helps discourage code like in #1327.
Anecdotally users are surprised by the previous behavior where a
synchronous test worked with an asynchronous assertion
(https://github.com/avajs/ava/issues/1327#issuecomment-291122432).

Fixes #1327.

Run Details

965 of 1037 branches covered (93.06%)

12 of 12 new or added lines in 1 file covered. (100.0%)

2059 of 2125 relevant lines covered (96.89%)

589.17 hits per line