avagin / criu

66%

master: 64%

LAST BUILD ON BRANCH next

branch: next

CHANGE BRANCH

x

Reset

• next
• HEAD
• PSBM-67026
• alpine
• asan
• bad-page
• check-only
• compel
• corked_dgram
• coverall
• coverity_scan
• criu-dev
• criu-dev-netns
• criu-dev-next
• criu-dev-over-compel
• criu-dev-rebase
• criu-dev-test
• debug
• devel
• dsafonov
• fc-rawhide
• fd
• for-master
• for-xemul
• for-xemul-05112018
• gcc-7
• gcov
• issue-229
• issues/544
• jenkins
• jenkins-bash
• junit
• linux-next
• linux-next-20180112
• linux-next-cr
• linux-next-daily
• linux-next-test
• log
• mntns
• mntns_for_adrian
• netlink
• netns
• netns-4
• netns_ext
• netns_ext2
• pipeline
• ppc
• preadv
• proc
• python3
• rawhide
• remote
• rppt
• runc-console
• runc_issues_1333
• ruslan
• shell-job
• tcp-closing-states-v2
• test
• tmp
• travis
• unix_mnt_id

x86/kdat: Check PTRACE_TRACEME return value

Coverity has informed:

*** CID 188251:  Error handling issues  (CHECKED_RETURN)
/criu/arch/x86/crtools.c: 196 in kdat_x86_has_ptrace_fpu_xsave_bug_child()
190             return 0;
191     }
192     #endif
193
194     static int kdat_x86_has_ptrace_fpu_xsave_bug_child(void *arg)
195     {
>>>     CID 188251:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "ptrace" without checking return value (as is done elsewhere 46 out of 51 times).
196             ptrace(PTRACE_TRACEME, 0, 0, 0);
197             kill(getpid(), SIGSTOP);
198             pr_err("Continue after SIGSTOP.. Urr what?\n");
199             _exit(1);
200     }
201

Also added checks for kill() and waitpid().

Signed-off-by: Dmitry Safonov <dima@arista.com>