autograde / aguis

44%

master: 10%

LAST BUILD ON BRANCH createcourse

branch: createcourse

CHANGE BRANCH

x

Reset

• createcourse
• API_updates
• Groupresults
• Hanif
• ShowGroupCourseOverview
• StringTemplateURL
• Yannic
• adaptive-deadline-parser
• ag_dev
• api_update
• approve_refresh
• approved-labs-fix
• assignment_yaml
• ci-and-hooks
• commit-added-removed-fields-hotfix
• conditional-provider-list
• container_tags
• course_creation
• course_repo_links
• courseinformation
• delete_group_update
• demote_admin
• demote_teacher
• demote_teacher_restrictions
• dep_update
• dependabot/npm_and_yarn/public/lodash-4.17.19
• deps
• deps_update
• docker-fix
• dockertag
• docs
• documentation_updates
• dropmodels
• enrollment-refactor
• enrollments_refactoring
• envoy_config
• favicon
• feature/RejectedUserOverview
• getgroup_fix
• github_api_update
• gorm_updates_cleanup
• goth_github_access_token_issue
• group-lab-ui
• group_creation_instructions
• group_err_spam
• group_form
• group_form_button
• group_form_fix
• group_methods_refactoring
• group_repo_link
• group_repos
• group_submission_access
• groupnames_check
• groupresults
• groups
• groups_and_enrollments
• grpc-web-merge
• hook
• http_timeout
• kube-nodes
• lab_date_format
• lab_name_from_assignment_folder
• lab_submissions
• labresult_page_optimization
• labs_tests
• labview_redesign
• localhost_testing
• master
• meling-refactor
• member_list_updates
• member_view
• memberview_ui_fix
• method_arguments
• methods_rename
• metrics
• move-web-to-grpc
• new-grpc-web
• new_group_fix
• new_group_link
• newcourse
• newcourserequest
• newcoursetest
• next-assignment
• origin/group_methods_refactoring
• privrepocreation
• prometheus_config
• rebuild_fix
• remoteID_fix
• remoteid-and-group-fixes
• remove_empty_repos
• revising-go-tmpl
• scm_errors
• scm_methods
• scmtool
• selenium
• sort_member_list
• sort_members
• student_repo_links
• studentpage_dataflow
• studentpage_fix
• submission_fix
• tcp_accept_error_fix
• teamcreation
• template-fix
• test-grpc
• tools-dep
• uber-logger-test
• ui-updates
• ui_components
• ui_error_messages
• ui_list_buttons
• unapprove_submission
• update_labinfo_on_rebuild
• urlbuilder

Build # 611

Build Type

push

travis-ci

Committed by meling

Commit Message

refactored database.CreateCourse() to take course creator (user)

This change makes it explicit who is the course creator by
checking that the user is admin and should be allowed to create
the course. Further, the user is then enrolled in the course
as teacher.

This change impacted a lot of tests, but almost no business logic.
It basically only changes web/courses.go by moving the enrollment
logic into the database.CreateCourse() method, since this should
actually be done in one transaction, so that if the user couldn't
be enrolled as teacher, the course won't created either.
Currently, the implementation does not support transactions, but
it should be easy to do with GORM at a later time, if necessary.

All the other changes are mostly related to adapting to the new
semantics of CreateCourse(), but there are also some simplifications
to some of the tests, which should be a starting point for test
complexity reduction...

Run Details

1118 of 2541 relevant lines covered (44.0%)

24.6 hits per line