atlassian / smith

61%

master: 18%

LAST BUILD ON BRANCH no-locks

branch: no-locks

CHANGE BRANCH

x

Reset

• no-locks
• 1.9
• adoption
• annotations
• apply-labels
• apps-deployment
• auto-coverage
• await
• bazel
• bundle-inf
• cache
• cache-mutation-detector
• cleanup
• client-go-master
• clone-resource
• config-from-env
• configurable-namespace
• consistent-imports
• controller
• coverage-on-master
• crd
• crd-ensure
• cross-object-references
• cross-references
• ctx
• decouple-deep-copy
• deduplicate-work
• deep-copy-gen
• deep-copy-in-store
• deep-copy-template
• delete-on-update
• dep
• dependency-graph-support
• error-handling
• extract-assertion
• extract-controller-creation
• extract-spec-check
• finalizers
• fix-crd-add-watch
• fix-nil-pointer-deref
• fix-unknown-status
• fix-update
• flags
• generate-client
• generic-sort
• ignored-fields-cleanup
• inf
• informer-store
• is-same
• jsonpath-ready-state
• jsonpath-references
• list-watch
• master
• namespace-per-it
• new-stuff
• no-glide
• notify-on-delete
• output-annotations
• ready-checker
• ready-deployment
• rebuild-on-tpr-change
• refactor-ensure-crd
• refactor-informers
• refactor-its
• refactor-scheme
• refactor-stores
• refactor-worker
• reference-based-owner
• references
• refs
• remove-hacks
• remove-informer
• remove-redundant-index
• rename-to-bundle
• resources-per-bundle
• rest-mapper
• restructure-types
• sc
• sc-example
• sc-example-docs
• sc-test
• sc-test2
• service-catalog
• service-nodeport-cleanup
• servicecatalog-example
• set-controller
• simplify-conditions
• simplify-multi
• simplify-return-values
• spec-runtime-object
• spec-with-defaults
• staged-start-stop
• support-pod-preset
• support-slices
• test-config
• tombstones
• tpr-annotations
• tpr-update
• tpr-watch-refactor
• travis
• tweak-client
• unit-tests
• update
• update-client-go
• update-dependencies
• use-default-converter
• use-store-in-worker
• wait-group

Build # 234

Build Type

push

travis-ci

Committed by ash2k

Commit Message

Rework processor-worker interaction

1. Interrupt backoff sleep if bundle needs to be rebuilt
2. Use channels instead of locks
3. Worker does not depend on processor directly
4. Fix datarace on waitgroup

==================
WARNING: DATA RACE
Write at 0x00c4202dbc54 by goroutine 75:
  internal/race.Write()
      /usr/local/Cellar/go/1.8/libexec/src/internal/race/race.go:41 +0x38
  sync.(*WaitGroup).Wait()
      /usr/local/Cellar/go/1.8/libexec/src/sync/waitgroup.go:129 +0x14b
  github.com/atlassian/smith/pkg/processor.(*BundleProcessor).Join()
      /Users/ash2k/gopath/src/github.com/atlassian/smith/pkg/processor/processor.go:56 +0x3e
  github.com/atlassian/smith/pkg/app.(*App).Run()
      /Users/ash2k/gopath/src/github.com/atlassian/smith/pkg/app/app.go:107 +0xe4d
  github.com/atlassian/smith/integration_tests.TestTprAttribute.func2()
      /Users/ash2k/gopath/src/github.com/atlassian/smith/integration_tests/tpr_attribute_test.go:99 +0xc2

Previous read at 0x00c4202dbc54 by goroutine 110:
  internal/race.Read()
      /usr/local/Cellar/go/1.8/libexec/src/internal/race/race.go:37 +0x38
  sync.(*WaitGroup).Add()
      /usr/local/Cellar/go/1.8/libexec/src/sync/waitgroup.go:71 +0x26b
  github.com/atlassian/smith/pkg/processor.(*BundleProcessor).Rebuild()
      /Users/ash2k/gopath/src/github.com/atlassian/smith/pkg/processor/processor.go:76 +0x3e0
  github.com/atlassian/smith/pkg/app.(*resourceEventHandler).rebuildByName()
      /Users/ash2k/gopath/src/github.com/atlassian/smith/pkg/app/resource_event_handler.go:52 +0x4b3
  github.com/atlassian/smith/pkg/app.(*resourceEventHandler).OnUpdate()
      /Users/ash2k/gopath/src/github.com/atlassian/smith/pkg/app/resource_event_handler.go:33 +0x16f
  github.com/atlassian/smith/vendor/k8s.io/client-go/tools/cache.(*processorListener).run()
      /Users/ash2k/gopath/src/github.com/atlassian/smith/vendor/k8s.io/client-go/tools/cache/shared_informer.go:545 +0x353

Goroutine 75 (running) created at:
  github.com/atlas... (continued)

Run Details

102 of 168 relevant lines covered (60.71%)

35.55 hits per line