aragon / aragonOS

97%

dev: 82%

LAST BUILD ON BRANCH scripts

branch: scripts

CHANGE BRANCH

x

Reset

• scripts
• 3.1.10
• 4.0.1
• 4.0.2
• 5.0.0-beta.1
• IAragonAppFeesCashier_payable
• ITransactionFeesOracle_pay_endpoint
• accountingapp
• acl-add-initialization-test
• acl-add-lifecycle-docs
• acl-log-set-params
• acl-nonce-hash
• acl-optimize-check-oracle
• acl-oracle-how-param
• acl-oracle-try
• acl-radspec
• acl-remove-permission-manager
• acl-remove-sender-param
• acl-requires
• acl-revert-on-saving-empty-params
• acl-simpler-xor
• acl_enhancements
• acl_enhancements_rename
• add-auth-isinitialized
• add-bytecode-check
• add-evmscriptrunner-result-log
• add-migration
• add-migrations-to-publish
• add-petrifiable
• add-petrifiable-tests
• add_dao_factory_tests
• add_disputable_app_example_registry
• add_disputable_base_app
• add_disputable_base_app_transaction_fees_integration
• add_repo_url
• agreement-interface-fix
• agreements_non_payable
• alpha_upgrade_solidity_5
• apm
• apm-deploy-use-daofactory-deployment
• apm-rinkeby-deploy
• app-proxy-check-code-is-contract
• app-proxy-kernel-int
• application_kill_switch
• aragon-app-inheritance-doc
• aragon-node
• aragon_app_interface
• aragonos-rename
• arbitrition_fees
• audit-review-freeze
• authP-modifier
• avoid_calling_close_action_innecessary
• bye-weth
• check-contract
• clean-evmscriptregistryfactory
• clean-package
• clean_up_exports
• conversion-helpers
• conversion-helpers-check-bytes-length
• cosmetic-cleanup
• coverage-improvements
• create-permissions-auth
• dao-factory-remove-ternary
• daofactory-clarify-permissions
• daofactory-deploy-partial
• daofactory_script_registry
• deploy-apm-open
• deploy-daofactory-with-evmscriptregfactory
• deploy-forensics
• deploy-script-storage-shadowing
• deploy_apm_truffle_5_compat
• depositable-check
• depositable-optimize
• depositable_kernel_test
• dev
• dev-old
• devnet_network_id
• disputable_test_roles
• docker-deploy
• docs
• emit-appid-newappproxy
• enable-optimization
• enforce-executor-types
• ensfactory-use-ens-constants
• evmscript-bytes
• evmscript-min-return
• evmscript-registry-enable
• evmscript-registry-events
• evmscript-transparent-revert
• evmscriptexecutor-type
• evmscriptreg-storage
• evmscriptrunner-check-return-length
• evmscriptrunner-expose-getregistry
• export-truffle
• expose-apm-namehash
• extend_forwarder_interface
• extend_forwarder_interface_update
• factory-support
• fix-acl-visibility
• fix-apm-version-permission
• fix-arr-empty-array
• fix-compile-warnings
• fix-coverage-proxy-recover
• fix-default-state-visibility
• fix-empty-bytes-aragonapp
• fix-import
• fix-interface-bytes
• fix-lint
• fix-newappinstance
• fix-readme-links
• fix-role-bytes
• fix-static-typing
• fix-tests
• fix-time
• fix-timehelpers-tests
• fix-truffle-config
• fix-visibility
• fix_acl_inline_doc
• fix_apm_script
• fix_assert_revert_helper
• fix_coverage
• fix_keccak_constants_test
• fix_minime_test
• forwarder-fee
• gas_issue
• gas_issue_2
• hardcode_constants
• initialization
• inject_web3
• ints
• is-contract-library
• isInit_modifier
• iscontract
• iscontract-clarification
• issue208
• issue209
• issue217
• issue219
• issue251
• issue275
• issue275-vault-recoverable
• issue277
• issue282
• kernel-app-proxy
• kernel-emit-setapp
• kernel-namespace-mapping
• kernel-registry-radspec
• kernel-tests-new-instance
• kernel-upgrade-integrity
• kill_switch_poc
• lib-dir
• mainnet-deploy-apm
• make-string-concat-obvious
• make_agreement_new_action_payable
• master
• math-optimizations
• meta-txs
• meta-txs-service
• min-return
• minime-token-remove-constant
• minor-packing-stuff
• minor_v4_3_0
• mit-license
• model_address_utils
• modular-deployment-scripts
• move-safeerc20-tests
• new-docs
• new-instance-init
• new-version-notice
• new_acl_syntax_sugar
• next
• no_acl_params
• npm-prune
• npx
• optimize-proxies
• optimize-redundant-checks
• optimize_safemath_mul_64_8
• organize-gitignore
• organize_mocks_and_test_files
• param-acl
• petrify_permission
• pin-ganache-6.2.3
• pin-truffle
• pin_solidity_coverage
• pinned-fallback
• probot-bots
• proxy-revert-reasons
• prune-constants
• public_any_entity
• reentrancy-guard
• refactor_tests_events_assertions
• remove-app-readme
• remove-delegate-executors
• remove-docs
• remove-kernelintegrity
• remove-migrations
• remove-protect-state
• remove-tokens
• remove_acl_changes_from_v5
• remove_apm
• remove_warnings
• repo-storage
• restart-ganache-each-test
• revert-reasons
• rinkeby_multiple_addresses
• rpc-tests-truffle-gas
• safe-erc20
• safe-erc20-check-returndatasize
• safe_total_supply
• safemath64
• safemath8
• scripts-exit
• scripts-suggestions
• signed-exec
• simplify_relative_path
• solc-0.4.24
• static-safe-erc20
• template_docker_tests
• templates
• test-fix-parameterization
• test-remove-only
• test-update-constants
• testing-improvements
• truffle-config
• uint64_helper
• unstructured_storage
• unstructured_storage_library
• untagged-6ffe885983d3b34d3408
• update-dependencies
• update-docs
• update-license
• update_license
• upgrade-ganache
• upgrade-ganache-6.2.5
• upgrade-ganache-6.4.2
• upgrade-privatekey-provider
• upgrade-solidity-coverage
• upgrade-solium
• use-ands-in-scripts
• v3.0.0
• v3.0.1
• v3.0.2
• v3.0.3
• v3.0.4
• v3.0.5
• v3.0.6
• v3.0.8
• v3.1.1
• v3.1.11
• v3.1.2
• v3.1.3
• v3.1.4
• v3.1.6
• v3.1.8
• v4.0.0
• v4.0.0-alpha.1
• v4.0.0-alpha.2
• v4.0.0-beta.1
• v4.0.0-beta.2
• v4.0.0-rc.1
• v4.0.2
• v4.1.0
• v4.1.0-rc.1
• v4.2.0
• v4.2.1
• v4.3.0
• v4.4.0
• v5.0.0-beta.0
• v5.0.0-beta.3
• v5.0.0-beta.4
• v5.0.0-beta.5
• v5.0.0-beta.6
• v5.0.0-beta.7
• v6_alpha
• vaultrecoverable-emit-event
• wrap-solidity-tests

Build # 813

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Scripts suggestions (#199)

* ACL: remove unnecessary import

* Use _ prefix for arguments

* Comment clarifications or fixes

* ACL: use same interface for hasPermissions as Kernel

* ACL: clarify comment for when permisison creation is allowed

* Use _ROLE suffix for all role definitions

* Comment: remove script ID from EVMScript types since they can now be dynamic

* Always put visibility modifier ahead of state modifier

* AppProxyBase: remove unused event

* Rename IProxy to IAppProxy to reflect file name

* Use ^0.4.18 pragma for interfaces

* DeployDelegateScript: simplify caching

* EVMScriptRegistry: use constructor to add empty record

* IKernel: Add name to indexed event params for SetApp

* Small fixes

* CallsScript: fix dev comment

* EVMScriptRegistry: always inherit from interfaces first

* Fix compiler errors

* Add initialization to EVMScriptRegistry and make AppStorage more explicit

Run Details

97 of 112 branches covered (86.61%)

Branch coverage included in aggregate %.

22 of 22 new or added lines in 7 files covered. (100.0%)

331 of 331 relevant lines covered (100.0%)

155.33 hits per line