appfolio / farcy

96%

master: 92%

LAST BUILD ON BRANCH ignore_hidden

branch: ignore_hidden

CHANGE BRANCH

x

Reset

• ignore_hidden
• IncludeFileHierarchyInTmpDir
• SymlinkRubocopConfig
• UnprocessableEntity
• add-config-section
• add-copyright
• balloob-dockerfile-airbnb
• comment_group_threshold
• config
• config_dir
• docker-docs-upgrade
• eslint-error-handling
• event_error
• flake-8-fixes
• flake8-tests
• github3py
• greatjob
• handle_pr
• helpercoverage
• ignore_pr
• initcoverage
• logging
• loop_errors
• master
• merge_similar
• network
• no_handler_cache
• py32
• pypi_optional
• readme-add-jsxhint
• shortargs
• simple
• tests
• threshold
• tmpdir
• travis
• travis-cache
• travis-fast-finish
• travis_3.5
• update_status
• v0.1
• v0.1.1
• v0.2.0
• v1.0
• v1.0.rc1
• v1.0.rc2
• v1.1
• v1.2.2
• v1.2.3
• v1.3.0
• version-11

Build # 316

Build Type

push

travis-ci

Committed by bboe

Commit Message

Do not count "hidden" comments against the comment limit.

Hidden comments are comments that github considers to be on "outdated
diffs". In the event that farcy has reached its self-imposed comment limit, it
would no longer make new comments making it impossible from the pull request
view to receive feedback on new issues. Because those comments are hidden on
page load, ignoring them in the comment count _should_ avoid the breaking the
pull request view (the reason why #35 was filed and subsequently resolved).

In the event we break pull request views again, we can use the information
about hidden comments to delete as many as needed.

Resolve #78.

Run Details

605 of 628 relevant lines covered (96.34%)

3.84 hits per line