apollostack / graphql-subscriptions

100%

master: 100%

LAST BUILD ON BRANCH glasser/sub-promises

branch: glasser/sub-promises

CHANGE BRANCH

x

Reset

• glasser/sub-promises
• designs
• helfer-patch-1
• master
• neophi-async-filter
• v0.1.1
• v0.1.2
• v0.1.3
• v0.1.4
• v0.1.5
• v0.2.0
• v0.2.1
• v0.2.2
• v0.2.3

Build # 60

Build Type

push

travis-ci

Committed by glasser

Commit Message

Wait on correct Promise in subscription

I'm not a Promise expert, but the previous code at least read like it was
possible for the Promise returned by subscribe to resolve once all the
this.pubsub.subscribe Promises resolved but before all of the "push onto
this.subscriptions" Promises resolved.  If unsubscribe was called too quickly,
you could in theory end up calling one of those "push" functions after the
`delete this.subscriptions[subId]` line and crashing.

In practice the old code does appear to work but this code more accurately shows
the intentions.

Run Details

96 of 96 relevant lines covered (100.0%)

15.38 hits per line