apcera / gnatsd

80%

master: 76%

LAST BUILD ON BRANCH fix-unsub-race

branch: fix-unsub-race

CHANGE BRANCH

x

Reset

• fix-unsub-race
• 1.4
• add_godeps_support
• add_net_to_configs
• add_net_to_more_config_files
• add_net_to_more_tests
• bcrypt
• debug_travis_issue
• discovery
• fix-coveralls-report
• fix-races
• fix-split-msg
• fix_test
• https_monitor
• increase_tls_timeout
• issue-136
• issue-138
• master
• monitoring
• ready_for_travis_gce
• release_server_lock_on_port_parsing_failure
• temporarily-reverted-INFO-message-format
• tls
• tls_add_cipher
• tls_issue
• tls_strict_route
• tls_updates
• v0.6.0
• v0.7.0
• v0.7.2

Fix unsubscribe race + adjustments to some tests.

Got a race condition. Created a new test that would easily produce this race:

==================
WARNING: DATA RACE
Write by goroutine 52:
  github.com/nats-io/gnatsd/server.(*client).processUnsub()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/client.go:546 +0x348
  github.com/nats-io/gnatsd/server.(*client).parse()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/parser.go:326 +0x3d72
  github.com/nats-io/gnatsd/server.(*client).readLoop()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/client.go:156 +0x26b

Previous read by goroutine 57:
  github.com/nats-io/gnatsd/server.(*client).deliverMsg()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/client.go:584 +0xec
  github.com/nats-io/gnatsd/server.(*client).processMsg()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/client.go:791 +0x2b24
  github.com/nats-io/gnatsd/server.(*client).parse()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/parser.go:219 +0x3128
  github.com/nats-io/gnatsd/server.(*client).readLoop()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/client.go:156 +0x26b

Goroutine 52 (running) created at:
  github.com/nats-io/gnatsd/server.(*client).initClient()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/client.go:133 +0xb74
  github.com/nats-io/gnatsd/server.(*Server).createClient()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/server.go:414 +0x2dc
  github.com/nats-io/gnatsd/server.(*Server).AcceptLoop()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/server.go:336 +0x11bd
  github.com/nats-io/gnatsd/server.(*Server).Start()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/server.go:218 +0x28e

Goroutine 57 (running) created at:
  github.com/nats-io/gnatsd/server.(*client).initClient()
      /Users/ivan/dev/go/src/github.com/nats-io/gnatsd/server/client.go:133 +0xb74
  github.c... (continued)