anorgan / QuTee
57%

Repo Added 05 May 2014 09:38PM UTC

Files 9

Badge

Embed ▾

LAST BUILD ON BRANCH master
branch: master

CHANGE BRANCH
x

Reset

master

v0.9.1

v0.9.2

v0.9.3

pending completion

Build # 55

Build Type

Pull #21

travis-ci

Committed by

web-flow

Commit Message

Long running process race condition

Trying to recreate a task after a long running process ends in a race condition in the pdo module (actually any db calls through the pdo module for this task)

When you pass the pdo object to the `_testConnection(\PDO $pdo)` function its actually receives the value of the reference to the pdo object.
Setting it to null in the catch statement doesn't set `$this->_pdo = null;` only the local `$pdo` variable
You need to pass it a reference to the reference

To test firstly see what you're mysql timeouts are set to using
```
SHOW VARIABLES LIKE 'wait_timeout';
SHOW VARIABLES LIKE 'interactive_timeout';
```
put a sleep in your test task longer than the largest one (its in seconds)
see a race condition as `$this->_testConnection()` calls `$this->_getPdo();` while `$this->_pdo` stays not null.... and repeat

At least this is so in php v5.6.32
mh

Pull Request Pull Request #21: Long running process race condition

Run Details

150 of 265 relevant lines covered (56.6%)

3.47 hits per line

Relevant lines Covered

265 RELEVANT LINES 150 COVERED LINES

3.47 HITS PER LINE

Source Files on master

Detailed source file information is not available for this build.

Recent builds

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
55	master	Long running process race condition Trying to recreate a task after a long running process ends in a race condition in the pdo module (actually any db calls through the pdo module for this task) When you pass the pdo object to the `_testConnec...	Pull #21	04 Nov 2017 03:47PM UTC	web-flow	travis-ci	pending completion
54	master	Provide method name to TaskInterface allows for the task object to take the form ``` class myTask implements TaskInterface { protected $_data; public function run($methodName='') { if(method_exists($this, $methodName)){ ...	Pull #20	16 Feb 2017 10:42AM UTC	web-flow	travis-ci	pending completion
52	master	Stop race condition poling Persistor (#19)	push	15 Feb 2017 01:58PM UTC	anorgan	travis-ci	pending completion
51	master	Stop race condition poling Persistor	Pull #19	15 Feb 2017 01:47PM UTC	web-flow	travis-ci	pending completion
49	master	When testing for task uniqueness, don't take into account taken tasks	push	04 Dec 2015 10:46AM UTC	anorgan	travis-ci	pending completion
47	master	Up the version of symfony event dispatcher	push	03 Dec 2015 10:51AM UTC	anorgan	travis-ci	pending completion
46	master	Coverals	push	07 Apr 2015 11:03PM UTC	Marin Crnković	travis-ci	pending completion
45	master	Coverals	push	07 Apr 2015 10:45PM UTC	Marin Crnković	travis-ci	pending completion

See All Builds (11)

anorgan / QuTee
57%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: master

CHANGE BRANCH
x

Reset

master

v0.9.1

v0.9.2

v0.9.3

CHANGE BRANCH
x

Relevant lines Covered

Source Files on master

Recent builds

anorgan / QuTee 57%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master branch: master CHANGE BRANCH x Reset master v0.9.1 v0.9.2 v0.9.3

CHANGE BRANCH x

Relevant lines Covered

Source Files on master

Recent builds

anorgan / QuTee
57%

README BADGES
x

LAST BUILD ON BRANCH master
branch: master

CHANGE BRANCH
x

Reset

master

v0.9.1

v0.9.2

v0.9.3

CHANGE BRANCH
x