amazon-aurora / babelfish_extensions
75%
main: 77%

LAST BUILD BRANCH: BABEL-6402-6x
DEFAULT BRANCH: main
Repo Added
Token 5wOy9bgXUJ1VvG8OxaW7XpYkvIyq7IhYY regen
Build 6091 Last
Files 122
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH groupingunion4X
branch: groupingunion4X
CHANGE BRANCH
x
Sync Branches

coverage: 75.435%. First build
15711277723

push

github

KushaalShroff 
Do not coerce float/real datatypes in pre_transform_hook (#3840)

ISSUE: When lower precedence datatypes (to real/float) are grouped on one side and then union'ed with real or float datatypes then "not equal" values were being grouped together. This was found during real and float testing when "not equal" real values were being grouped together and the root cause helped us extrapolate issues with numeric/int/smallint/tinyint as well.
NOTE: In Fact, for Numeric unioned REAL/FLOAT we were also observing crashes due to the early coercion and precision mismatch during aggregation.

Root Cause: The coerce_to_target_type during pre_transform_hook is applying the implicit cast too early -- even before grouping.
When the REAL(or other lower precedence type) values are cast to FLOAT(Or Higher precedence types) during the coercion, there might be precision differences. The cast types in PG from lower to high precedence types are defined as "IMPLICIT" which gives the freedom to optimizer to evaluate on the go. In case of "ASSIGNED" cast types optimizer would have grouped first and then applied cast -- it prevents the automatic type conversion during the grouping phase -- which would be the expected outcome.

Solution: Prevent the cast from happening too early for REAL/FLOAT, thus, maintaining the original precision for grouping and only cast for the final result.

Issues Resolved:
BABEL-5798

Signed-off-by: kushaal shroff <kushaal@amazon.com>

3 of 3 new or added lines in 1 file covered. (100.0%)

48641 of 64481 relevant lines covered (75.43%)

320447.06 hits per line

Relevant lines Covered
64481 RELEVANT LINES 48641 COVERED LINES
320447.06 HITS PER LINE
Source Files on groupingunion4X

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
15711277723 groupingunion4X Do not coerce float/real datatypes in pre_transform_hook (#3840) ISSUE: When lower precedence datatypes (to real/float) are grouped on one side and then union'ed with real or float datatypes then "not equal" values were being grouped together. Th... push KushaalShroff github
75.43
See All Builds (6059)

Badge your Repo: babelfish_extensions

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh