alphagov / notifications-api

91%

master: 93%

LAST BUILD ON BRANCH store-notification-personalisation

branch: store-notification-personalisation

CHANGE BRANCH

x

Reset

• store-notification-personalisation
• HEAD
• accept-invite-tests
• active-service
• add-body-to-v2-response
• add-cancel-job-endpoint
• add-coveralls
• add-date-filter-to-get-services
• add-default-exception-handler
• add-dvla-provider
• add-key-name-notifications
• add-log-to-ses-callback
• add-notification-type
• add-separate-schema-for-providers
• add-specific-error-for-auth
• add-templates-process_type
• add-v2-template-get-all
• add-v2-template-get-id
• add-v2-template-preview
• allow-created-notifications-to-be-updated
• api-key-type
• api_user-cleanup
• better-auth-error-message
• better-expired-error
• bump-requirements-faster-csv
• bump-utils-fix-email-bullets
• bumped-version
• bumped-version-of-utils
• caching-with-redis
• call-update-job-task-once-files-sent-to-dvla
• case-insensitive-auth-header
• celery-3-1-25
• cf-deploy
• change-email-confirmation
• change-email-template
• change-timeout-to-match-api
• change-v2-error-resp
• check-notification_schema
• cloudfoundry
• cloudfront-fix
• codedeploy_autoscaling
• concurrency
• conftest-cleanups
• create-dvla-file
• create-task-to-send-files-to-dvla
• db-queues-changed
• delete-csv-file-after-7-days
• deploy_db_migrations
• detached
• do-not-write-test-data-to-the-history-table
• docker_build_http_proxy
• dont-deactivate-twice
• dont-send-message-twice
• drop-model-before-column
• drop-status-column
• email-breathing-room
• email-exception
• email-regex
• ensure-that-files-are-utf-8
• error-handling
• exc-handl
• extend-scheduling-to-96-hours
• feat-add-endpoint-for-service-monthly-usage-stats
• feat-add-logging-for-auth-errors
• feat-add-who-updated-providers
• feat-install-all-wheels-offline
• feat-switch-providers-on-slow-delivery
• fix-billable-units-query
• fix-build
• fix-cancelled-jobs-migrations
• fix-client-reference
• fix-code-deploy-artifact
• fix-code-deploy-artifact-duplication
• fix-conflicting-migration-versions
• fix-dashboard-stats
• fix-downgrade
• fix-failed-login-count
• fix-fake-numbers
• fix-job-status
• fix-missing-template-id
• fix-mocks
• fix-redis-cache
• fix-remove-old-wheelhouse-contents
• fix-simulate-logic
• fix-sms-sender
• fix-status-type
• fix-template-type-bug
• fix-test-key-external-number-issue
• fix-update-boto3
• fix-v2-post-notification
• fix-v2-post-response-body
• fix-v2-uri
• fix_api_host_name
• fixing-the-build
• format-statsd
• get-service-notifications-not-include-jobs
• gsm
• handle-errors-in-file-processing
• handle-sms-client-exceptions
• ignore-additional-personalisation
• implement-v2-send-email
• increase-page-size
• index-slow-queries
• invite-expiry-msg
• jenkins_coveralls
• job-status-filter
• junit-test-results
• letter-templates
• letter-templates-db
• letters-flag
• live
• log-notification-id-on-provider-call
• logging-around-jobs-and-tasks
• logging-service-ids
• loosen-get-notification-key-restriction
• make-password_changed_at-not-null
• master
• mmg-update-status
• monthly-billable-units
• more-breaking-utils-changes
• move-scheduler-tasks
• no-jobs-on-api-get
• node-queue-processor
• notification-created-status
• notifications-body-bug-fix
• notifications-get-api-key-filter
• only-send-if-successful-jobs
• optionally-get-test-notifications
• origin/master
• origin/pr/643/merge
• paas_awslogs
• paas_redis_config
• paginate-dashboard
• pc-nab-numerous-notifications
• pc-newly-nab-notifications
• pc-newly-nab-notifications-2
• persist-letters
• petes-readme-update
• post-sms-v2
• priority-by-template
• provide-simulated-numbers-live-keys
• provider-audit
• quis-patch-1
• rationalise-config
• rationalise-queues
• readme-cleanup
• receive-sms-messages
• record-user-agent
• refactor-api-key
• refactor-confirm-new-email
• refactor-for-code-reuse
• refactor-for-reuse-fix
• refactor-notify-user-endpoints
• refactor-send-tasks-into-shared-code
• refactor-send_notifications
• refactor-send_user_email_verification
• remove-default-key-type
• remove-provider_statistics
• remove-send-notification-tests
• remove-test-keys-from-admin-app
• remove-test-task
• remove-timezone-accuracy-usage
• remove-travis-image
• remove-unused-code-lines
• remove_jenkinsfiles
• renamed-dvla-job-bucket
• replaced-subjects
• reply-to-address
• request-id-logging
• research-mode-csv-file-queues
• reset-2fa
• revert-831-feat-install-all-wheels-offline
• revert-857-tmp-add-logging-for-report-download
• run-research-mode-queue-in-own-worker
• scheduled-delivery-of-jobs-cleanup
• secure-endpoints
• send-named-file
• service-whitelist
• session-id
• sort-jobs-by-processed-time-first
• staging
• staging-live-visibility-update
• stats-toggle-test-key
• statsd-time-taken-to-be-delivered
• stringify-cost-attr-on-v2-get-notification
• stronger-2fa-security
• subject-placeholder
• switch-providers-on-error
• switch-providers-on-failure
• switch-redis-on
• switch-to-cloudfront
• team-key-sends-to-whitelist
• test-branch
• test-message-filtering
• test-refactor
• tmp-add-logging-for-report-download
• update-api-client
• update-readme
• update-requirements
• update-requirements-1
• update-return-all-notifications-schema
• update-user-profile-endpoints
• upgrade-python-client
• use-correct-directory
• use-new-queues
• use-notify-queue-to-deliver
• use-notify-queue-to-deliver-internal-emails
• use-redis-and-statsd-from-utils
• use-wheels-to-speed-as-deployment
• use_http_proxy_for_docker
• use_patched_boto
• utils-bump
• utils-bump-email-newline
• v2-get-notification-by-reference
• v2-post-notification
• verify-email-shouldnt-login
• whitepace-in-personalisation
• write-to-postgres-not-sqs
• xpass

Build # 1934

Build Type

push

travis-ci

Committed by ashimali

Commit Message

Template and personalisation content is now merged and returned with
notifications, when retrieved by notification id, or service id (i.e.
all notifications for service).

There is a new element returned at top level of notification json called
body, which is the template content merged with personalisation. This
is consistent with api to endpoint to create notification which returns
what was sent as 'body' in json response.

Merging of template with personalisation is done in the
NotificationStatusSchema.

Personalisation data in encrypted before storing in db.

Run Details

2412 of 2646 relevant lines covered (91.16%)

0.91 hits per line