alphagov / digitalmarketplace-brief-responses-frontend

93%

master: 97%

LAST BUILD ON BRANCH remove-feature-flag-code

branch: remove-feature-flag-code

CHANGE BRANCH

x

Reset

• remove-feature-flag-code
• 104-move-to-supervisor-4-using-python-3
• 114-500-error-question-not-found
• 18-flask-1x-upgrade
• 20-2-add-govuk-frontend-jinja-and-digitalmarketplace-govuk-frontend-to-brief-responses-frontend
• 22-2-update-breadcrumbs-to-use-govuk-frontend-component-in-brief-responses-frontend
• 22-use-framework-family-in-apps
• 24-2-update-page-headings-to-govuk-frontend-style-in-brief-responses-frontend
• 295-add-custom-python-metrics-to-brief-responses-frontend
• 295-add-custom-python-metrics-to-brief-responses-frontend-blueprint
• 295-mandrill-email-crash-2018-05-10-1824
• 299-flash-messages-briefs-responses-frontend-app
• 30-3-update-grids-to-use-govuk-frontend-styles-in-brief-responses-frontend
• 32-2-update-buttons-to-use-govuk-frontend-component-in-brief-responses-frontend
• 322-move-metrics-to-metrics-and-expose
• 33-3-use-govuk-link-govuk-list-and-govuk-body-styles-in-brief-responses-frontend
• 336-custom-dimension-user-role
• 372-your-session-has-expired-instead-of-ugly-csrf-message
• 400-inadequate-session-timeout
• 400-inadequate-session-timeout-fix
• 43-create-a-base-page-for-the-apps
• 476-brief-responses-templates-have-hardcoded-urls
• 65-update-flask-login
• 85-allow-suppliers-edit-submitted-application
• LB_change_brief_submission_copy
• NOTICKET-normalize-metrics-location
• NOTICKET-update-requirements
• al/remove-user-research
• al/replace-page-headings
• al/titles-content
• al/vertical-spacing
• application-status
• async-rq-experiment
• awards
• cancelled
• cleanup-flash-messages
• cpw-add-new-specialist-roles-for-dos3
• cpw-pull-in-v19.0.0-of-apiclient
• create-brief-responses-app
• deploy-make-freeze-and-file-format-checking
• deployed-to-preview
• deployed-to-production
• deployed-to-staging
• dh-106-update-header-to-make-it-easier-to-find-support-guidance-and-where-to-log-in
• dh-120
• dh-add-external-links-tracking
• dh-add-in-support-page
• draft-applications-on-supplier-dashboard
• edit-links-hidden-text
• explicitly-remove-basic-auth-for-metrics
• fix-dependency-warnings
• fix-draft-application-ordering
• import-opportunities-dashboard
• import-send-email-from-correct-place
• jk-add-pyup
• jk-bump-requirements
• jk-pin-flask
• jk-update-pyup
• ks-avoid-not-implemented-routes
• ks-bump-content-loader
• ks-cross-domain-tracking
• ks-dos4-content
• ks-draft-application-submit
• ks-draft-brief-response-doesnt-see-success
• ks-error-handling-fix
• ks-fe-toolkit-error-pages
• ks-pyup-sunday
• ks-replyto-address-hint-text
• ks-upgrade-jqueyr
• ks-use-api-stubs
• ldeb-106-wtforms-dmfields
• ldeb-84-docker-base
• ldeb-add-govuk-frontend-js-init
• ldeb-add-python-badge
• ldeb-add-standard
• ldeb-banner-css-tweaks
• ldeb-bump-docker-base
• ldeb-bump-urllib3
• ldeb-change-search-api-port
• ldeb-fix-166
• ldeb-fix-readme
• ldeb-fix-start-brief-response-page
• ldeb-pin-itsdangerous
• ldeb-python-venv
• ldeb-pyup-requirements-test-update-false
• ldeb-refactor-makefile
• ldeb-remove-feature-flags-from-readme
• ldeb-remove-manual-escape
• ldeb-remove-report-a-problem
• ldeb-remove-secondary-action-link
• ldeb-remove-yarn
• ldeb-update-dm-libs
• ldeb-update-dmutils-so-we-can-log-csrf-errors
• ldeb-update-docker-base-image
• ldeb-update-frameworks
• ldeb-update-gulp
• ldeb-update-node
• ldeb-upgrade-node-8-to-10
• ldeb-use-digitalmarketplace-govuk-frontend-error-pages
• ldeb-use-notify
• master
• millisecond-log-times
• privacy-notice
• privacy-notice-base
• pytest-3x
• pyup-config
• pyup-scheduled-update-2019-02-25
• pyup-scheduled-update-2019-03-04
• pyup-scheduled-update-2019-03-11
• pyup-scheduled-update-2019-03-18
• pyup-scheduled-update-2019-03-25
• pyup-scheduled-update-2019-04-01
• pyup-scheduled-update-2019-04-22
• pyup-scheduled-update-2019-04-29
• pyup-scheduled-update-2019-05-06
• pyup-scheduled-update-2019-05-13
• pyup-scheduled-update-2019-05-20
• pyup-scheduled-update-2019-06-02
• pyup-scheduled-update-2019-06-09
• pyup-scheduled-update-2019-06-16
• pyup-scheduled-update-2019-07-28
• pyup-scheduled-update-2019-08-04
• pyup-scheduled-update-2019-08-11
• pyup-scheduled-update-2019-08-18
• redirect-supplier-to-public-brief-page
• refactor-tests
• release-1
• release-10
• release-100
• release-102
• release-104
• release-105
• release-106
• release-107
• release-109
• release-11
• release-110
• release-111
• release-112
• release-113
• release-114
• release-115
• release-117
• release-118
• release-119
• release-12
• release-120
• release-121
• release-122
• release-123
• release-124
• release-125
• release-126
• release-127
• release-128
• release-13
• release-130
• release-131
• release-132
• release-134
• release-136
• release-139
• release-14
• release-140
• release-141
• release-142
• release-143
• release-144
• release-145
• release-146
• release-147
• release-148
• release-149
• release-15
• release-150
• release-151
• release-153
• release-154
• release-155
• release-156
• release-157
• release-158
• release-159
• release-16
• release-160
• release-161
• release-162
• release-163
• release-164
• release-165
• release-166
• release-167
• release-168
• release-17
• release-170
• release-171
• release-172
• release-173
• release-174
• release-176
• release-18
• release-19
• release-2
• release-20
• release-21
• release-22
• release-23
• release-24
• release-25
• release-26
• release-27
• release-28
• release-29
• release-3
• release-30
• release-31
• release-32
• release-33
• release-34
• release-35
• release-36
• release-37
• release-38
• release-39
• release-4
• release-40
• release-41
• release-42
• release-43
• release-44
• release-45
• release-46
• release-47
• release-48
• release-49
• release-5
• release-50
• release-51
• release-52
• release-53
• release-54
• release-55
• release-56
• release-57
• release-58
• release-59
• release-6
• release-60
• release-61
• release-62
• release-63
• release-64
• release-65
• release-66
• release-67
• release-68
• release-69
• release-7
• release-70
• release-71
• release-72
• release-73
• release-74
• release-75
• release-76
• release-77
• release-78
• release-79
• release-8
• release-80
• release-81
• release-82
• release-83
• release-84
• release-85
• release-86
• release-87
• release-88
• release-89
• release-9
• release-90
• release-91
• release-92
• release-93
• release-94
• release-96
• release-97
• release-98
• release-99
• remove-IE6-styles
• remove-bower
• remove-css
• remove-templates
• revert-53-shw-framework-framework-to-framework-family
• ris-apiclient-17-2-0
• ris-apiclient-19-7-0
• ris-apiclient-zipkin-bump
• ris-bump-utils-docker-base
• ris-cookie-warning-correct-conf-name
• ris-default-nix-glibc-locales
• ris-default-nix-make-path-tostring
• ris-docker-base-4-5-4
• ris-docker-base-7.1.0
• ris-docker-base-7.2.0
• ris-enable-cookie-warning
• ris-fe-tk-34.2.0
• ris-fe-tk-34.3.0
• ris-flask-0-12
• ris-nix-node-8
• ris-nix-short-name
• ris-notify-redirect-example
• ris-notify-redirect-umt
• ris-opp-dashboard-no-data
• ris-python-slim-buster
• ris-request-id
• ris-submit-br-after-closed
• ris-threadsafe-content-loader
• ris-utils-36-2-1
• ris-utils-40.6.1-timed-render-template
• ris-utils-41-2-0
• ris-utils-41-2-1
• ris-utils-48-2-0
• ris-utils-48-5-0
• ris-utils-50
• shim-links
• shw-add-yarn-install-step
• shw-ask-a-question-qa
• shw-consolidate-validation-mastheads
• shw-dockerfile-3.1.1
• shw-dockerfile-absolute-paths
• shw-downgrade-gulp-include
• shw-flake8-per-file-ignores
• shw-framework-family
• shw-framework-framework-to-framework-family
• shw-hard-fail-include
• shw-remove-do-not-reply
• shw-status-endpoint-from-utils
• shw-update-nixfile
• shw-update-readme
• shw-update-setup
• shw-update-utils
• shw-update-yarn-lockfile-flags
• snyk-fix-396095fe11060ac70db26898ce9f64c8
• update-base-docker-version
• update-docker-base
• update-metrics
• upgrade-api-client
• use-user-frontend-for-auth

Build # 190

Build Type

push

travis-ci

Committed by idavidmcdonald

Commit Message

Remove code related to migration period of new supplier flow

The code removed was not tidyed up after the new supplier flow for
applying to a brief was released and given two weeks to allow all
'old style' or 'legacy' briefs to finish their `live` period.

Now we have no more 'old style' briefs that are live, we do not
need to do these additional checks as they will never be false.

Note, this is not a straight refactor - there is a very slight
change in functionality for users. If a user for a legacy style
brief had not applied for it but tried to visit the result page
for their brief response to the brief then it would 404. This
was because the start page was only applicable for new style
briefs. Now instead, we do exactly the same as a non legacy brief
which is redirect them to the start page for applying to that
brief. Because all legacy style briefs are `closed`, that page will
404 so the end result for the user will be the same. This very
small change, which would be found by URL guessing by users,
enables us to completely remove the `NEW_SUPPLIER_FLOW` feature
flag.

Run Details

315 of 339 relevant lines covered (92.92%)

0.93 hits per line