alphagov / digitalmarketplace-apiclient

99%

master: 98%

LAST BUILD ON BRANCH result-responses

branch: result-responses

CHANGE BRANCH

x

Reset

• result-responses
• 1.0.0
• 1.0.1
• 1.1.0
• 1.2.0
• 1.3.0
• 1.4.0
• 10.0.0
• 10.1.0
• 10.2.0
• 10.3.0
• 10.4.0
• 10.5.0
• 10.6.0
• 10.7.0
• 10.8.0
• 10.8.1
• 10.9.0
• 100-multiple-mappings
• 101-suppliers-should-be-able-to-select-a-category-es-for-frontend
• 11.0.0
• 11.1.0
• 11.2.0
• 11.3.0
• 11.4.0
• 12.0.0
• 12.1.0
• 12.2.0
• 13.0.0
• 13.1.0
• 138323285-rm_find_frameworks_iter__add_find_supplier_declarations
• 14.0.0
• 14.0.1
• 14.1.0
• 14.2.0
• 14.3.0
• 14.4.0
• 14.5.0
• 14.6.0
• 14.7.0
• 15.0.0
• 15.0.1
• 15.1.0
• 15.1.1
• 15.1.2
• 15.1.3
• 15.2.0
• 15.3.0
• 15.3.1
• 155-allow-super-admin-invite-new-admin-users
• 16.0.0
• 16.1.0
• 16.2.0
• 16.3.0
• 16.4.0
• 16.4.1
• 16.5.0
• 17.0.0
• 17.1.0
• 17.2.0
• 17.4.0
• 18-flask-1x-upgrade
• 18.0.0
• 18.1.0
• 19.0.0
• 19.1.0
• 19.10.0
• 19.11.0
• 19.12.0
• 19.13.0
• 19.13.1
• 19.14.0
• 19.15.0
• 19.15.1
• 19.2.0
• 19.3.0
• 19.4.0
• 19.5.0
• 19.6.0
• 19.7.0
• 19.8.0
• 19.9.0
• 19.9.1
• 19.9.2
• 19.9.3
• 2.0.0
• 2.1.0
• 2.2.0
• 2.3.0
• 2.3.1
• 20.0.0
• 20.1.0
• 20.2.0
• 208-delete-users-code-that-takes-the-user-and-strips-all-the-personal-data-out
• 21.0.0
• 21.1.0
• 21.2.0
• 21.3.0
• 21.4.1
• 3.0.0
• 3.1.0
• 3.2.0
• 3.3.0
• 3.4.0
• 3.4.1
• 3.5.0
• 3.5.1
• 3.6.0
• 3.7.0
• 3.8.0
• 4.0.0
• 4.1.0
• 495-api-client-methods-for-exportusersiter-and-exportsuppliersiter
• 5.0.0
• 5.1.0
• 5.2.0
• 6.0.0
• 6.1.0
• 6.2.0
• 6.3.0
• 6.3.1
• 6.3.2
• 6.3.3
• 6.4.0
• 6.5.0
• 6.6.0
• 6.7.0
• 7.0.0
• 7.1.0
• 7.10.0
• 7.11.0
• 7.12.0
• 7.13.0
• 7.2.0
• 7.2.1
• 7.3.0
• 7.4.0
• 7.5.0
• 7.6.0
• 7.7.0
• 7.8.0
• 7.9.0
• 70-update-framework-manager-user-download-list-to-include-additional-fields
• 8.0.0
• 8.1.0
• 8.10.0
• 8.10.1
• 8.10.2
• 8.11.0
• 8.12.0
• 8.13.0
• 8.14.0
• 8.2.0
• 8.3.0
• 8.4.0
• 8.4.1
• 8.5.0
• 8.6.0
• 8.7.0
• 8.8.0
• 8.9.0
• 9.0.0
• 9.1.0
• 9.1.1
• 9.2.0
• BUGFIX-normalize-arg-name-personal_data_removed
• NO-TICKET-specify-packages
• add-agreements-audit-events
• add-audit-ordering
• add-brief-apiclient-methods
• add-brief-audit-events
• add-brief-clarification-question-audit
• add-brief-clarification-questions
• add-brief-times
• add-create_framework-audit
• add-license
• add-published-at-for-closed-brief-stubs
• add-test-helpers
• add_countersign_agreement_route
• add_dos2_to_api_stubs
• add_name_to_update_user
• add_route_for_putting_agreements_on_hold
• add_update_brief_framework_id_audit_type
• admin_extract_buyer_and_briefs_list
• aenum
• agreement-key
• api-client-makefile
• audit-accept-framework-variation
• awards
• backoff-retry-504-errors
• bump-enum-1-1-6
• buyer-email-domain-audit
• buyers_param_for_/users
• cancelled
• cancelled_on_filtering_for_briefs
• cf-debug
• copy-my-requirements
• countersign_agreement_route
• cpw-add-data-supplier-id-to-find-audit-events-params
• cpw-add-method-for-transition-dos-endpoint
• cpw-add-retry-to-requests
• cpw-add-update-supplier-framework-audit-event
• cpw-copy-current-services-in-one-go
• create-brief-response-audit-type
• create-find-framework-suppliers-iter
• create-supplier
• create_submit_brief_response_route
• deconstruct-url
• dfeduplicate-test-fixtures
• dm-changelog-fix
• dm-publish-brief
• enforce-eligible-email
• extract-apiclient-from-dmutils
• filter-agreements-by-status
• filter-br
• filter-brief-response-by-status
• find_briefs
• find_framework_suppliers_with_declarions_default_to_true
• fix-api-stubs-logic
• flake8
• framework-agreement-audit-events
• framework-agreement-routes
• framework-framework
• generic-update
• index-multiple-objects
• is-supplier-eligible
• iter-method-for-briefs
• jk-add-pyup
• jk-bump-requirements
• jk-remove-six-library
• jk-update-client-remove-declarations
• ks-add-name-param-for-suppliers
• ks-allow-py37-and-up
• ks-delete-declaration-audit-type
• ks-pyup-sunday
• ks-supplier-search-by-crn
• ldeb-add-data-draft-service-id-to-get-audits
• ldeb-add-get-buyer-email-domains
• ldeb-add-python-requires-spec
• ldeb-bump-flake8
• ldeb-python-venv
• ldeb-pyup-requirements-test-monthly
• ldeb-pyup-requirements-test-update-false
• ldeb-still-assessing
• ldeb-update-dev-requirements
• ldeb-update-project-audit-event
• master
• md-fetch-earliest-for-obj
• md-get-audit-event
• mit-license
• mock
• new_audit_events_for_brief_responses
• notify-suppliers-of-awarded
• one_week_or_two
• page-questions-brief-response
• pc-add-agreement-audits
• pc-agreement-returned
• pc-bring-back-brief-responses
• pc-forgive-failing-502s
• pc-irrevokably-inhibit-imports
• pc-undo-unwriting-unsetting
• pc_admin_buyers
• pc_better_bogus_briefs
• pluralise-agreed-variations
• preserve-base-url-scheme
• procurement-project-audit-events
• procurement-projects
• put-after-all
• pytest-3x
• python36
• pyup-config
• pyup-scheduled-update-2019-02-25
• pyup-scheduled-update-2019-03-04
• pyup-scheduled-update-2019-03-11
• pyup-scheduled-update-2019-03-18
• pyup-scheduled-update-2019-03-25
• pyup-scheduled-update-2019-04-01
• pyup-scheduled-update-2019-04-22
• pyup-scheduled-update-2019-04-29
• pyup-scheduled-update-2019-05-06
• pyup-scheduled-update-2019-05-13
• pyup-scheduled-update-2019-06-02
• pyup-scheduled-update-2019-06-09
• pyup-scheduled-update-2019-06-16
• pyup-update-coverage-3.7.1-to-4.5.2
• pyup-update-flake8-3.5.0-to-3.6.0
• pyup-update-flake8-3.6.0-to-3.7.3
• pyup-update-flake8-3.6.0-to-3.7.4
• pyup-update-flake8-3.6.0-to-3.7.5
• pyup-update-flake8-per-file-ignores-0.4.0-to-0.7
• pyup-update-flake8-per-file-ignores-0.7-to-0.8
• pyup-update-flake8-per-file-ignores-0.7-to-0.8.1
• pyup-update-pytest-3.2.3-to-4.1.1
• pyup-update-pytest-4.1.1-to-4.2.0
• pyup-update-python-coveralls-2.5.0-to-2.9.1
• pyup-update-requests-mock-0.6.0-to-1.5.2
• question_answers
• really-update-status
• remaining-fa-routes
• remove-temp-route
• replace-enum34-with-aenum
• requirements-update
• ris-15-bump
• ris-annotate-self-onto-app
• ris-antivirus-initial
• ris-child-span-id
• ris-clients-near-immutable
• ris-declaration-update-audit-event
• ris-default-nix
• ris-default-nix-glibc-locales
• ris-enum34
• ris-find-audit-events-after-event-id
• ris-find-outcomes
• ris-find-projects-having-outcome
• ris-find-users-user-research-opted-in
• ris-get-supplier-frameworks-with-declarations
• ris-ignore-response
• ris-mailing-list-audit-event
• ris-name-iter-methods
• ris-new-outcome-calls
• ris-onwards-request-headers
• ris-prefill-declaration
• ris-process-outcomes-audit-types
• ris-remove-monotonic
• ris-scan-tag-s3-put
• ris-search-client-del-wait-for-resp
• ris-service-edit-admin-tools
• ris-set-sf-allow-declaration-reuse
• ris-timeout
• ris-timeout-retries
• ris-unapprove-agreement
• ris-update-declaration
• ris-update-service-wait-for-index
• role-based-authentication
• send_user_id_when_countersigning_framework_agreements
• shw-58-remove-registration-date
• shw-active-searches-only
• shw-add-category-aggregations
• shw-add-supplier-fixture
• shw-add-update-framework
• shw-allow-direct-award-projects-ordering
• shw-application-company-details
• shw-bad-coverage
• shw-get-index-from-url
• shw-get-project-services
• shw-lock-project-and-get-services-by-url
• shw-log-error-message
• shw-normalize-getter-name
• shw-pin-flask
• shw-remove-default-index
• shw-remove-user-param
• shw-search-restrict-source-fields
• shw-update-dependencies
• shw-update-direct-award-calls
• shw-update-framework-stub
• shw-update-nixfile
• shw-update-supplier-fixture
• signing-changes
• signing_spike
• temp-countersign
• unlock-user-on-password-reset
• unset-framework-agreement
• update-brief-stub
• update-briefs-update
• update-by-admin-audit-event
• update-for-saved-search-data-tracking
• update_brief_response_route
• user-research-mailing-list
• withdraw-brief

Build # 923

Build Type

push

travis-ci

Committed by idavidmcdonald

Commit Message

Allow iter methods to not find `links` key in JSON response

As part of a PR to standardise the API responses (
https://github.com/alphagov/digitalmarketplace-api/pull/693), we
may no longer be including `links` dicts as part of an endpoints
response.

An endpoint may change from returning a `paginated_result_response`
to returning a `list_result_response` based on the query params
that have been provided.

We discovered that we have iter methods such as the
`find_services_iter` which will break when passing in a supplier
ID paramater as they now return a standardised `list_result_response`
which no longer includes `links`. However the `iter` methods at
the moment rely on getting a `links` key in their result.

Changing our API client to be permissive feels like the easiest
thing to do which won't have any functionality changes, especially
as it is likely that we were only originally returning an empty
list of links from the API so we wouldn't break the API client
rather than providing extra useful information in our responses.

Run Details

2 of 2 new or added lines in 2 files covered. (100.0%)

604 of 612 relevant lines covered (98.69%)

1.97 hits per line