allegro / marathon-consul

89%

master: 91%

LAST BUILD ON BRANCH improve_label_generation_perf

branch: improve_label_generation_perf

CHANGE BRANCH

x

Reset

• improve_label_generation_perf
• 1.2.0
• 1.2.0-RC1
• 1.2.0-RC2
• 1.2.1
• 1.3.1
• 1.3.2
• 1.3.3
• 1.3.4
• 1.4.0
• 1.4.1
• 1.4.2
• 1.5.0
• 1.5.1
• 1.5.3
• 276-agents-api-unified
• 276-local-agent-reads
• Fixes#55_Agents_cache_smart_cleanup
• Fixes#59_filter_apps_on_marathon_side
• acl_token_test
• add_linter
• add_logging
• add_systemd_service
• add_tests_to_streamer
• agents_connection_leak_fix
• apps_in_groups_deployments
• async_envent_processing
• blacklisted-healthcheck-types
• bug-fix/update_readme
• bugfix/#135/Version_number_interpolation
• bugfix/#164/check_ports_bounds
• bugfix/#191/add_startup_consul_host
• bugfix/#88/avoid_stale_data
• bugfix/113/use_fpm_to_create_package
• bugfix/243/marathon-loses-conectivity
• bugfix/event-type-metric
• bugfix/marathon-metrics-delay
• bugfix/move-leader-to-marathon
• bugfix/sanitize-logs
• build-release
• bump_golang_ci_version
• cleanup
• cleanup_sync_service
• configurable_enable_tag_overide
• configurable_tag_name
• configure_consul_request_timeout
• configure_logger
• consul-add-service-port-tag
• consul_fixt_test
• consul_get_services_with_retries
• consuldatacenters
• custom_service_name
• deploy_to_bintray_from_travis
• describe_when_empty_event_can_occure
• destringify
• develop
• distribution_docs
• enable_linter_to_whole_project
• event_based_deregistration_fix
• expose_sse_retries
• feature/sse_leader_poll
• feature/sync-metrics
• find_service_by_task_using_tags
• find_tasks
• fix/leader-metric
• fix/taskid-loglevel
• fix_264
• fix_flaky_test
• fix_golint
• fix_linter
• fix_ports_with_port_definitions
• fix_race_conditions
• fix_sentry_config
• fix_travis
• fix_wrong_filed_tag
• fixes/#139/drop_not_supported_events
• fixes/#171/fix_consul_tests
• fixes/143/SSE
• fixes/143/SSE_client
• fixes/148/handle_new_events
• fixes/149/calculate_ignores_healthcheck_only_once
• fixes/151/handle_mesos_healthchecks
• fixes/56/humanreadable_duration_in_config
• fixes/out_of_bounds_error
• fixes_#108_health_check_invalid_port_number
• fixes_#177/release_from_travis
• fixes_#177/release_from_travis_intsall_fpm
• fixes_#184_clear_metrics_before_sync
• fixes_#64_#65_update_readme
• fixes_#72_unregister_only_tasks_for_given_apps
• fixes_#81_configure_consul_name_sparator
• fixes_122_set_initial_heatlcheck_status
• fixes_71_add_dockerfile
• fixes_81_service_name_separator
• fixes_83_killed_unhealthy_task
• flaky_tests_fix
• format_code
• go18
• golang_1.9
• happy_status_codes
• hotfix/defer_called_every_time
• hotfix/slice_append_magic
• ip_resolving
• leader_sync
• log_error_when_queue_is_full
• log_sync_summary
• make_build_fix
• master
• migrate_to_marathon_task_tag
• migration-readme
• more_descriptive_logs
• mov_testdata_to_testdata
• move-event-handler
• multiple-names-under-one-port
• multiple-registrations
• nonblocking_events
• read_confgi_from_file
• readme_cleanup
• reduce_error_logging
• reduce_scope
• reduct_parsing
• register_first_deregister_second_during_sync
• release/1.2.1
• release/1.3
• release/1.3.1
• release/1.3.2
• release/1.3.3
• release/1.3.4
• release/1.3.5
• release/1.4.0
• release/1.4.2
• releases/1.4.1
• releases_with_travis
• remove_1.0.0_migration_script
• remove_http_callback
• remove_install_consul
• remove_ogier
• remove_pester_dep
• remove_uncecessary_loggoing
• remove_unhealthy_task_kill_event_handler
• remove_unnecessary_deregister_argument
• reregister_on_missing_marathon_task_tag_during_sync
• response_body_closing
• run_tests_separetly
• separate_service_id_from_task_id
• show
• simplify_stopping_and_renaming_applications
• skip_tasks_with_excess_registrations_when_syncing
• skip_tests_in_goxc
• speed_up_consul_tests
• sync-multiple-registrations
• sync_log_msg_update
• sync_optimization
• terminated_app_deregistration_fix
• tests_for_separating_service_id_from_task_id
• travis_fix
• travis_with_makefile
• unregister_task_without_asking_marathon
• update_consul
• update_consul_version
• update_consul_version_for_tests-1
• update_dependecies
• update_deps
• update_readme
• update_readme_#72
• update_readme_sentry
• update_sample_config_file
• use_vendor_dir_to_freeze_dependecies
• v0.3.1
• v0.3.2
• v0.3.3
• v0.3.4
• v0.3.5
• v0.3.6
• v0.4.0
• v0.4.1
• v1.0.0
• v1.1.0

Build # 1081

Build Type

push

travis-ci

Committed by janisz

Commit Message

Calculate common tags only once.

This PR extracts commonTags outside of loop.
They are not changed inside the loop so there is no
need to recalculate them every time.
Ta reduce allocations tags slice i create with
initial capacity equal to the lenght of application labels.

```
benchmark                              old ns/op     new ns/op     delta
BenchmarkApp_RegistrationIntents-8     438           415           -5.25%
BenchmarkApp_RegistrationIntents-8     436           419           -3.90%
BenchmarkApp_RegistrationIntents-8     432           415           -3.94%

benchmark                              old allocs     new allocs     delta
BenchmarkApp_RegistrationIntents-8     4              3              -25.00%
BenchmarkApp_RegistrationIntents-8     4              3              -25.00%
BenchmarkApp_RegistrationIntents-8     4              3              -25.00%

benchmark                              old bytes     new bytes     delta
BenchmarkApp_RegistrationIntents-8     128           208           +62.50%
BenchmarkApp_RegistrationIntents-8     128           208           +62.50%
BenchmarkApp_RegistrationIntents-8     128           208           +62.50%
```

Run Details

1699 of 1901 relevant lines covered (89.37%)

19.6 hits per line