akrennmair / newsbeuter

32%

master: 60%

LAST BUILD ON BRANCH feature/cppcheck

branch: feature/cppcheck

CHANGE BRANCH

x

Reset

• feature/cppcheck
• bugfix/219-unit-tests
• bugfix/324-newsblur-auth-fail
• bugfix/334-escaping-backticks
• bugfix/336
• bugfix/336-again
• bugfix/481-properly-formatting-quotes
• bugfix/522-openssl-new-threading-api
• bugfix/clang-on-linux-travis-builds
• bugfix/correct-config.sh
• bugfix/fix-travis-build
• bugfix/no-wordexp
• bugfix/travis
• bugfix/travis-build-895
• bugfix/travis-osx-coveralls
• bugfix/ttrss-auth-failure
• bugfix/wrapfix
• fancy-changelog
• feature/341-pass-feed-title-to-bmk-script
• feature/better-test-descriptions
• feature/coveralls
• feature/crusade-against-c-casts
• feature/crusade-against-pointers-to-char
• feature/enum-class
• feature/i18nspector
• feature/no-bare-pointers-in-tests
• feature/slimmer-rss_item-interface
• feature/tagged-tests
• feature/test-sql
• feature/travis-gcc-6
• feature/uniform-coverage
• feature/updated-catch
• feature/upgrade-to-precise-on-travis
• feature/upgrade-to-trusty-on-travis
• feature/variadic-templates
• master
• ordinary-changelog

Build # 742

Build Type

push

travis-ci

Committed by Minoru

Commit Message

Fix erroneous comments in rss_feed::set_rssurl

cppcheck pointed out that I overwrite variable's value right after
assigning it, and this proved to be true. However, while looking into
it, I found that the comments I left in the function don't match the
reality as the input that it gets are a bit different from the examples
in comments. It's sheer luck that the code that I got by making
a mistake turned out to be *right*.

So I removed superfluous code, amended the comments and added a few
tests to make sure I never step into that particular trap ever again.

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

4310 of 13297 relevant lines covered (32.41%)

561.07 hits per line