ajgon / opsworks_ruby

100%

master: 100%

LAST BUILD ON BRANCH fix/224

branch: fix/224

CHANGE BRANCH

x

Reset

• fix/224
• 1.9.1
• chore/fix-docker
• dependabot/bundler/activesupport-5.2.4.3
• dependabot/bundler/rack-2.0.8
• dependabot/bundler/rack-2.2.3
• dependabot/bundler/rexml-3.2.5
• encrypted-travis
• entryboss-master
• feat/165
• feat/apache2-mod-status
• feat/chef-version
• feat/force-ssl
• feat/foreground-appserver
• feat/fullstaq
• feat/multiple-databases-support
• feat/packs-webserver
• feat/remove-deployer
• feat/webpacker
• fix/127
• fix/156
• fix/157
• fix/167
• fix/92
• fix/include-deploy-resource
• integration
• master
• ruzia-fix_puma_service
• sidekiq/multiple-configs
• v0.1.0
• v0.10.0
• v0.2.0
• v0.2.1
• v0.3.0
• v0.3.1
• v0.5.0
• v0.6.0
• v0.7.0
• v0.8.0
• v1.0.0
• v1.1.0
• v1.1.1
• v1.1.2
• v1.10.0
• v1.10.1
• v1.11.0
• v1.12.0
• v1.13.0
• v1.14.0
• v1.15.0
• v1.16.0
• v1.17.0
• v1.18.0
• v1.18.1
• v1.19.0
• v1.2.0
• v1.2.1
• v1.20.0
• v1.20.1
• v1.20.2
• v1.20.3
• v1.3.0
• v1.4.0
• v1.5.0
• v1.6.0
• v1.7.0
• v1.7.1
• v1.8.0
• v1.9.0
• v1.9.1
• wip/http
• wip/s3

Build # 576

Build Type

push

travis-ci

Committed by ajgon

Commit Message

fix: replace symlink options instead of appending them

Before this patch, global options `symlinks`,
`create_dirs_before_symlink` and `purge_before_symlink` were appending
new entries to existing defaults, instead of replacing them. This was
counter-intuitive as all other options override existing ones and there
is no reason that there should be an exception.

Fixes #224

BREAKING CHANGE: `app['global']['create_dirs_before_symlink']`,
`app['global']['purge_before_symlink']` and `app['global']['symlinks']`
now overrides defaults instead of appending them. If you were relying on
those options in your Custom JSON, you need to add missing defaults
manually.

For example given:

```json
{
  "deploy": {
    "myapp": {
      "global": {
        "create_dirs_before_symlink": ["test/create"],
        "purge_before_symlink": ["test/purge"],
        "symlinks": {
          "test": "test/symlinks"
        }
      }
    }
  }
}
```

you need to replace it to:

```json
{
  "deploy": {
    "myapp": {
      "global": {
        "create_dirs_before_symlink": ["tmp", "public", "config", "../../shared/cache", "../../shared/assets", "test/create"],
        "purge_before_symlink": ["log", "tmp/cache", "tmp/pids", "public/system", "public/assets", "test/purge"],
        "symlinks": {
          "system": "public/system",
          "assets": "public/assets",
          "cache": "tmp/cache",
          "pids": "tmp/pids",
          "log": "log",
          "test": "test/symlinks"
        }
      }
    }
  }
}
```

Run Details

12572 of 12572 relevant lines covered (100.0%)

14.84 hits per line