airbnb / superset

70%

master: 0%

LAST BUILD ON BRANCH crud_optimizations

branch: crud_optimizations

CHANGE BRANCH

x

Reset

• crud_optimizations
• 0.1.0-dev
• 0.10.0
• 0.11.0
• 0.12.0
• 0.13.0
• 0.13.1
• 0.13.2
• 0.14.0
• 0.14.1
• 0.15.0
• 0.15.1
• 0.15.2
• 0.15.3
• 0.15.4
• 0.16.0
• 0.16.1
• 0.17.1
• 0.17.2
• 0.17.3
• 0.17.4
• 0.17.5
• 0.17.6
• 0.18.0
• 0.18.2
• 0.18.3
• 0.18.4
• 0.18.5
• 0.8.5
• 0.8.6
• 0.8.7
• 0.8.8
• 0.8.9
• 0.9.0
• 0.9.1
• 10105
• 1131_add_tests
• HEAD
• add_all_tables_endpoint
• add_crontab
• add_schema_perms
• add_slice
• add_slice_redirect
• add_users_to_roles
• addmissingflaskwtf
• airbnb-master
• airbnb_prod
• airbnb_prod.0.11.0.1
• airbnb_prod.0.11.0.2
• airbnb_prod.0.11.0.3
• airbnb_prod.0.11.0.4
• airbnb_prod.0.11.0.5
• airbnb_prod.0.11.0.6
• airbnb_prod.0.12.0.1
• airbnb_prod.0.12.0.2
• airbnb_prod.0.12.1.0
• airbnb_prod.0.13.0.0
• airbnb_prod.0.13.0.1
• airbnb_prod.0.13.0.2
• airbnb_prod.0.13.0.3
• airbnb_prod.0.15.0.1
• airbnb_prod.0.15.4.1
• alanna-explore-v2-main
• alanna-webpack-file-naming
• alternate_2665
• anigif
• anomaly
• api-testconn
• ascott-0.17.0rc1
• ascott-0.17.1rc1
• ascott-0.17.2rc1
• ascott-0.17.5-alpha.10
• ascott-update-contrib-docs
• ascott-update-webpack-config
• ascott-v0.16.1
• ascott-v0.16.1rc1
• ascott-v0.16.1rc2
• ascott-v0.17.1
• avoid_tiny_font_size
• backend
• bar_y_axis_format
• basestringdruid
• better_cache
• better_welcome
• big_number_total
• bignum_tip
• bkyryliuk-patch-1
• blueprints
• bogdan/cta_as_separate_end_point
• bogdan/grant_perm_to_role
• bogdan/query_status_polling
• break
• btn-retrieve
• bugfix
• bugfix_bignumber_neg
• bugfix_semi_query
• bump_limit
• bump_py
• bump_py_libs
• bumpcrypto19
• buttons
• byolken/remove_unused_symlinks
• byolken/s3_cache_implementation
• byolken/support_pex
• byolken__fix_tox
• byolken__fix_tox2
• byolken__revert_webpack_command_changes
• byolken__webpack_tweaks
• byolken_test
• carapal
• caravel_macros
• celery
• celery_workers
• change_button_description
• chart_component
• chords
• chris/fix-sunburst-level-trunc
• chris/heatmap-fixes
• chris/msgs-to-modals
• chris/remove-random-power-units
• chris/sankey-improvements
• chris/sankey-refresh
• chris/sunburst-conditional-percent
• chris/support-standalone-arg-in-slice-id-endpoint
• clarifications
• clean_cli
• clearable
• code_editor
• column_type
• compare
• connectors
• control-test
• control_header_flex
• credits
• csrf
• css_background
• css_v2
• csv-import
• csv-import-travis
• current_user_macro
• d3format_by_metric
• dash_refact
• dashboard-save-as
• datasource_slices
• db_name
• ddol/sankey_tooltip_bug
• default_db
• default_metric
• delay_filter
• delete_datasource
• dep_is_featured
• deploy
• deprecate_v1
• develop
• development
• disabled
• display_error
• display_partitions
• docs_faq
• docs_filtering
• docs_gallery
• docs_public
• druid/support_post_agg
• druidQuantilesDisplay
• druid_dashboard_export
• druid_having
• druid_hot_fix
• druid_latest_seg
• druid_mock
• druid_origin
• druid_regex
• druid_tests
• druid_topn
• druid_ts
• dsl
• dummy
• dumps_dates
• ecometrica
• edit_table_url
• email
• enable_filter_in_examples
• end_result_backend_time
• error_handling
• examples_as_tests
• exclude_robot_roles
• expose-slice-id-endpoint
• fab162
• fab_hack
• fadeto
• fetch
• filter-value-selector
• filter_box_css
• filterable
• filterbox_verbose
• fix-hardcoded-url-python
• fix-hardcoded-urls
• fix-hardcoded-urls-python
• fix1910
• fix2643
• fix2660
• fixSupportMoreDruidPostAgg
• fix_1689
• fix_1896
• fix_2814
• fix_292
• fix_agg_types
• fix_alt_enter
• fix_anon
• fix_bars
• fix_bignum
• fix_browser_freeze
• fix_cache
• fix_caching_errors
• fix_change_viztype
• fix_component_update
• fix_country_maps
• fix_css_bug
• fix_css_editor
• fix_csv
• fix_ctas
• fix_d3f
• fix_dash_perms
• fix_db_order
• fix_db_ordering
• fix_db_saved_query
• fix_db_upgrade
• fix_delete_datasource
• fix_doubles
• fix_druid
• fix_dup_cols
• fix_error_msg
• fix_escaping
• fix_extending_role
• fix_filers
• fix_filter
• fix_filter_table
• fix_filtering_on_int
• fix_filters
• fix_filtesr
• fix_fix
• fix_getter
• fix_grain
• fix_having
• fix_hive_engine
• fix_in_numeric
• fix_init
• fix_landscape
• fix_limit_bubble
• fix_login_redirects
• fix_markup
• fix_master_dup
• fix_merge_perms
• fix_metrics_default
• fix_missing_datasource
• fix_missing_perms
• fix_missingds
• fix_mq_down
• fix_none_view_menues
• fix_partition_query
• fix_pending
• fix_percent
• fix_perms
• fix_pk_table
• fix_presto_percent
• fix_query_loading
• fix_question_mark
• fix_sankey
• fix_save_dash
• fix_save_slice
• fix_security
• fix_separator
• fix_sort_bars
• fix_spinners
• fix_sql
• fix_sql_clauses
• fix_sql_fetch_result_perms
• fix_sqlite_lab
• fix_sqllab_csv
• fix_sqllab_cta
• fix_standalone_heiht
• fix_stop
• fix_table_dates
• fix_table_default
• fix_table_explore
• fix_table_sort
• fix_table_view
• fix_tablecolumn
• fix_tally
• fix_tally_2
• fix_template_from
• fix_the_fix
• fix_theme
• fix_time
• fix_ts
• fix_type_inference
• fix_uglify_npm
• fix_user_time
• fix_values_view
• fix_vizflow_groupby
• fix_warn6
• fix_welcome
• fix_welcome_order
• fix_x_scroll
• flower
• form_data_template
• freeform_select_filter
• full_datasource_name
• future_imports
• fx_trailing_slash
• gg-AddPythonTestsDevReqs
• gg-CheckboxAlignment
• gg-ClarifyTimeoutConfig
• gg-DashboardTimeoutWarning
• gg-EditTitle
• gg-EnterEndEditingTitle
• gg-ExploreViewSaveModalSpec
• gg-ExploreViewSplitReducerLogic
• gg-LongQueryVisualizeAdvise
• gg-ResultSet
• gg-ResultSetTestCoverage
• gg-SalLabTestCoverage
• gg-SlicesTemplate
• gg-TestCoverageSqlLab
• gg-VisualModalTests
• gg-VisualizeModalColumnsAlignment
• gg-addTestCoverage-VisualizeModal
• gg-addValidationRuleForVisualize
• gg-autoSelect
• gg-fixIsOwnerCheck
• gg-fixLintingError
• gg-keepColumnsStateLocal
• gg-queryTimeout
• gg-reduceClientTimeout
• gg-refactorVisualizeAjaxCall
• gg-sqlLab-remember-selectedSchema
• gg-update-changeEventHandlerName
• handdev
• handle_object_exp
• heat_val
• hide_pass
• hive_adjust
• import_export_ds
• improve_bubbles
• improve_err_msg
• init_opt
• inside_out
• jinja_security
• js_bump
• kim/fix_druid_datasource_bug
• kim/fix_logging
• kim/test_key
• link_profile
• lint
• log_time
• logo
• main
• map_props_to_contrl
• master
• metric_ralign
• metrics
• minor_fixes
• more_connector_refact
• more_dash_tests
• more_filters
• more_statsd
• moretrans
• moretypesjsonserializer
• move_warning_msg_navbar
• mytest
• names
• newSliceTest
• no_metrics_validator
• no_part
• notify_dash_save
• numbers
• oath
• objects_to_json
• optimize_standalone
• orderby
• owners_save
• pad_markup
• paired-ttest-viz
• panels
• panels2
• para
• perm_cleanup
• perm_fix
• permission_cleanup_one_off
• pinpandas
• pivot
• pivot_totals
• preprocess_where
• prop-types
• push
• pylint
• pylint2
• pypi_class
• q
• quotestacktraces
• realisnum
• redirect_explore
• redirects
• reduxtools
• refact_chart
• refact_explore2
• refactor
• refactor_viz
• refresh_immune
• refs/pull/10/head
• refs/pull/11/head
• refs/pull/14/head
• refs/pull/15/head
• refs/pull/17/head
• refs/pull/19/head
• refs/pull/20/head
• refs/pull/22/head
• refs/pull/3/head
• refs/pull/5/head
• refs/pull/6/head
• refs/pull/9/head
• refs/tags/v0.0.1
• remove-margin
• remove-margin-dev
• remove-whitespace
• remove-whitespace-2
• remove-whitespace-3
• remove_results_backend
• remove_unused_js
• rename_field_control
• request_access_dash
• reraisesqllabgetresults
• reset_theme
• reshift_grain
• results_backends
• return_sql
• revert-1122-vliu_query_search
• revert-1335-bogdan/grant_perm_to_role
• revert-1465-fix_celery_dying_conn
• revert-1667-vliu_dashboard_view
• revert-1811-druid_dashboard_export
• revert-2055-vliu_async_results
• revert-2291-vliu_druid_filters
• revert-685-run_q
• revert_cli_changes
• run_q
• sankey_loop
• save_As
• save_as
• saved_queries
• schema_fix
• schema_star
• screwdriver
• scroll
• scroll_bar
• security
• select_db
• simplify_vizes
• simplifyer
• slice_owner
• slice_timeout
• smooth-nvd3-refresh
• social_stats
• source_map
• space
• speed_poll
• sql_lab/cache_force_reset
• sql_lab/default_result_backend
• sql_lab/fetch_schemas
• sql_lab/fix_csv
• sql_lab/fix_refresh_queries
• sql_lab/fix_viz
• sql_lab/full_text_search
• sql_lab/hive_support
• sql_preprocessor
• sqla_config
• sqla_warning
• sqla_warning2
• sqla_warning3
• sqllab
• sqllab_adjust_width
• sqllab_array_conv
• sqllab_async
• sqllab_left
• sqllite_month_time_grain
• sqlparse/get_table_names
• stats
• stop_creating_dup_perms
• stop_query
• supercat
• superset
• superset_staging
• switch-order
• sync_roles_and_create_users
• sync_users_by_username
• tableViewAddTimeShift
• table_overflow
• table_paginate
• table_sort
• template_all
• templates
• templates_fixed
• test_branch
• tgt-prod
• tgt-superset
• throttleresize
• throw-away
• thumbs
• thumbs2
• time_updates
• trans_more
• travis_matrix
• travisnoy3.5
• type_detect
• typedfillnae
• unused_sql_clause
• update_perms
• update_sqllab_perms
• url_param_sql
• use_2to3
• user_profile
• v2_hotfix
• v2_input_size
• v2_time_up
• v2_touchups
• v_0.15.4.1
• validate_2
• validators
• verbose
• version
• version_cli
• version_info
• vertica_install
• viz_type
• vliu_add_ajax_alerts
• vliu_add_sliceview_class
• vliu_add_viz_thumbnail
• vliu_alert_for_visualization
• vliu_async_results
• vliu_async_resultset
• vliu_async_select
• vliu_auto_render_on_fields
• vliu_autocomplete_bug
• vliu_bugfix_getFieldsState
• vliu_button_tooltips
• vliu_check_access
• vliu_cleanup_dar_hotfix
• vliu_copy_entire_menuitem
• vliu_copy_url
• vliu_count_distinct_metrics
• vliu_count_metric
• vliu_customize_table_filter
• vliu_dashboard_bug
• vliu_dashboard_fix
• vliu_dashboard_standalone_v2
• vliu_dashboard_view
• vliu_defaultFormData
• vliu_default_overwrite
• vliu_default_time_query_search
• vliu_delete_unused_components
• vliu_druid_filters
• vliu_druid_having_filter
• vliu_dual_axis_order
• vliu_dual_line
• vliu_dual_line_tooltip
• vliu_dualaxis_bug
• vliu_emailto_slice
• vliu_explore_query
• vliu_explore_timer
• vliu_explorev2_bugs
• vliu_explorev2_select
• vliu_explorev2_viz_bug
• vliu_filter
• vliu_filter_endpoint
• vliu_filter_field
• vliu_filter_spec
• vliu_fix_breakdown
• vliu_fix_explore_v2
• vliu_fix_querylink_bug
• vliu_fix_regex_filter
• vliu_hotfix
• vliu_nvd3_v2_bug
• vliu_overwrite_sql
• vliu_overwrite_sqleditor
• vliu_parse_dbid
• vliu_parse_filter_values
• vliu_parse_nested_results
• vliu_persist_explorev2
• vliu_presto_error
• vliu_put_datasource_in_store
• vliu_query_button_v2
• vliu_query_output
• vliu_query_response
• vliu_query_search_loading
• vliu_query_search_order
• vliu_query_search_scrollable
• vliu_query_v1
• vliu_reactify_save_modal
• vliu_remove_fetch_button
• vliu_resize_explorev2
• vliu_responsive_chart_container
• vliu_save_modal_bug
• vliu_save_modal_spec
• vliu_save_new_slice
• vliu_save_queries
• vliu_save_slice_id
• vliu_save_slice_v2
• vliu_scroll_chart
• vliu_search_failed_queries
• vliu_share_long_query
• vliu_slice_list
• vliu_solve_sqllab_height_problem
• vliu_sqllab_overwrite_editor
• vliu_stop_query_sqllab
• vliu_textfield_bug
• vliu_textfield_v2_bug
• vliu_timeshift_validator
• vliu_update_chart_v2
• vliu_view_query
• vliu_visualize_long_query
• vliu_visualize_modal_bug
• vliu_welcome_login
• wolfe--add-postagg-escape-hatch
• xss
• yarn
• yarn_docs
• ybounds

Build # 1058

Build Type

push

travis-ci

Committed by mistercrunch

Commit Message

Speed up all CRUD list views

Load times on list view pages like Slices, Dashboards, Tables and Database
have grown to be terrible over time.

After a bit of digging, I found that the not specifying `search_columns`
in ModelViews actually means "all columns" and that for each filter,
FAB goes and fetches a list of all values to prepopulate the
filter dropdowns. That means that the list of tables would fetch all
slices and all users upfront which is horrible. Worse, database list
view would fetch all queries with is insane.

This picks a subset of columns for search/filters and changes the
default to show only 100 elements per page instead of 500

Run Details

8 of 8 new or added lines in 5 files covered. (100.0%)

4247 of 6068 relevant lines covered (69.99%)

2.79 hits per line