aiidateam / aiida_core

69%

develop: 74%

LAST BUILD ON BRANCH fix_465_upgrade_sqlalchemy

branch: fix_465_upgrade_sqlalchemy

CHANGE BRANCH

x

Reset

• fix_465_upgrade_sqlalchemy
• backend_transactions
• borellim-docs-typo-1
• borellim-docs-typo-2
• borellim-fix-show-mpl
• develop
• django_jsonb
• fix_1741_expose_inputs_deepcopy
• fix_201_method_names_for_data
• fix_2082_process_command_waits
• fix_2233_node_to_new_backend
• fix_2342_update_export_import_to_prov_redesign
• fix_2981_verdi_export_inspect
• fix_3013_docs_venv_qinstall
• fix_3014
• fix_3014_changes_marco
• fix_3015_code_setup
• fix_3037_update_kiwipy
• fix_migration_py3_integrity_violation
• fix_missing_testing_deps
• fix_test_cif_structure_roundtrip
• fix_test_inline_export
• fix_working_with_aiida
• giovannipizzi-fix-templatereplacer
• issue_2237_rebased2
• issue_3062_process_report
• master
• merge_master_into_develop
• new_engine
• new_engine_jenkins
• newest_plum
• orm_design_refactor
• orm_group_refactor
• orm_log_refactor
• provenance_redesign
• query-contains-filter-doc
• release_v0.12.3
• release_v0.12.4
• release_v1.0.0a3
• release_v1.0.0a4
• release_v1.0.0b1
• release_v1.0.0b3
• serialize
• sphuber-fix_1787_sqla_model_wrapper_setter
• support/0.12.x
• v0.12.3
• v1.0.0a3
• v1.0.0a4
• v1.0.0b1
• v1.0.0b2
• v1.0.0b3
• v1.0.0b4
• zhubonan-patch-1

Build # 4385

Build Type

Pull #2113

travis-ci

Committed by web-flow

Commit Message

Only let the `ModelWrapper` call `flag_modified`

The `_set_metadata` method of `SqlaComputer` was calling `flag_modified`
manually after having set the attribute, however, since the model is
wrapped in the `ModelWrapper`, it's `__setattr__` will take care of
calling `flag_modified` when it flushes upon an attribute being updated
for a stored entity. Calling `flag_modified` on the same key twice will
except in SqlAlchemy 1.2.12 because the "dirty" attribute has already
been removed and moved into the database model instance.

Pull Request Pull Request #2113: Upgrade the dependency requirement of SqlAlchemy

Run Details

63 of 63 new or added lines in 9 files covered. (100.0%)

25368 of 36989 relevant lines covered (68.58%)

2.41 hits per line