agateau / yokadi

68%

master: 68%

LAST BUILD ON BRANCH fix-stale-lock

branch: fix-stale-lock

CHANGE BRANCH

x

Reset

• fix-stale-lock
• 1.0
• 1.0-dev
• 1.0.0
• 1.0.1
• 1.0.2
• 1.1
• 1.1-dev
• 1.1.0
• 1.1.1
• 1.2.0
• avoid-reaching-parameter-limit
• db-v10
• db-v11
• db-v12
• db-v9
• dev
• dirs
• drop-project-keyword
• fix-edit-rm-keyword
• fix-invalid-taskkeyword-rows
• fix-negative-keyword-filter
• improve-update
• install-fixes
• json-recurrence
• master
• mkdist
• no-tui-in-core
• profile
• python3-sqla
• rm-utils
• split-keywordfilter-class
• sync
• sync-unbreak-travis
• version-refactor
• watch-sql-events
• wip/cascade
• wip/medit
• wip/rename-dump-fields
• wip/rm-crypto

Build # 167

Build Type

push

travis-ci

Committed by agateau

Commit Message

Unbreak task lock

Deleting stale locks would break because after self.session.delete(lock),
the lock is still in the session as long as it has not been committed.
Instead of committing, and risking a concurrency issue, reuse the lock by
updating its pid and updateDate fields.

Made the code a bit easier to test by adding named parameters for pid
and date, added a unit test.

Run Details

1872 of 2764 relevant lines covered (67.73%)

1.35 hits per line