accordproject / template-archive

91%

push

github

feat(cicero-core): add UMD browser bundle + Playwright signing tests (#915)

* feat(cicero-core): add UMD browser bundle with Playwright tests

Adds a separate dist/cicero-core.browser.js UMD bundle so browser
bundlers (Vite, webpack, esbuild) pick it up via the new "browser"
field in package.json while Node consumers continue using the CJS
bundle via "main".

Key changes to enable browser compatibility:
- templateloader.js: move fs/path/promisify/DefaultArchiveLoader
  requires inside the methods that use them (lazy), so fromArchive
  and its zip-only helpers are never blocked by Node-only modules
- templatesaver.js: replace path.basename() with a split fallback
- template.js: switch signTemplate/verifyTemplateSignature to
  pure node-forge (already a dependency), removing the dependency
  on Node's crypto.createSign/createVerify; getHash() still uses
  crypto.createHash which crypto-browserify polyfills
- webpack.browser.config.js: new UMD webpack config with polyfills
  for crypto/stream/buffer/path and an alias forcing concerto-core
  to its CJS entry (the pre-built browser bundle has path=false
  internally — tracked at accordproject/concerto#1229)
- playwright.config.js + test/browser/signing.spec.js: 5 browser
  integration tests covering bundle exposure, fromArchive, signing,
  wrong passphrase, and tampered signature detection
- build.yml: 3 new CI steps to build the bundle and run Playwright

The lazy-require and path.basename→split techniques were pioneered
by @Shubh-Raj in #894 (a good source of ideas that used the wrong
bundle strategy — this PR adopts the techniques, keeps the right
dual-bundle approach, and adds the forge signing + Playwright tests).

Closes #880, #883. Supersedes #894.

Co-Authored-By: Shubh-Raj <Shubh-Raj@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Matt Roberts <code@rbrts.uk>

* fix(cicero-core): fix ESLint errors in browser Playwright spec

- Add `/* eslint-env ... (continued)

303 of 352 branches covered (86.08%)

Branch coverage included in aggregate %.

32 of 34 new or added lines in 3 files covered. (94.12%)

760 of 820 relevant lines covered (92.68%)

76.31 hits per line