accordproject / concerto
98%

DEFAULT BRANCH: main
Repo Added
Files 83
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x

coverage: 98.226%. Remained the same
23061611547

push

github

web-flow 
fix(concerto-core): fix logic error in skipValidationAndResolution guard (#1158)

* Initial plan

* fix(concerto-core): fix logic error in skipValidationAndResolution guard

The condition `!options?.disableMetamodelValidation === false` was
incorrectly evaluating to `true` when `disableMetamodelValidation` is
`true`, causing an error to be thrown in a configuration that should
be allowed. Fixed to `options?.disableMetamodelValidation === false`
to correctly mirror the `disableMetamodelResolution` check.

Signed-off-by: Copilot <copilot@github.com>

Co-authored-by: jamieshorten <842103+jamieshorten@users.noreply.github.com>

* fix(concerto-core): revert unrelated type and package-lock changes

Remove inadvertently staged changes to types/ files and package-lock.json
that were unrelated to the skipValidationAndResolution logic fix.

Signed-off-by: Copilot <copilot@github.com>

Co-authored-by: jamieshorten <842103+jamieshorten@users.noreply.github.com>

* test(concerto-core): add targeted throw tests for skipValidationAndResolution

Add two additional tests covering the case where skipValidationAndResolution
is true and either disableMetamodelResolution or disableMetamodelValidation
is individually set to false (each should throw).

Signed-off-by: Copilot <copilot@github.com>

Co-authored-by: jamieshorten <842103+jamieshorten@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jamieshorten <842103+jamieshorten@users.noreply.github.com>

2209 of 2291 branches covered (96.42%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4049 of 4080 relevant lines covered (99.24%)

155265.71 hits per line

Relevant lines Covered
4080 RELEVANT LINES 4049 COVERED LINES
155265.71 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
23061611547 main fix(concerto-core): fix logic error in skipValidationAndResolution guard (#1158) * Initial plan * fix(concerto-core): fix logic error in skipValidationAndResolution guard The condition `!options?.disableMetamodelValidation === false` was incorr... push web-flow github
98.23
23055252673 main feat(decorators): support batch DecoratorCommandSet application in one model scan (#1156) * feat(decorators): support batch DecoratorCommandSet application in one model scan Signed-off-by: muhammed-abdulkadir <muhammed.abdulkadir@docusign.com> ... push web-flow github
98.23
23053544337 main Merge a3432a361 into 4b5b5c26b Pull #1156 web-flow github
98.23
23052782680 main Merge d252f423c into 4b5b5c26b Pull #1156 web-flow github
98.24
23052093422 main Merge d2b3ce911 into 4b5b5c26b Pull #1156 web-flow github
98.21
23050529533 main Merge ad5760f26 into 4b5b5c26b Pull #1156 web-flow github
98.22
22569730672 main chore(ci): don't publish on build Signed-off-by: mttrbrts <code@rbrts.uk> push mttrbrts github
98.24
22551297009 main feat(concerto-util): add MonetaryUtil support (#1102) Signed-off-by: Aadityavardhan Singh <singhrashmi018@gmail.com> push web-flow github
98.24
22541094195 main fix: correct typographical errors in comments (#1145) fix: correct additional typographical errors in comments (#1108) Signed-off-by: niat-web <psm@nxtwave.in> Co-authored-by: niat-web <psm@nxtwave.in> push web-flow github
98.24
22017554364 main test: Add unit test for unrecognized model element in ModelFile (#1132) Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com> push web-flow github
98.24
See All Builds (1938)