abronan / libkv

84%

master: 84%

LAST BUILD ON BRANCH align_etcd_lock

branch: align_etcd_lock

CHANGE BRANCH

x

Reset

• align_etcd_lock
• align_redis_error
• consul_http
• consul_list_consistent
• docs
• docs_backend_installation
• etcd_list
• etcd_watch_fix_possible_race
• etcdv3
• filter_lock_key
• fix_cas_failure_test
• fix_consul_off_by_one
• fix_etcdv3_atomicput_ttl
• improve_tests
• list_ser
• master
• meta_list_fix
• readoptions
• switch_boltdb_fork
• update_docs
• update_go
• update_kv_version
• update_readme
• update_travis
• watchtree_key_event

Build # 62

Build Type

push

travis-ci

Committed by abronan

Commit Message

Align etcd v2 lock behavior with other stores

Generally, locks in distributed kv stores leave the key as is
after a process locks or unlocks the key. The lock is just used
for mutual exclusion on the key to write. Until now, etcd v2
had no lock API and we had to circumvent that using our own lock
algorithm which was essentially using Compare and Swap with
watches on delete behavior to handle locking the key. This meant
that the locked key would disappear/reappear after each call to
Lock/Unlock while other stores would let the key live outside
of locking portions as expected.

To align the behavior of etcd v2 with other stores and let the key
live outside of locking workflow, we now use a side key for the mutex
with a suffix "_lock". Only that key is now subject to CAS/delete leaving
the original key intact outside of calls to Lock/Unlock.

Signed-off-by: Alexandre Beslic <abeslic@abronan.com>

Run Details

1928 of 2293 relevant lines covered (84.08%)

9.86 hits per line