Yoast / PHPUnit-Polyfills

95%

3.x: 98%

LAST BUILD ON BRANCH feature/support-phpunit-8.5.38-9.6.19_-10.5.17

branch: feature/support-phpunit-8.5.38-9.6.19_-10.5.17

CHANGE BRANCH

x

Reset

• feature/support-phpunit-8.5.38-9.6.19_-10.5.17
• 1.x
• 2.x
• 2.0/phpunit-10/update-environment-and-ci
• 2.0/update-readme-changelog
• feature/remarklint-ignore-release-compare-links
• main
• 2.0.0
• feature/phpunit-9.6.11-add-assertobjecthaspropertytrait
• feature/changelog-1.1.0
• 1.1.0
• JRF/dependabot-update-config
• JRF/gitattributes-minor-tweaks
• JRF/composer-tweaks
• JRF/ghactions-remove-phpunit-10-trial
• feature/update-for-changed-message-format
• JRF/ghactions-php-8.3-update
• JRF/various-minor-ci-tweaks
• JRF/composer-add-security-link
• JRF/ghactions-switch-to-coveralls-reporter
• dependabot/github_actions/actions/checkout-4
• dependabot/github_actions/1.x/actions/setup-node-4
• JRF/removed-unused-use-statement
• JRF/docs-various-improvements
• JRF/CS/update-phpcs-ruleset-yoastcs-3.0.0
• feature/autoload-add-minor-extra-defensive-coding
• feature/ghactions-test-against-phpunit-10-php-8.4
• dependabot/github_actions/1.x/xt0rted/markdownlint-problem-matcher-3
• dependabot/github_actions/1.x/ramsey/composer-install-3
• feature/ghactions-update-markdownlint
• feature/assertobjectequalstests-fix-php-8.4-deprecation
• feature/ghactions-add-phar-testing-job
• feature/support-phpunit-8.5.38-9.6.19
• feature/composer-update-dependencies
• TESTING/2.x
• feature/changelog-1.1.1-release
• feature/changelog-2.0.1-release
• 1.1.1
• 2.0.1
• dependabot/github_actions/1.x/DavidAnson/markdownlint-cli2-action-16
• feature/tweak-markdown-workflow
• TEMP/2123-testing
• feature/improve-php-8.4-workaround-implicitly-nullable
• feature/test-docs-minor-update
• JRF/composer-dont-write-lock-file
• JRF/docs-various-tweaks
• JRF/1.x/add-phpstan
• JRF/2.x/add-phpstan
• JRF/release-checklist-update
• WIP/3.x
• TEMP/21328039
• feature/1.x-ghactions-use-nightly-for-php-next
• feature/1.x-php-8.4-restrict-test
• feature/ghactions-workflow-docs
• feature/ghactions-fix-phpunit-dev-test-run
• feature/ghactions-make-the-test-workflow-more-robust
• TEMP/123p0712p37
• feature/phpstan-config-minor-simplification
• documentation/custom-approach-expectdeprecations
• feature/1.x-minor-updates-for-start-of-3.x-branch
• feature/2.x/add-attributes-for-annotations
• feature/2.x/readme-updates
• feature/2.x/ghactions-stop-testing-against-phpunit-dev
• 3.x
• feature/3.x/drop-support-for-php-7.0
• feature/3.x/drop-support-for-phpunit-lt-64
• feature/3.x/drop-support-for-assertattributehelper
• feature/3.x/assertislist-sync-error-message-with-upstream
• feature/3.x/allow-for-phpunit-11
• feature/3.x/sync-with-phpunit-11
• feature/3.x/new-assertarraywithlistkeys-polyfill-trait
• feature/3.x/new-assertobjectnotequals-polyfill-trait
• feature/3.x/new-expectuserdeprecation-polyfill-trait
• feature/1.x-readme-update-for-polyfills-3.x
• 1.1.2
• feature/2.x-readme-update-links-to-docs
• feature/2.x-changelog-2.0.2
• 2.0.2
• feature/release-version-3.0
• 3.0.0
• feature/2.x/tests-minor-fix
• dependabot/github_actions/1.x/DavidAnson/markdownlint-cli2-action-17
• feature/markdown-fixes
• TEMP/test-123
• feature/partially-revert-URL-changes
• JRF/ghactions/dont-fail-on-8.4
• feature/cs-minor-fixes
• feature/ghactions-use-phpstan-1.0
• feature/equaltospecializations-minor-clean-up
• dependabot/github_actions/1.x/DavidAnson/markdownlint-cli2-action-18

Build # 8572169485

Build Type

Pull #164

github

Committed by jrfnl

Commit Message

AssertIgnoringLineEndings: fix compatibility with PHPUnit 8/9/10 PHAR files

PHPUnit 8.5..38, 9.6.19 and 10.5.17 contain a change in the PHAR files. In particular, a change in how external dependencies included in the packaged PHAR files are prefixed to prevent conflicts with potentially Composer installed dependencies on the same packages.

In practice, the prefix for these external dependencies which is being added when the PHAR is being build has changed from `PHPUnit\\` to `PHPUnitPHAR\\`.

This impacts the `AssertIgnoringLineEndings` polyfill which uses the `SebastianBergmann\Exporter\Exporter` class from the external `Exporter` dependency.

This commit fixes the issue.

Refs:
* https://github.com/sebastianbergmann/phpunit/releases/tag/8.5.38
* https://github.com/sebastianbergmann/phpunit/releases/tag/9.6.19
* https://github.com/sebastianbergmann/phpunit/releases/tag/10.5.17

Pull Request Pull Request #164: AssertIgnoringLineEndings: fix compatibility with PHPUnit 8/9/10 PHAR files

Run Details

4 of 7 new or added lines in 1 file covered. (57.14%)

614 of 648 relevant lines covered (94.75%)

87.2 hits per line