Yoast / PHPUnit-Polyfills

97%

3.x: 98%

LAST BUILD ON BRANCH TEMP/123p0712p37

branch: TEMP/123p0712p37

CHANGE BRANCH

x

Reset

• TEMP/123p0712p37
• 1.x
• 2.x
• 2.0/phpunit-10/update-environment-and-ci
• 2.0/update-readme-changelog
• feature/remarklint-ignore-release-compare-links
• main
• 2.0.0
• feature/phpunit-9.6.11-add-assertobjecthaspropertytrait
• feature/changelog-1.1.0
• 1.1.0
• JRF/dependabot-update-config
• JRF/gitattributes-minor-tweaks
• JRF/composer-tweaks
• JRF/ghactions-remove-phpunit-10-trial
• feature/update-for-changed-message-format
• JRF/ghactions-php-8.3-update
• JRF/various-minor-ci-tweaks
• JRF/composer-add-security-link
• JRF/ghactions-switch-to-coveralls-reporter
• dependabot/github_actions/actions/checkout-4
• dependabot/github_actions/1.x/actions/setup-node-4
• JRF/removed-unused-use-statement
• JRF/docs-various-improvements
• JRF/CS/update-phpcs-ruleset-yoastcs-3.0.0
• feature/autoload-add-minor-extra-defensive-coding
• feature/ghactions-test-against-phpunit-10-php-8.4
• dependabot/github_actions/1.x/xt0rted/markdownlint-problem-matcher-3
• dependabot/github_actions/1.x/ramsey/composer-install-3
• feature/ghactions-update-markdownlint
• feature/assertobjectequalstests-fix-php-8.4-deprecation
• feature/ghactions-add-phar-testing-job
• feature/support-phpunit-8.5.38-9.6.19
• feature/composer-update-dependencies
• TESTING/2.x
• feature/support-phpunit-8.5.38-9.6.19_-10.5.17
• feature/changelog-1.1.1-release
• feature/changelog-2.0.1-release
• 1.1.1
• 2.0.1
• dependabot/github_actions/1.x/DavidAnson/markdownlint-cli2-action-16
• feature/tweak-markdown-workflow
• TEMP/2123-testing
• feature/improve-php-8.4-workaround-implicitly-nullable
• feature/test-docs-minor-update
• JRF/composer-dont-write-lock-file
• JRF/docs-various-tweaks
• JRF/1.x/add-phpstan
• JRF/2.x/add-phpstan
• JRF/release-checklist-update
• WIP/3.x
• TEMP/21328039
• feature/1.x-ghactions-use-nightly-for-php-next
• feature/1.x-php-8.4-restrict-test
• feature/ghactions-workflow-docs
• feature/ghactions-fix-phpunit-dev-test-run
• feature/ghactions-make-the-test-workflow-more-robust
• feature/phpstan-config-minor-simplification
• documentation/custom-approach-expectdeprecations
• feature/1.x-minor-updates-for-start-of-3.x-branch
• feature/2.x/add-attributes-for-annotations
• feature/2.x/readme-updates
• feature/2.x/ghactions-stop-testing-against-phpunit-dev
• 3.x
• feature/3.x/drop-support-for-php-7.0
• feature/3.x/drop-support-for-phpunit-lt-64
• feature/3.x/drop-support-for-assertattributehelper
• feature/3.x/assertislist-sync-error-message-with-upstream
• feature/3.x/allow-for-phpunit-11
• feature/3.x/sync-with-phpunit-11
• feature/3.x/new-assertarraywithlistkeys-polyfill-trait
• feature/3.x/new-assertobjectnotequals-polyfill-trait
• feature/3.x/new-expectuserdeprecation-polyfill-trait
• feature/1.x-readme-update-for-polyfills-3.x
• 1.1.2
• feature/2.x-readme-update-links-to-docs
• feature/2.x-changelog-2.0.2
• 2.0.2
• feature/release-version-3.0
• 3.0.0
• feature/2.x/tests-minor-fix
• dependabot/github_actions/1.x/DavidAnson/markdownlint-cli2-action-17
• feature/markdown-fixes
• TEMP/test-123
• feature/partially-revert-URL-changes
• JRF/ghactions/dont-fail-on-8.4
• feature/cs-minor-fixes
• feature/ghactions-use-phpstan-1.0
• feature/equaltospecializations-minor-clean-up

Build # 10744184881

Build Type

push

github

Committed by jrfnl

Commit Message

PHPUnit 11.3.1 | AssertIsList: sync error message with upstream

PHPUnit 11.3.1 improved the type information in select assertion failure messages.

For the polyfills, this only affects the `AssertIsList` polyfill.

Now the choice was between the following:
* Just update the test(s) to have a different message expectation for PHPUnit 11.3.1+.
* Update the polyfills to mirror the improvement made in PHPUnit upstream.

I've chosen to implement the latter as it makes the message significantly more informative.

This means that on PHPUnit 6.x to 9.x and 11.3.1+, the new, improved message is shown. While on PHPUnit 10.0 - 11.3.0, the "old" message is shown as, in that case, the PHPUnit native `assertIsList()` method is used without the message improvements.

Includes:
* Renaming the `assertIsListFailureDescription()` method parameter from `$other` to `$value` to be more descriptive.
* Updating the tests, including adding an extra test with an anonymous class as that has separate handling for the error message in the polyfill.

Refs:
* https://github.com/sebastianbergmann/phpunit/commit/5e8b79e52
* https://github.com/sebastianbergmann/phpunit/commit/42cfc7d59

Run Details

14 of 14 new or added lines in 1 file covered. (100.0%)

580 of 597 relevant lines covered (97.15%)

124.53 hits per line