Wirone / PHP-CS-Fixer

95%

2.17: 93%

LAST BUILD ON BRANCH codito/grouped-unused-imports

branch: codito/grouped-unused-imports

CHANGE BRANCH

x

Reset

Sync Branches

• codito/grouped-unused-imports
• 2.17
• codito/3515-shorthand-operators
• codito/3635-array-destructuring-support-in-trim_array_spaces-fixer
• codito/3997-detailed-output
• codito/3997-progress-output-refactor
• codito/5402-support-callable
• codito/6093-fix-group-imports-with-aliases
• codito/6249-ensure-cache-dir
• codito/6413-do-not-namespacesize-phpunit-constants
• codito/6546-method-argument-space-with-attribute-support
• codito/6632-casing-types-in-arrow-functions
• codito/6996-cache-improvements
• codito/7025-fix-fqcn-shortening
• codito/7030-phpdoc-over-enum-case
• codito/7043-unify-blank-line-before-namespace-fixers
• codito/7062-fqcn-as-fixer-names
• codito/7159-fix-annotations-with-arguments
• codito/7210-suplement
• codito/7220-configurable-import-groupping
• codito/7250-drop-doctrine-annotations-dependency
• codito/7278-fix-checking-superfluous-phpdoc-with-superfluous-asterisk
• codito/7285-deprecation-contract-for-rulesets
• codito/7293-fix-priorities
• codito/7294-fix-determining-phpdoc-variable-name
• codito/7297-per-cs-set
• codito/7307-check-command-alias
• codito/7632-fqcn-import-symbol-name-clashes
• codito/7652-ignore-class-resolution-for-function
• codito/8066-configurable-buffer-size
• codito/allow-chore-PRs
• codito/allow-os-conditions-in-integration-tests
• codito/better-stale-message
• codito/bombazo
• codito/bombazo-failing-test
• codito/cache-in-docker
• codito/change-option-name
• codito/change-testWith-to-dataProvider
• codito/composer-script-for-composer-require-checker
• codito/composer-scripts-improvements
• codito/composer-unused
• codito/condensed-ruleset-info-in-fixer-doc
• codito/config-option-for-fqcn-in-phpdoc
• codito/contributing-guide-fix
• codito/contribution-info
• codito/deprecate-per-cs-v1
• codito/do-not-mark-php83-issues-as-stale
• codito/docker-clean-up
• codito/docker-infection
• codito/docker-php8.3
• codito/docker-with-signals-support
• codito/dockerfile-case-consistency
• codito/docs-generating-test-as-large
• codito/dynamic-alpine-version
• codito/enable-fqcn-importing-in-internal-ruleset
• codito/enable-single-line-empty-body
• codito/fast-lint-by-default
• codito/file-removal-test
• codito/fix-autocomplete-for-tokens-offsetGet
• codito/fix-checking-trailing-spaces
• codito/fix-cs
• codito/fix-docker-compose-build
• codito/fix-docker-image-naming
• codito/fix-docker-usage-examples
• codito/fix-fqcn-in-phpdoc
• codito/fix-integration-test-docs
• codito/fix-macos-builds
• codito/fix-mess-detector
• codito/fix-mess-detector-violations
• codito/fix-php8.4
• codito/fix-phpunit
• codito/fix-phpunit-methods-list
• codito/fix-relative-fqn-overriding-shortname
• codito/fix-self-approval-commit-message-matcher
• codito/fix-static-accessors
• codito/fqcn-import
• codito/fqcn-more-cases
• codito/friendly-getPriority-phpdoc-test-output
• codito/friendly-integration-testdox-cases
• codito/funding
• codito/improve-contributing-guide
• codito/improve-dx
• codito/improve-explicit_indirect_variable-test-cases
• codito/improve-fixer-dist-config
• codito/improve-mb_str_pad-tests
• codito/improve-qa-process
• codito/improve-stale-bot
• codito/improve-type-expression-api
• codito/improve-yaml-parsing
• codito/indentation-in-array-destructuring
• codito/infection-appendix
• codito/infection-ignore-rules
• codito/install-pcov-in-local-docker
• codito/issue-template
• codito/lint-main-script
• codito/lint-markdown
• codito/mark-getNamespaceDeclarations-as-internal
• codito/mark-readonly-fixer-as-risky
• codito/mess-detector-fix
• codito/move-errors-from-ignores-to-baseline
• codito/multiarch-docker-build
• codito/mutation-tests
• codito/namespace-multi-use-analysis
• codito/navigate-to-non-meta-tokens
• codito/no-redundant-static-call-within-final-method
• codito/parallel-config-named-args
• codito/paratest
• codito/php8.2-docker-runtime
• codito/php8.3-integration-test
• codito/php8.3-integration-test-failing-case
• codito/php8.4
• codito/phpcompatibility
• codito/phpmd-baseline
• codito/phpstan-custom-rules-PoC
• codito/phpstan-fix
• codito/phpstan-fixes
• codito/phpstan-github-formatter
• codito/phpstan-improvement
• codito/progress-bar
• codito/progress-for-fixer
• codito/refactor-composer-installation-smoke-test
• codito/remove-fabbot-config
• codito/remove-obsolete-version-from-compose-files
• codito/remove-travis-trigger
• codito/rename-abstract-test-classes
• codito/revert-7593
• codito/revert-self-approval-ref
• codito/revive-7565
• codito/revive-7960
• codito/rules-source
• codito/run-auto-review-once
• codito/shorten-fqcn-based-on-multi-imports
• codito/single-line-empty-body-in-per-cs-v2
• codito/sphinxlint-locally
• codito/stable-xdebug
• codito/stale-bot-ignore-core-issues
• codito/stale-bot-on-demand
• codito/stale-bot-permissions
• codito/stale-v9
• codito/symfony-var-dumper
• codito/un-unfinalize
• codito/unify-docker-volumes
• codito/update-pdepend
• codito/update-phpstan
• codito/update-xdebug
• codito/use-composer-binary-only-images
• git-for-smoke-tests-within-docker
• master
• review/5085-stale
• review/6774-on-nested-multiline
• review/7395-ordered-attributes-fixer
• review/7555-docker-setup
• review/7593-binary_operator_spaces-multiple_shifts_in_single_line
• update-phpstan
• v2.9999.0
• v3.42.0
• v3.65.0
• v3.67.1
• v3.68.0
• v3.68.1

Build # 7833232664

Build Type

push

github

Committed by Wirone

Commit Message

Better condition for clearing empty line

It was working anyway, since `$hasNonEmptyTokenBefore[0]` was always an int (first token in current line or PHP open tag's index), and when `$hasNonEmptyTokenAfter[0]` was null (nothing after an import statement) it tried to clear range with `-1` as end index, which effectively led to 0 steps in for loop. With explicit condition we only avoid stepping into `clearRange()`, but still it's better 🙂.

Run Details

25981 of 27412 relevant lines covered (94.78%)

41.48 hits per line