Wikidata-lib / PropertySuggester

85%

master: 48%

LAST BUILD ON BRANCH bug/T143645

branch: bug/T143645

CHANGE BRANCH

x

Reset

• bug/T143645
• 1.1.1
• 1.1.2
• 1.1.3
• 1.1.3_update_for_dm_2.0
• 1.1.4
• 1.2
• 2.0.0
• 2.0.1
• 2.0.2
• 2.0.3
• 2.0.4
• 2.0.5
• 2.0.6
• 2.1.0
• 2.2.1
• 2.3.0
• 2.3.1
• 2.4.0
• 2.4.1
• 2.4.2
• 2.4.3
• 2.4.4
• 2.4.5
• 231
• 3.0.0
• 3.0.1
• 3.0.2
• 3.0.3
• 3.0.4
• 3.1.0
• 3.1.1
• 3.1.2
• 3.1.3
• 3.1.4
• 3.1.5
• 3.1.6
• 3.1.7
• DatabaseBase
• JeroenDeDauw-patch-1
• T152065
• addDeleteModes
• add_phpunit.xml
• add_profiler
• add_versions_to_readme
• adjust_to_new_dmjs
• api
• apihelp
• bug/T102934
• bug/T132839
• bug/T147127
• buildTupleCondition
• builderDocs
• bwcompat
• cacheFix
• checkNameSpace
• classFeature
• cleanup
• considerClassifyingProperties
• copying
• createJsonTocreateResultArray
• data-model-services-2.0
• datamodel
• datamodelservices
• dbClassNames
• dbSlave
• deadJs
• dm
• dm5
• dm70
• emptyitemsuggestions
• entitynamespacelookup
• entityselector
• entitysuggester
• evaluation_special_page
• fixParamDocs
• fixResultSize
• fixTermIndexGetMatchingIdsUsage
• fix_bug
• fix_composer_name_64
• fix_review_issues
• fix_review_issues_2
• fix_review_issues_3
• fix_travis_build
• fix_valueview_changes
• fixdependencies
• followup
• genericDeletion
• getPropertyContext
• hhvm
• hhvmVersion
• hhvm_travis
• i18n
• idTuples2
• ignoreLines
• initialSuggestions
• initialSuggestionsRebased
• insertProgress
• itemIdHint
• jscs
• master
• missingApiParamDesc
• namespace
• namespaceLookup1
• namespaceUsage
• namespaceutils
• noNewFromNumber
• phpcs
• phpunit48
• protected
• psr4Wikibase
• qualifier_references
• readme
• rel-2.4.3
• rel230
• release-2.0.6
• release-2.2.0
• release-3.1.0
• release315
• release317
• releaseNotes240
• releasenotes
• relnotes
• removePsr4Hack
• remove_claimview
• review
• services11
• setUp
• shortArray
• simple-suggester
• simpleJscs
• smelllll
• suchcapitalization
• termindex
• terms
• tests
• travis
• travishhvm
• typeSafety
• unusedArg
• update_use
• utils
• v1.1
• valueviewcompat
• version
• wbCs02
• wbsgetsuggestionsFixi18n
• wfWaitForSlaves

Build # 921

Build Type

push

travis-ci

Committed by mariushoch

Commit Message

Only get suggestions once when the input field is initially focused

Right now the suggestions are loaded whenever the field is empty
and it gets the focus. That's not needed, because old results are
retained anyway, thus we only ever need to get the suggestions
once. (If it gets refocused it displays the old suggestions again.)

This will save us quite some API requests and also will it save us
from race conditions when two such api requests are returning.

https://phabricator.wikimedia.org/T143645

Run Details

388 of 458 relevant lines covered (84.72%)

6.82 hits per line