VowpalWabbit / vowpal_wabbit

75%

master: 76%

LAST BUILD ON BRANCH dev/Fix-CSharpBuild

branch: dev/Fix-CSharpBuild

CHANGE BRANCH

x

Reset

• dev/Fix-CSharpBuild
• 8.7.0
• 8.7.0.post1_with_python
• 8.7.0_with_python
• 8.8.0
• CMT_bump
• arielf-patch-1
• ataymano-ataymano/warnings_fixes
• ataymano/dev
• bremen79-fix_save_ftrl
• ccb
• change_lamda_definition
• cleanup_clang_format
• cleanups
• conditional_contextual_bandit
• daemon_test_fix
• dev-ariel
• dev/AddNugetSourceInfo
• dev/Enable-NugetVersionTagOverride
• dev/version
• edus/refactor_cb
• feature/split_labels_out_of_example
• fix_misconfiguration
• fix_unlabeled_sgd_examples
• fix_warnings
• jackgerrits-patch-1
• jackgerrits-patch-2
• jackgerrits-patch-2-1
• jackgerrits-patch-3
• jackgerrits-patch-4
• jagerrit/_win32_fix
• jagerrit/untangle_example_union
• marco-rossi29/default_cb_type_mtr
• marco-rossi29/fix_tau_first
• marco-rossi29/warning-fix
• marossi/cb_explore_adf_fix_and_impro
• master
• minor_fixes
• natvis
• new_version
• no_label_confidence
• optional_exception
• peterychang-patch-1
• readme_update
• revert-1912-fix_save_ftrl
• revert_build_change
• runtests_patch
• unit_tests_run_in_coverage
• update-badges
• vw_8_7_0_with_python
• warning_fix

Build # 7239

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Fix version of NewtonSoft used by in vw_cli.vcxproj

.Net NuGet packages have some troubles being referenced from inside of C++/CLI projects. The workaround is to pull the NuGet separately, then directly reference the dependency inside of the vcxproj. Unfortunately, this leads to situations where the version number gets desynced.

Going forward we will be rebuilding our C# (.Net) bindings to be .Net Standard-compatible, and multi-platform, similar to how it is done in VowpalWabbit/reinforcement_learning; this will necessitate moving away from C++/CLI and will fix this issue. The short-term mitigation is to manually fix up the version number.

Run Details

15955 of 21137 relevant lines covered (75.48%)

588322.22 hits per line