UCLALibrary / ursus

91%

master: 94%

LAST BUILD ON BRANCH fix/uv-conflicts

branch: fix/uv-conflicts

CHANGE BRANCH

x

Reset

• fix/uv-conflicts
• 1.0.0rc3
• 1.0.1.rc1
• 102-names-not-named-subject
• 123-change-feedback-style
• 16-metadata-in-search-results
• 175-spruce-up-readme
• 178-add-license
• 249-citation-bug
• 56-front-page-default-search
• 66-make-photographer-a-facet-search-link
• 72-hide-SMS-tool-link
• 74-remove-email-link
• about-page
• add-collection-banner
• add-rubocopyml_JenD
• add-yarn-to-docker
• alt-tag-348
• analytics
• bill-branch
• cc-license
• ci/add-coveralls
• citation
• citation-model-layout-234
• collection_membership_facet
• collection_name_facet
• configure-cite-link-73
• css/add-image-grid-to-front-page
• css/logo-split
• css/logo-unique-collections
• css/remove-border
• css/responsive-enhance
• date_slider
• deploy_targets
• desc_line_breaks
• disable_profile
• do-not-save-searches_287
• docker-bundle-unfreze
• docker-images
• docker-improvements
• docker/use-californica-db-and-solr
• email_link
• error_reporting
• exclude-facets_medium-dimensions_217
• facets
• featured_links
• feedback-form_176
• feedback-link
• feedback-link-dismiss
• feedback-link-mobile-styling
• feedback-link-x
• fix-homepage-accessibility-issues_206-part1
• fix-homepage-accessibility-issues_206-part2
• fix-homepage-accessibility-issues_214-part3
• fix-mobile-hamburger_223
• fix/bootstrap-vuln
• fix/images-on-prod
• fix/restore-fullscreen-button
• fix_spec
• front_page
• gem/use-sassc
• genre_display_format
• home_page
• implement-footer_252
• jendiamond-patch-1
• jenkins_webhook
• js/fix-modal
• master
• named_subject_facet_links
• pin_bundler_version_on_travis
• readme-to-wiki
• rebrand
• record_links
• remove-date-created-link
• remove-normalized-date
• remove_application.html.erb
• rename
• rights_statement
• search-fields
• search-fields/set-fields
• search-saving_287
• search_spec
• security/update-loofah
• solr_test
• sprint10.rc1
• sprint7.rc1
• sprint7.rc10
• sprint7.rc2
• sprint7.rc3
• sprint7.rc4
• sprint7.rc5
• sprint7.rc6
• sprint7.rc7
• sprint7.rc8
• sprint7.rc9
• sprint8.rc1
• sprint8.rc2
• sprint8.rc3
• sprint8.rc4
• sprint8.rc5
• sprint8.rc6
• sprint9.rc1
• sprint9.rc2
• sprint9.rc3
• test_search_results
• travis_deploy_tag
• travis_tagged_release
• ubuntu_deploy
• ui/add-link-to-old-site
• ui/application-name
• ui/cite_this_item
• ui/header-links
• ui/move-search-box
• ui/move_feedback_link
• ui/remove_browse_by
• ui/search-text
• update-BL
• update-blacklight
• update-dockerfile
• update-rights-country-label-167
• update-solr_wrapper
• update-to-Blacklight7
• update_dlcs-collection-name_233
• upgrade_rails
• urusus-ark-sketch
• use-Rack-Deflater
• uv-download-disable
• uv/add-test-for-presence-on-page
• uv/add-universal-viewer
• uv/restore-config
• v0.0.6
• v0.1.0
• v0.1.1
• v0.1.2
• v1.0.0
• v1.0.0.rc1
• v1.0.0rc2
• v1.0.0rc3
• v1.0.0rc4
• v1.0.1
• v1.0.2
• v1.0.3
• v1.0.4
• v1.0.5
• v1.1.0
• v1.2.0
• v1.3.0
• view-collections-in-search_255

Build # 589

Build Type

Pull #241

travis-ci-com

Committed by web-flow

Commit Message

Use iframe for loading UV on page

Loading UV directly in Blacklight is causing
conflicts becuase it includes its own versions
of jQuery UI, Bootrap JS, etc. Calling UV
in its iframe mode will isolate it and keep it
from interfering with the JS on the page. That
will be important when upgrading blacklight!

This PR removes the blob of /uv code from
/public and uses the `package.json` file to
install uv from the node package.

The travis build is changed so that it runs
`yarn install` before running tests to move
uv to the correct folder.

Before this PR is merged we should make sure that
`yarn` is installed on the production builds and
is installed in the ursus docker image.

Pull Request Pull Request #241: Use iframe for loading UV on page

Run Details

129 of 141 relevant lines covered (91.49%)

2.46 hits per line