UCLALibrary / californica

96%

master: 95%

LAST BUILD ON BRANCH work_around

branch: work_around

CHANGE BRANCH

x

Reset

• work_around
• master
• coverall-badge
• sprint7.rc5
• jendiamond-patch-1
• reconfigure-iiif
• revise-license
• date_slider
• sprint7.rc6
• cleanup
• disable_profile
• record_links
• sprint8.rc1
• gems/replace-sass
• 317-update-loofah
• feedbacklink
• 323-transplant-poppy
• 322-names-not-named-subject
• revert/sassc-rails
• sprint8.rc2
• 321-use-sassc-and-font-awesome-sass
• sprint8.rc3
• 324-rename-to-Californica
• 325-change-header-and-footer-color
• 315-add-feedback-link
• sprint8.rc4
• 337-fix-facet-styling
• sprint8.rc5
• sprint8.rc6
• update-rack
• travis_tagged_release
• sprint9.rc1
• config/redis
• fix_license
• sprint9.rc2
• error_reporting
• travis_deploy_tag
• sprint10.1
• v1.0.0rc1
• ingest_cleanup
• v1.0.0rc2
• locale_fix
• fix_year_index_bug
• fix_noid_bug
• import_collection_field
• upgrade_solr_wrapper
• upgrade_darlingtonia
• upgrade_darlingtonia_2
• v1.0.0
• remove_unused_actors
• clean_connell_sample_data
• remove_unused_actors2
• newrelic
• scout
• v1.0.1
• dockerize
• docker2
• v1.0.2
• fix-readme
• no_fits_log
• single-value-ark_358
• service_defaults
• collections3
• single-value-ark_399
• reindex-works_242
• reindex_script
• attach_to_collections
• sass_update
• update_on_import
• rake_collections
• ubuntu_and_redhat_deploy
• v1.0.3
• pared_down_update_stack
• no_rollbar_for_metadata
• share_metadata_with_collections
• v1.0.4
• ucla_metadata_on_collection_edit_form
• update_local_identifier_predicate
• link_ursus
• update_connell_sample
• docker-derivatives
• v1.0.5
• collection_show_view
• cleanup_uploads
• v1.0.6
• add-xray
• docker-bundle-install
• branding-info
• v1.0.7
• upgrade_rails
• v1.0.8
• upgrade_versions
• make_travis_use_bundler_1
• fix_iiif_url
• index_ark_on_collection
• find_or_create
• upgrade_to_2_5_0
• delete-rule-in-rubocop_JenD
• v1.1.0
• upgrade_devise
• do-not-save-searches_287
• read-only_462
• v1.2.0
• 231-mark_removal
• create_collection_on_import
• fix_intermittent_ci_failure
• code_cleanup
• create_ark_property
• v1.3.0
• 452_do_not_require_creator_and_keyword_in_edit
• 452_ark_on_collection_edit_screen
• install_chromedriver_helper
• sort_gemfile
• 444-AltIdentifier.local
• 483-mount_masters
• feature_to_system_tests
• missing_headers
• ark_on_new_collection_screen
• 457-ark_prefix
• search_for_ark
• no_editing_arks
• unknown_headers
• ark_indexers
• deduplicate_by_ark
• v1.4.0
• fix_to_cleanup_task
• move_code
• ark_based_identifier
• v1.5.0
• little9-patch-1
• little9-patch-2
• id_refactor
• read_only_mode_readme
• reduce-docker-memory-usage
• 439-based_near
• super_refactor
• read_only_warning
• rename_file_name_header
• do_not_truncate_ark_in_import_logs
• upload_csv
• v1.6.0
• import_collection
• fix-clean_tasks
• v1.6.1
• dev-rails-host
• markdown_csv_documentation
• add_required_buttons
• v1.7.0
• start_import_from_uploaded_csv
• import_as_background_job
• fix_create_work_spec
• catalog_id
• 491-localization
• command_line_import
• v1.8.0
• 527-missing_values
• run_background_jobs_in_system_specs
• batch_id_redux
• log_characterization_failures
• docker_sidekiq
• missing-value-warnings
• strip_down_actor_stack
• eradicate
• refine_clean_task
• update-readme
• fix-and-or-search
• remove_collection_size_indexing
• ucla_file_attach_debugging
• CAL-582_only_whitelist_opt_data
• CAL-519_rights_service_contract
• resource-types
• index_sort_fields
• v1.9.0
• CAL-569_warn_about_opt_data
• CAL-579_match_actor_stack_to_agreement
• CAL-562_delete_and_eradicate
• CAL-578_cc_license_for_ladnn
• v1.10.0
• solr-docker-fix
• CAL-581_move_collection_update_index_to_end_of_ingest
• v1.11.0
• resource_type_facet
• validation
• CAL-489_collection_title_translations
• fits-servlet
• v1.12.0
• unknown_rights_statement
• CAL-487_trigger_read_only_mode_for_backups
• CAL-588_import_multipage_work
• architect
• CAL-588_remove_redundant_rights_statement_validator
• v1.13.0
• CAL-588_create_child_work
• bundle_unfreeze
• CAL-588_order_pages
• CAL-588_order_page_2
• validate_controlled_fields
• v1.14.0
• csvparser_sets
• v1.14.1
• validation_deduplication
• use-human_readable_resource_type
• map-pd-copyright
• duplicate-csv-header-error
• language_codes
• v1.14.2
• remap_item_ark
• unrequire-rights
• validate_files_present
• v1.14.3
• display_mulipage_mss
• characterize_job_spec_refactor
• import_field_merge
• v1.14.4
• better_deduplication_field_location
• CAL-603_parallelize_csv_import
• discovery
• native-dot-env
• 584-alternative-title-metadata-field
• CAL-604_report_batch_import_status
• v1.15.0rc1
• transitions
• v1.15.0
• CAL-605_display_batch_import_status
• reduce-prod-logging
• multi-image-fix
• v1.15.1
• 586_add-place-of-origin-field
• CAL-605-part-1
• CAL-605_part_2
• spec-i18n-fix
• fix_broken_spec
• 585_add-uniform-title
• manifest-perf
• constant
• v1.15.2
• manifest-caching
• 600_add-support-metadata-field
• duplicate_ac
• view-log
• revert-error-logging-
• more-status-in-sidekiq
• v1.15.3
• index-title
• row-refactor
• db-manifest
• fix-translations
• sidekiq-lower-threads
• manifest-id-fix
• manifest-fix
• cantalopupe-info-json
• text-manifest
• import_visibility
• parallel_import_quick_fix
• v1.15.4
• default-public-visibility
• v1.15.5
• califfy_testing
• 600_add-support-field
• fix-object-type-mapping
• 667-add-subject-topic-field
• more-complete-example-for-manifest
• v1.16.6
• child-work-manifest-spec
• allow-ark-suffix
• v1.16.7
• config_robots
• v1.16.8
• audit
• audit-format-fix
• viewingHint-paged
• v1.16.9
• order_child_works_rescue
• purge-duplicate-filesets
• v1.16.10
• purge-empty-filesets
• docker-tweaks
• metadata-only
• 648_Personal_or_Corporate_Name_photographer
• 666
• v1.17.0
• 710_add-an-Author-metadata-field
• ingest-logging
• master-path-fixes
• 713_edit-page-fails-to-render-visibility-badge-in-dev
• iiif-thumbs
• no-file-ingest
• v1.18.0
• 712-Add_summary_metadata_field
• revert-679-712-Add_summary_metadata_field
• 712-Add_summary_metadata_field-B
• 712_add-a-summary-metadata-field
• iiif-paths-in-manifest
• rake-fix_missing
• iiif
• warn-missing-files
• csv-parse-error
• bundle-update
• fix-fix_missing
• revert-683-712_add-a-summary-metadata-field
• v1.19.0
• v2.0.rc1
• v2.0.0
• dont-import-duplicates
• docker-iiif
• manifest-refactor
• dot.env
• v2.1.0
• 450_index-thumbnails-for-collections
• access-preservation-copies
• missing-file
• CAL-737_METADATA_FIELD_PAGE_LAYOUT
• v2.2.0
• iiif_service_url
• access_copy-fix
• form-fixes
• iiif-helper
• spring
• CAL-711_ADD_TEXT_DIRECTION_METADATA_FIELD
• v2.3.0
• create-manifest-job
• v2.4.0
• nokogiri
• CAL-738_add_binding_note
• 735_iiif_viewing_hint
• 735
• 735_iiif_viewingg_hint-2
• 735_iiif_viewing_hint-A
• v2.5.0
• viewing_hint
• manifest-pagination
• v2.6.0
• precreate_manifests
• subject_topic
• 747-750_summary_csv
• 746-748-751-749
• 728_Add-timing-data-to-log
• manifest-from-service
• v2.7.0
• 759_iiif_manifest_url
• manifest-service
• CAL-728_Add_timing_data_to_ingest_status_screen
• CAL-752_Record_Ingest_time_per_row
• blank-canvases
• v.2.8.0
• v.2.9.0
• rspec-failures
• 753
• v2.9.1
• Cal-762-csv
• enable-manifest-store
• v2.9.2
• spring-commands-rspec
• remove-mysql-conf
• v2.9.3
• spring-commands-sidekiq
• explicit-csvrow-status
• manifest-actor
• v2.9.4
• fix-ingest
• v2.9.5
• CAL-784_Map_DLCS_fields
• update-parent-manifest
• dlcs-status
• rename-access_copy
• Import_Columns_in_Csvs
• v2.9.6
• multiple_metadata_fields
• bundle_update
• dockerfile-update
• v2.9.7
• require-admin
• better-find-by-ark
• v2.9.8
• job-deduplication
• CAL-798_Add_Object_type_and_NoOfChildren_Columns
• manifest-without-login
• v2.9.9
• docker-fix
• index-job
• add-favicon
• CAL-799_Unknown_status
• parallel-ingest
• v2.10.0
• Add_Metadata_Fields
• v2.10.1
• v2.10.2
• CAL-811_2
• delay-index
• 811
• v2.10.3
• CAL-800
• v2.10.4
• new-account-fix
• CAL-818-819-820-821-822_Add-columns-in-CSV
• fix-import-status
• v2.10.5
• read-only-redirect
• unwind-parallelization
• sinai-visibility
• v2.10.6
• better-import-redo
• v2.10.7
• dependabot/bundler/loofah-2.3.1
• close-ports
• mysql-client
• v2.10.8
• track-import-subtasks
• v2.10.9
• fix-collection-indexing
• v2.10.10
• dependabot/bundler/puma-3.12.2
• CAL-851_Add_field_for_Masthead
• v2.11.0
• CAL-750_DAdd-DescriptionContents-CSV-column-ContentsNote
• v2.11.1
• dependabot/bundler/rack-2.0.8
• add-local-docker-compose.yml-to-gitignore
• CAL-859-disable-fallback-default-admin-for-non-dev-deploys
• feature/travis
• v2.11.2
• CAL-821-Add-local_identifier-field
• CAL-819-Add-subject_name-field
• CAL-818-Add-genre-field
• CAL-822-Add-repository-field
• v2.11.3
• CAL-709-add-local-rights-field
• kirschbombe-patch-1
• CAL-850-add-creator-field
• v2.11.4
• CAL-817_Metadata_field_for_subjecttemporal
• v2.11.5
• callisto-facets
• iiif_manifest_url
• v2.11.6
• bugfix/travis-deploys
• Fix_Local_rights_statement
• dependabot/bundler/nokogiri-1.10.8
• update-Gemfilelock
• URS-578_Alphanumeric_sort
• testbundleupdate
• URS-545-solrconfig-for-Ursus-sitemaps
• dependabot/bundler/puma-3.12.3
• dependabot/bundler/puma-3.12.4
• v2.11.7
• Fix_gemlock
• v2.11.8
• CAL-871_Title_required_for_import
• CAL-877_Remove_warning_for_diagnostic_fields
• v2.11.9
• CAL-879_Error_IIIF_Manifest_URL
• CAL-778-843-814-850_add-metadata-fields
• CAL-668_856_Add_metadata_fieldS_for_OPAC_URL_and_Subject_geographic
• CAL-778-843-814-850_add-metadata-fields_2
• v2.12.0
• CAL-878_Add_items_to_multiple_collections_on_ingest
• CAL-878_Add_items_to_multiple_collections_on_ingest_2
• cal-820_import-metadata-field-subject-place-to-subject_geographic
• thumbnails
• URS-723_Collections_display_with_Ingesting_now_before_the_collection_title
• destroy-work
• v2.12.1
• video
• CAL-882_SORT_BY_ID_DESC
• v2.12.2
• silence-in-travis-spec
• dependabot/bundler/kaminari-1.2.1
• dependabot/bundler/websocket-extensions-0.1.5
• dependabot/bundler/puma-3.12.6
• reindex-multiple-parents
• dependabot/bundler/rack-2.2.3
• URS-852_title-sort
• v2.12.3
• reindex
• v2.12.4
• URS-808_Sort_by_date
• v2.12.5
• validate-headers
• CAL-917_Add_License_field_to_csv_ingest
• v2.12.6
• update-metadata-guide
• URS-890_Add_Date_fornats
• v2.12.7
• CAL-929_illustrator
• update-catalog_controller
• URS-873_forward_ark_for_ursus_core
• Add-metadata-fields_CAL-929-930-931-933
• v2.12.8
• CAL-913_Strip_MARC_subfields_from_all_ingested_values
• URS_869-combined_subject

Build # 1997

Build Type

Pull #635

travis-ci

Committed by web-flow

Commit Message

Fixed a problem with access controls in a FileSet record. Part of story
608.

I noticed this problem in the UI: when you change the visibility of a
work record, it gives you the option to apply those changes to all the
child records.  If you select 'yes' background jobs run to update all
the attached FileSet records.  But in some situations the resulting
visibility for the FileSets didn't match the parent work.

The problem was caused by an assumption in the hydra-access-controls
gem that caused it to incorrectly match on some access control records
that it was selecting for removal.  Because we are overriding visibility
in Californica, that assumption is no longer true.  I'll take a closer
look at the hydra-access-controls gem later and decide if we should file
a bug against it, but for now, overriding the "permissions_attributes="
method from that gem allows us to fix the invalid assumption.

I added a spec for "inherit_permissions_job_spec", which tests the exact
problem at a higher level than a unit test would.

Pull Request Pull Request #635: Fixed a problem with access controls in a FileSet record. Part of story 608.

Run Details

16 of 16 new or added lines in 1 file covered. (100.0%)

1209 of 1259 relevant lines covered (96.03%)

218.68 hits per line