Toilal / rebulk

96%

master: 97%

LAST BUILD ON BRANCH fix/match-hash-stable

branch: fix/match-hash-stable

CHANGE BRANCH

x

Reset

• fix/match-hash-stable
• 0.5.0
• 0.6.0
• 0.6.1
• 0.6.2
• 0.6.3
• 0.6.4
• 0.6.5
• 0.7.0
• 0.7.1
• 0.7.2
• 0.7.3
• 0.7.4
• 0.7.5
• 0.7.6
• 0.7.7
• 0.8.1
• 0.8.2
• 0.9.0
• 1.0.0
• 1.0.1
• 2.0.0
• 2.0.0b1
• 2.0.1
• chain
• chore/cleanup-toposort
• chore/remove-dead-code
• chore/tooling-coverage-mypy
• chore/uv-ruff-mypy-migration
• deprecation-warnings
• develop
• docs
• docs/functional-properties-check-keys
• docs/v5-design
• docs/zensical-site
• feat/check-unused-declared-keys
• feat/declared-keys-contract-check
• feat/declared-keys-output-projection
• feat/key-formatter
• feat/named-variadic
• feat/to-dict-typing
• feat/typed-keys-children
• feat/typed-keys-poc
• feat/typed-query-overloads
• feat/unify-key-param
• feature/introspector
• feature/upgrade-dependencies
• fix/chain-sort-before-groupby
• fix/declared-keys-skip-private
• fix/key-reject-structured-types
• main
• markers
• master
• perf/cache-getfullargspec
• perf/extend-safe-set
• py35
• python-3.12-support
• python-3.6
• python2.6
• refactor/chainpart-typing
• refactor/decouple-chain-builder
• refactor/pattern-dry
• regex-fixes
• rules
• semantic-release
• toposort
• v0.0.1
• v0.1.0
• v0.2.0
• v0.2.1
• v0.3.0
• v0.4.0
• v0.4.1
• wip

Build # 28319864212

Build Type

Pull #51

github

Committed by Toilal

Commit Message

fix(match): make Match.__hash__ independent of the mutable value

Match.__hash__ mixed in self.value, which has a public setter (and is set
during pattern processing), so a Match placed in a set/dict and then mutated
became unfindable -- a broken hash/eq contract. Hash on the span only (a
subset of the __eq__ fields, so equal matches still share a hash); same-span
matches with different values now collide harmlessly and __eq__ separates
them. Adds a regression test that mutates value while the match sits in a set.

Closes #34

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #51: fix(match): make Match.__hash__ independent of the mutable value

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

1799 of 1871 relevant lines covered (96.15%)

13.43 hits per line