Toilal / rebulk

98%

master: 97%

LAST BUILD ON BRANCH fix/declared-keys-skip-private

branch: fix/declared-keys-skip-private

CHANGE BRANCH

x

Reset

• fix/declared-keys-skip-private
• 0.5.0
• 0.6.0
• 0.6.1
• 0.6.2
• 0.6.3
• 0.6.4
• 0.6.5
• 0.7.0
• 0.7.1
• 0.7.2
• 0.7.3
• 0.7.4
• 0.7.5
• 0.7.6
• 0.7.7
• 0.8.1
• 0.8.2
• 0.9.0
• 1.0.0
• 1.0.1
• 2.0.0
• 2.0.0b1
• 2.0.1
• chain
• chore/cleanup-toposort
• chore/remove-dead-code
• chore/tooling-coverage-mypy
• chore/uv-ruff-mypy-migration
• deprecation-warnings
• develop
• docs
• docs/functional-properties-check-keys
• docs/v5-design
• docs/zensical-site
• feat/check-unused-declared-keys
• feat/declared-keys-contract-check
• feat/declared-keys-output-projection
• feat/key-formatter
• feat/named-variadic
• feat/to-dict-typing
• feat/typed-keys-children
• feat/typed-keys-poc
• feat/typed-query-overloads
• feat/unify-key-param
• feature/introspector
• feature/upgrade-dependencies
• fix/chain-sort-before-groupby
• fix/key-reject-structured-types
• fix/match-hash-stable
• main
• markers
• master
• perf/cache-getfullargspec
• perf/extend-safe-set
• py35
• python-3.12-support
• python-3.6
• python2.6
• refactor/chainpart-typing
• refactor/decouple-chain-builder
• refactor/pattern-dry
• regex-fixes
• rules
• semantic-release
• toposort
• v0.0.1
• v0.1.0
• v0.2.0
• v0.2.1
• v0.3.0
• v0.4.0
• v0.4.1
• wip

Build # 28373327524

Build Type

Pull #76

github

Committed by Toilal

Commit Message

fix(key): skip private matches in declared-key value_type check

check_declared_keys flagged the private parent of a children=True pattern: its
value is the raw matched substring (only the children go through the formatter),
so it is never an instance of the declared value_type. Private matches are
internal scaffolding, not emitted values, so the check now skips them — the same
way it already skips None and value=-mapped matches.

Surfaced while enabling the check across a large real-world corpus (#72): a
pattern like x(\d+) with private_parent raised on the unformatted parent "x264"
even though the emitted child correctly converts to int.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HSN8U8jMGw791gxpVpRh6f

Pull Request Pull Request #76: fix(key): skip private matches in declared-key value_type check

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

1910 of 1945 relevant lines covered (98.2%)

13.73 hits per line