Teamwork / kommentaar

53%

master: 54%

LAST BUILD ON BRANCH fix/cross-package-enum

branch: fix/cross-package-enum

CHANGE BRANCH

x

Reset

Sync Branches

• fix/cross-package-enum
• docker
• enhancement/better-generic-support
• enhancement/generic-types-map
• enhancement/preinstall-kommentaar-docker
• enums
• feature/update-go-1.26
• fix-embed-json-dash
• fix/atomic-output-write
• fix/generics
• fix/generics-support
• fix/linter
• fix/maptype-resolve-selectors-and-slices
• fix/package-name-collision
• generics
• go-compiler
• infer-required
• log-empty-tags
• map-of-slice-additional-properties
• maps
• master
• refs/tags/v0.1.10
• refs/tags/v0.1.11
• refs/tags/v0.1.9
• refs/tags/v0.2.0
• refs/tags/v0.2.1
• refs/tags/v0.2.2
• refs/tags/v0.2.3
• refs/tags/v0.2.4
• refs/tags/v0.2.5
• refs/tags/v0.2.6
• refs/tags/v0.2.7
• refs/tags/v0.2.8
• refs/tags/v0.3.0
• refs/tags/v0.3.1
• refs/tags/v0.3.2
• run-output-opt

Build # 24848043446

Build Type

Pull #110

github

Committed by shane-tw

Commit Message

Fix enum variations not resolved for cross-package enum types

When a field annotated with {enum} has a type from another package
(e.g. `pkg.SomeType`), getEnumVariations was never called with the
correct type name. The SelectorExpr branch called canonicalType which
resolved the type to its underlying primitive and then jumped back via
goto start; the re-entry then called getEnumVariations with the
primitive name ("string") rather than the original type name
("SomeType"), so no constants were ever matched.

Fix: call getEnumVariations with the original pkg and type name before
executing goto start in the SelectorExpr branch, mirroring what the
Ident branch already does.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Pull Request Pull Request #110: Fix enum variations not resolved for cross-package enum types

Coverage Stats

13 of 18 new or added lines in 1 file covered. (72.22%)

1 existing line in 1 file now uncovered.

1162 of 2181 relevant lines covered (53.28%)

45.51 hits per line