TYPO3BestPractices / tea

46%

main: 92%

LAST BUILD ON BRANCH task/matrix-phplint

branch: task/matrix-phplint

CHANGE BRANCH

x

Reset

Sync Branches

• task/matrix-phplint
• 1120-add-a-command-to-create-test-data
• 1332-make-plugin-a-ctype
• 1354-fix-gitlab-ci
• 1565-add-functionaltests-for-tea-controller
• 1566-drop-old-php-version
• 1567-drop-typo3-v11
• 1568-raise-php-language-level
• 1569-migrate-existing-unit-tests-to-functional
• 1569-migrate-existing-unit-tests-to-functional-split-create-action
• 1569-migrate-existing-unit-tests-to-functional-split-delete-action
• 1569-migrate-existing-unit-tests-to-functional-split-edit-action
• 1569-migrate-existing-unit-tests-to-functional-split-index-action
• 1569-migrate-existing-unit-tests-to-functional-split-new-action
• 1569-migrate-existing-unit-tests-to-functional-split-update-action
• 1569-refactor-functional-fixtures
• 1575-update-testing-framework
• 1580-drop-php-code-sniffer
• 1587-improve-docs-for-tests
• 1647-remove-paratest
• 1700-allow-sschtypo3-rector-v3-and-phpstanphpstan-v2
• 1711-adapt-rst-rendering-check
• 1751-migrate-composer-normalize
• 1782-move-configuration-file
• 1784-move-configuration-file
• 1786-runtests-composerupdatemax-throws-error
• 1787-migrate-stylelint-location
• 1788-migrate-eslint-location
• 1791-remove-unused-prettierrc-file
• 1793-add-functional-tests
• 1844-migrate-exception-to-error-controller
• 1844-prepare-trusted-properties
• 1846-add-more-functional-tests-for-front-end-editor
• 1855-one-fix-command
• 1856-fix-composer-normalize
• 1867-add-flashmessage-to-backend-module
• 1867-add-new-repository-method
• 1867-backend-module-to-demonstrate-testing
• 1867-link-record-fields
• 1882-let-composer-update-fail-properly
• 1918
• 1918-dependabot
• 1975-add-ci-job-check-fixers
• 1997-phpcsfixer-rule-leading-slash-global-functions
• 2000-additional-phpstan-rules
• 2004_Increase-render-guides-version
• 2016-remove-docsgenerate-command-from-composer
• 2034-drop-redundantsurplus-rector-sets-from-rector-configuration
• 2034-move-phpunit-rector-config-to-composer
• 2051-changelog-4-0
• 543-addphive-section-to-docs
• 982-github-using-runtest
• TASK/Move-php-cs-fixer-to-build-dir
• TASK/phpunit-upgrade
• add-proper-404-handling
• bashfunctions
• bug/1697-phpstan-fails-cause-ext-install
• bug/1698-lintphp-error-for-some-versions
• bug/gitlab-tests
• bugfix/add-covers-annotation
• bugfix/composer-caching
• bugfix/composer-unused
• bugfix/cs-fixer-config
• bugfix/deleted-image
• bugfix/dependabot-days
• bugfix/drop-gitlab-ci-references
• bugfix/fix-locallang-files
• bugfix/fixer-fix
• bugfix/flexforms-path
• bugfix/generate-baseline
• bugfix/gitattributes
• bugfix/nvmrc
• bugfix/php-lint-matrix
• bugfix/prepare-release
• bugfix/redundant-rector-rules
• bugfix/runtests-composerupdate-exitcode-handling
• bugfix/sqlite
• bugfix/static-psr-verify
• bugfix/symfony-di-74
• bugfix/test-data-typo
• checkcheck
• checker
• checkone
• checkxliff
• cleanup/assert
• cleanup/autoformat
• cleanup/autoformat-build
• cleanup/autoformat-ci
• cleanup/autoformat-code
• cleanup/autoformat-xliff
• cleanup/ci-order
• cleanup/composer-plugin
• cleanup/composer-script-names
• cleanup/constants-annotations
• cleanup/container
• cleanup/controller-test
• cleanup/drop-conflict
• cleanup/editor-tests
• cleanup/fixture-folders
• cleanup/gitignore
• cleanup/no-action-name-quotes
• cleanup/nvmrc
• cleanup/phpmd-name
• cleanup/phpstan-annotations
• cleanup/redundant-assignment
• cleanup/reformat
• cleanup/rename-ci
• cleanup/return
• cleanup/runtests-comments
• cleanup/runtests-core-ci
• cleanup/simplify-test
• cleanup/sort-bash-scripts
• cleanup/sort-runtests-commands
• cleanup/test-name
• cleanup/type-in-tests
• cleanuppp
• cssssfixeer
• dependabot/composer/ergebnis/composer-normalize-2.45.0
• dependabot/composer/ergebnis/composer-normalize-2.46.0
• dependabot/composer/ergebnis/composer-normalize-2.47.0
• dependabot/composer/ergebnis/composer-normalize-2.48.1
• dependabot/composer/ergebnis/composer-normalize-2.48.2
• dependabot/composer/ergebnis/composer-normalize-2.49.0
• dependabot/composer/ergebnis/composer-normalize-2.51.0
• dependabot/composer/ergebnis/composer-normalize-2.52.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.66.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.66.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.66.2
• dependabot/composer/friendsofphp/php-cs-fixer-3.67.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.67.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.68.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.68.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.68.3
• dependabot/composer/friendsofphp/php-cs-fixer-3.68.4
• dependabot/composer/friendsofphp/php-cs-fixer-3.68.5
• dependabot/composer/friendsofphp/php-cs-fixer-3.69.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.69.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.70.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.70.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.70.2
• dependabot/composer/friendsofphp/php-cs-fixer-3.71.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.72.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.73.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.74.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.75.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.76.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.77.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.78.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.78.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.80.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.81.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.82.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.82.2
• dependabot/composer/friendsofphp/php-cs-fixer-3.83.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.84.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.85.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.87.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.87.2
• dependabot/composer/friendsofphp/php-cs-fixer-3.88.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.88.2
• dependabot/composer/friendsofphp/php-cs-fixer-3.89.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.89.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.89.2
• dependabot/composer/friendsofphp/php-cs-fixer-3.90.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.91.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.91.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.91.2
• dependabot/composer/friendsofphp/php-cs-fixer-3.91.3
• dependabot/composer/friendsofphp/php-cs-fixer-3.92.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.92.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.92.2
• dependabot/composer/friendsofphp/php-cs-fixer-3.92.3
• dependabot/composer/friendsofphp/php-cs-fixer-3.92.4
• dependabot/composer/friendsofphp/php-cs-fixer-3.92.5
• dependabot/composer/friendsofphp/php-cs-fixer-3.93.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.93.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.94.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.94.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.95.0
• dependabot/composer/friendsofphp/php-cs-fixer-3.95.1
• dependabot/composer/friendsofphp/php-cs-fixer-3.95.2
• dependabot/composer/friendsofphp/php-cs-fixer-3.95.3
• dependabot/composer/friendsofphp/php-cs-fixer-3.95.4
• dependabot/composer/friendsofphp/php-cs-fixer-3.95.5
• dependabot/composer/helmich/typo3-typoscript-lint-tw-3.3.0
• dependabot/composer/phpunit/phpunit-10.5.58
• dependabot/composer/phpunit/phpunit-10.5.59
• dependabot/composer/phpunit/phpunit-10.5.60
• dependabot/composer/phpunit/phpunit-10.5.61
• dependabot/composer/phpunit/phpunit-10.5.63
• dependabot/composer/seld/jsonlint-1.12.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.1.1
• dependabot/composer/spaze/phpstan-disallowed-calls-4.10.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.11.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.12.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.2.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.2.1
• dependabot/composer/spaze/phpstan-disallowed-calls-4.3.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.3.1
• dependabot/composer/spaze/phpstan-disallowed-calls-4.4.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.4.1
• dependabot/composer/spaze/phpstan-disallowed-calls-4.5.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.6.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.7.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.7.1
• dependabot/composer/spaze/phpstan-disallowed-calls-4.8.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.9.0
• dependabot/composer/spaze/phpstan-disallowed-calls-4.9.1
• dependabot/composer/spaze/phpstan-disallowed-calls-4.9.2
• dependabot/composer/squizlabs/php_codesniffer-3.11.2
• dependabot/composer/squizlabs/php_codesniffer-3.11.3
• dependabot/composer/webmozart/assert-tw-1.12.0
• dependabot/composer/webmozart/assert-tw-1.12.1
• dependabot/github_actions/actions/cache-5
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/dependabot/fetch-metadata-3
• dependabot/npm_and_yarn/eslint-10.0.0
• dependabot/npm_and_yarn/eslint-10.0.1
• dependabot/npm_and_yarn/eslint-10.0.2
• dependabot/npm_and_yarn/eslint-10.2.0
• dependabot/npm_and_yarn/eslint-10.2.1
• dependabot/npm_and_yarn/eslint-10.3.0
• dependabot/npm_and_yarn/eslint-10.4.0
• dependabot/npm_and_yarn/eslint-9.16.0
• dependabot/npm_and_yarn/eslint-9.17.0
• dependabot/npm_and_yarn/eslint-9.18.0
• dependabot/npm_and_yarn/eslint-9.19.0
• dependabot/npm_and_yarn/eslint-9.20.0
• dependabot/npm_and_yarn/eslint-9.20.1
• dependabot/npm_and_yarn/eslint-9.21.0
• dependabot/npm_and_yarn/eslint-9.22.0
• dependabot/npm_and_yarn/eslint-9.23.0
• dependabot/npm_and_yarn/eslint-9.24.0
• dependabot/npm_and_yarn/eslint-9.25.0
• dependabot/npm_and_yarn/eslint-9.25.1
• dependabot/npm_and_yarn/eslint-9.26.0
• dependabot/npm_and_yarn/eslint-9.27.0
• dependabot/npm_and_yarn/eslint-9.28.0
• dependabot/npm_and_yarn/eslint-9.29.0
• dependabot/npm_and_yarn/eslint-9.30.0
• dependabot/npm_and_yarn/eslint-9.30.1
• dependabot/npm_and_yarn/eslint-9.31.0
• dependabot/npm_and_yarn/eslint-9.32.0
• dependabot/npm_and_yarn/eslint-9.33.0
• dependabot/npm_and_yarn/eslint-9.34.0
• dependabot/npm_and_yarn/eslint-9.35.0
• dependabot/npm_and_yarn/eslint-9.36.0
• dependabot/npm_and_yarn/eslint-9.37.0
• dependabot/npm_and_yarn/eslint-9.38.0
• dependabot/npm_and_yarn/eslint-9.39.0
• dependabot/npm_and_yarn/eslint-9.39.1
• dependabot/npm_and_yarn/eslint-9.39.2
• dependabot/npm_and_yarn/eslint-config-prettier-10.0.1
• dependabot/npm_and_yarn/eslint-config-prettier-10.0.2
• dependabot/npm_and_yarn/eslint-config-prettier-10.1.1
• dependabot/npm_and_yarn/eslint-config-prettier-10.1.2
• dependabot/npm_and_yarn/eslint-config-prettier-10.1.3
• dependabot/npm_and_yarn/eslint-config-prettier-10.1.5
• dependabot/npm_and_yarn/eslint-config-prettier-10.1.8
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.2.2
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.2.3
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.2.4
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.2.5
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.2.6
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.3.1
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.4.0
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.4.1
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.5.0
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.5.1
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.5.3
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.5.4
• dependabot/npm_and_yarn/eslint-plugin-prettier-5.5.5
• dependabot/npm_and_yarn/eslint/js-10.0.1
• dependabot/npm_and_yarn/prettier-3.4.0
• dependabot/npm_and_yarn/prettier-3.4.1
• dependabot/npm_and_yarn/prettier-3.4.2
• dependabot/npm_and_yarn/prettier-3.5.0
• dependabot/npm_and_yarn/prettier-3.5.1
• dependabot/npm_and_yarn/prettier-3.5.2
• dependabot/npm_and_yarn/prettier-3.5.3
• dependabot/npm_and_yarn/prettier-3.6.0
• dependabot/npm_and_yarn/prettier-3.6.1
• dependabot/npm_and_yarn/prettier-3.6.2
• dependabot/npm_and_yarn/prettier-3.7.1
• dependabot/npm_and_yarn/prettier-3.7.3
• dependabot/npm_and_yarn/prettier-3.7.4
• dependabot/npm_and_yarn/prettier-3.8.0
• dependabot/npm_and_yarn/prettier-3.8.1
• dependabot/npm_and_yarn/prettier-3.8.2
• dependabot/npm_and_yarn/prettier-3.8.3
• dependabot/npm_and_yarn/stylelint-16.11.0
• dependabot/npm_and_yarn/stylelint-16.12.0
• dependabot/npm_and_yarn/stylelint-16.13.0
• dependabot/npm_and_yarn/stylelint-16.13.1
• dependabot/npm_and_yarn/stylelint-16.13.2
• dependabot/npm_and_yarn/stylelint-16.14.0
• dependabot/npm_and_yarn/stylelint-16.14.1
• dependabot/npm_and_yarn/stylelint-16.15.0
• dependabot/npm_and_yarn/stylelint-16.16.0
• dependabot/npm_and_yarn/stylelint-16.17.0
• dependabot/npm_and_yarn/stylelint-16.19.1
• dependabot/npm_and_yarn/stylelint-16.20.0
• dependabot/npm_and_yarn/stylelint-16.21.0
• dependabot/npm_and_yarn/stylelint-16.21.1
• dependabot/npm_and_yarn/stylelint-16.22.0
• dependabot/npm_and_yarn/stylelint-16.23.0
• dependabot/npm_and_yarn/stylelint-16.23.1
• dependabot/npm_and_yarn/stylelint-16.24.0
• dependabot/npm_and_yarn/stylelint-16.25.0
• dependabot/npm_and_yarn/stylelint-16.26.0
• dependabot/npm_and_yarn/stylelint-16.26.1
• dependabot/npm_and_yarn/stylelint-17.0.0
• dependabot/npm_and_yarn/stylelint-17.1.0
• dependabot/npm_and_yarn/stylelint-17.10.0
• dependabot/npm_and_yarn/stylelint-17.11.0
• dependabot/npm_and_yarn/stylelint-17.12.0
• dependabot/npm_and_yarn/stylelint-17.2.0
• dependabot/npm_and_yarn/stylelint-17.3.0
• dependabot/npm_and_yarn/stylelint-17.4.0
• dependabot/npm_and_yarn/stylelint-17.7.0
• dependabot/npm_and_yarn/stylelint-17.8.0
• dependabot/npm_and_yarn/stylelint-17.9.0
• dependabot/npm_and_yarn/stylelint-17.9.1
• dependabot/npm_and_yarn/stylelint-config-standard-scss-14.0.0
• dependabot/npm_and_yarn/stylelint-config-standard-scss-15.0.0
• dependabot/npm_and_yarn/stylelint-config-standard-scss-15.0.1
• dependabot/npm_and_yarn/stylelint-config-standard-scss-16.0.0
• dependabot/npm_and_yarn/stylelint-config-standard-scss-17.0.0
• dependabot/npm_and_yarn/stylelint-no-browser-hacks-2.0.0
• dependabot/npm_and_yarn/stylelint-no-browser-hacks-2.0.2
• dependabot/npm_and_yarn/stylelint-no-browser-hacks-2.0.3
• docs-refactor-code-quality-checks-to-use-runTests
• docs/autoformat-md
• docs/commit-policy
• docs/drop-vanity-badge
• docs/dry-run
• docs/podman-default
• docs/repo-urls-in-readme
• docs/runtests-help
• docs/url-updates
• documenation-remove-coverage
• documentation-how-to-run-tests
• eslint/js
• feat/interlink-shortcode
• feature/1641-add-typo3-support
• feature/1798-debug-for-runtests
• feature/1827-split-phpstan-jobs
• feature/1830-add-content-element-wizard
• feature/1871-check-xliff-in-runtests
• feature/2006-documentation-improvment
• feature/2012_Update-nodejs-image
• feature/2017-remove-not-needed-fields
• feature/2030_Review-ci-job-for-documentation
• feature/2035_Add-starter-unit-and-functional-tests
• feature/2052_Remove-unsupported-commands
• feature/2055-restructure-documentation
• feature/2059-improve-texts
• feature/2064-add-new-pages-to-documentation
• feature/458-add-length-validation-model-fields
• feature/add-issue-template-for-bug
• feature/add-v13-support-to-runtests.sh
• feature/ci-dmbs
• feature/composer-caching
• feature/editor-flexforms
• feature/fix-runtests-for-linux
• feature/german-translation
• feature/mariadb
• feature/multiple-dbms
• feature/paratest
• feature/php-84
• feature/php-85
• feature/test-prepare-release
• feature/typo3-13
• feature/weekly-testruns
• fix/2071-fix-packagejson-unblock-dependabot-updates
• fixcomposer
• funcitown
• improve-readability-of-cs-fixer-config
• imstupid
• issues/1691
• jsonlint
• lintXliff
• lintbeforefix
• lintie
• main
• phpcsfixa
• phpcsfixer
• phpstaaan
• psrverify
• rectooor
• rector
• rectorprocess
• refactor-functional-test-setup
• reformatt
• remove-no-longer-needed-unit-test
• securityupdate
• stylelintupdate
• switch-to-runTests-for-phplint
• switch-to-runtests-for-code-quality
• switch-to-runtests-for-code-quality-frontend
• switch-to-runtests-for-functional-tests
• switch-to-runtests-for-prepare-release
• switch-to-runtests-for-unit-tests
• task-1802-switch-coverage-collection-to-runtestsh-on-github
• task/1332-make-plugin-ctype
• task/1332-make-plugin-ctype-update-wizard
• task/1332-make-plugin-ctype-without-wizard
• task/1332-make-pluing-ctype-without-wizard
• task/1345-drop-e-argument
• task/1761-migrate-ci-php-mess
• task/1841-align-our-runtestssh-with-the-core-instance-more
• task/1841-shellcheck-rules-sync-with-core
• task/2019-adjust-rector-rules
• task/2024-add-typo3-support-in-ci
• task/2046-add-badge
• task/2072-use-rawmessage-phpstan-baseline
• task/2116-improve-documentation
• task/allow-di-74
• task/cache-keys
• task/ci-badge-labels
• task/composer-script-names
• task/composer-version
• task/config-files-locations
• task/configure-phpstan-php-version
• task/coverage-default
• task/cs-fixer-config
• task/default-84
• task/default-php-version-for-qa
• task/dependabot-commit-messages
• task/dependabot-phpunit-version
• task/dev-deps
• task/downgrade-php-in-runtests
• task/drop-abstract-test
• task/drop-cs-config
• task/drop-empty-tsconfig
• task/drop-gitlab-ci
• task/drop-gitlab-jobs
• task/drop-symfony-5
• task/enable-test
• task/enable-type-perfect
• task/exclude-build
• task/flexforms
• task/full-matrix-all-fixers
• task/full-matrix-composer-quality
• task/full-matrix-runtests-quality
• task/issue-templates
• task/latest-12lts
• task/latest-images
• task/less-specific-typo3-dev
• task/main-alias
• task/more-warnings-in-tests
• task/move-basic-tests
• task/move-phpstan-configuration
• task/move-repo
• task/move-shellcheck-suppression-to-file
• task/move-typoscript-lint-config
• task/no-narrow-paramreturn
• task/npm-audit-fix
• task/npm-security
• task/phpcov-composer
• task/phplint-84-gitlab
• task/phpstan-baseline
• task/phpstan-localconf
• task/phpstan-processes
• task/raise-symfony
• task/raise-typo3
• task/re-add-composer-version
• task/rector-config
• task/reduce-builds
• task/reenable-unused
• task/release-4-1
• task/release-4.0
• task/remove-alpine
• task/rename-gitlab-ci
• task/revert
• task/runtests-db-versions
• task/runtests-summary
• task/simplify-ci-matrix
• task/switch-composer-install-to-docker
• task/symfony-deps
• task/symfony-dev-deps
• task/testsuites
• task/trusted-properties
• task/typo3-12-for-phpstan
• task/typo3-bugfix-version
• task/typo3-minimal
• task/typoscript-lint
• task/unblock-arg-passing
• task/update-container-images
• task/update-docs-image
• task/update-phpstan
• task/update-shellcheck
• task/wizard-baseline
• tasks/2041-use-typo3-13-as-default
• test/globals-in-unit-tests
• tests/functionalShowAction
• version-tests
• xlffiles

Build # 24405590005

Build Type

Pull #2078

github

Committed by web-flow

Commit Message

Merge 08eb9da74 into 388912b60

Pull Request Pull Request #2078: [TASK] Use the full CI matrix for the PHP linting job

Coverage Stats

139 of 301 relevant lines covered (46.18%)

2.58 hits per line