TYPO3 / Fluid

97%

master: 97%

LAST BUILD ON BRANCH 2.6.5

branch: 2.6.5

CHANGE BRANCH

x

Reset

• 2.6.5
• 2.0
• 2.0.5
• 2.0.6
• 2.0.7
• 2.0.8
• 2.1
• 2.1.4
• 2.1.5
• 2.1.6
• 2.1.7
• 2.2
• 2.2.1
• 2.2.2
• 2.2.3
• 2.2.4
• 2.3
• 2.3.5
• 2.3.6
• 2.3.7
• 2.4
• 2.4.1
• 2.4.2
• 2.5
• 2.5.10
• 2.5.11
• 2.5.5
• 2.5.6
• 2.5.7
• 2.5.8
• 2.5.9
• 2.6
• 2.6.0
• 2.6.1
• 2.6.10
• 2.6.2
• 2.6.3
• 2.6.4
• 2.6.6
• 2.6.7
• 2.6.8
• 2.6.9
• 2.7.0
• 2.7.1
• 3.0
• lolli-1
• lolli-2
• lolli-3
• lolli-4
• lolli-5
• main
• master

Build # 1318

Build Type

push

travis-ci

Committed by NamelessCoder

Commit Message

[BUGFIX] Use magic getter method as last attempt (#480)

* [BUGFIX] Use magic getter method as last attempt

Prevents issues with greedy magic methods being
called when a (public) property of the same name
exists in the class.

Specifically, does the following:

* Reverts deprecated VariableExtractor to previous
  behavior of letting a PHP warning be raised for
  protected getter methods. Removes the test that
  asserted this behavior (but kept it for StandardVariableProvider!)
* Switches both method_exists() and is_callable() to
  use instead a "study object" method that extracts
  all PUBLIC methods, disregarding __call, and fixing
  the problem that method_exists() returns TRUE for
  protected methods, and the problem that is_callable()
  returns TRUE for literally any method name.
* Slightly improves the internal logic of StandardVariableProvider
  and refactors it to call the "study object" method
  before checking if getters or asserter methods exist.

Close: #479

* [TASK] Rename studyObject to populateGettersByClassName

Clarify that method populates an array.

Run Details

2643 of 2728 relevant lines covered (96.88%)

91.44 hits per line