TAMULib / scholars-discovery

76%

tamu-master: 87%

LAST BUILD ON BRANCH 360-export-file-naming-refactor

branch: 360-export-file-naming-refactor

CHANGE BRANCH

x

Reset

• 360-export-file-naming-refactor
• 0772c5260e8972c6c0f0ef0d8f99ee19019967d5
• 1.3.1-hotfix-merge
• 1.4.0
• 1.4.0-rc1
• 106-stem-filter
• 108-full-bio
• 111-remove-spring-data-solr
• 128-solr-9
• 134-apa-conference-papers
• 135-conference-papers
• 135-conference-paperts
• 136-complete_author_list
• 136-complete_author_list-merger
• 136-deduplicate_ordered_literals
• 137-publication-type-name
• 138-review
• 139-add-author-facet
• 140-open-teaching-material
• 144-un-sdg-badge
• 145-apa-academic-articles
• 146-remove-published-in
• 14ed35db0be634b92be4e5b032e5cf0dd77f597f
• 162-163-harvest-index
• 164-upgrade
• 166-nashorn-dependency
• 170-single-page-bio-fix
• 171-publication-to-interfolio
• 177-render-ampersand
• 179-discovery-updates
• 180-alphabetize-directory
• 182-remove-individual-entity
• 187-creative-works
• 187-creative-works-backup
• 187-creative-works-process
• 188-edu-back-sort
• 189-preferred-title
• 191-sort-org-training-ext-orgs
• 194-prune-copy-to
• 195-reports-theses-template
• 196-api-broken
• 196-number-range-filter
• 197-upgrades
• 1bd6511544465b827548470e7b7d6146a1608083
• 2021-june-sprint
• 2021-june-sprint-87-pubmed-id
• 2021-june-sprint-89-college
• 2021-june-sprint-90-book-title
• 2021-june-sprint-91-upgrade
• 2021-june-sprint-93-94-95-un-goals
• 2021-june-sprint-97-person-goals-facet
• 2021-june-sprint-person-publication-tag
• 2021-june-sprint-staging
• 204-prune-nested-objects
• 210-upgrade
• 210-upgrade-take-2
• 210-upgrades
• 222-graphql-people-position-organizations
• 222-opengraph-meta-tags
• 227-assets
• 227-file-store
• 228-data-analytics-view
• 237-github-templates
• 237-pr-templates
• 276-co-investigator-link-update
• 277-additional-docx-export
• 278-export-discovery-view-include-orcid
• 279-person-display-unsdg-links
• 280-grant-contributor-org-facet
• 282-date-exceptions
• 311-researcher-age-visualization
• 312-quantity-distribution-api
• 312-un-sdg-density-distribution
• 313-export-filenames
• 328-resource-not-found-exceptions
• 337-manage-index-schema
• 343-index-health-indicator
• 343-index-health-indicator-merge
• 347-config-batch-fail
• 349-config-schematization
• 349-config-schematization-merge
• 351-index-collection-name
• 351-index-collection-name-merge
• 357-harvest-index-individual
• 359-data-and-analytics-view
• 362-naming-refactor
• 364-theme-organization-id
• 368-confliction-field-definition
• 370-facet-controls
• 372-sub-organization-types
• 373-views-property-paths
• 376-remove-sdb-triplestore
• 380-data-and-analytic-view-container-type
• 382-duplicate-copy-fields
• 382-duplicate-copy-fields-merge
• 396-session-cookie
• 412-scholarly-works-datasets
• 431-export-search-results-logging
• 434-caching-solr-client
• 59-chord-diagram-component
• 69155d5d93cea0b5d6437444ee91ec804f95bb29
• 6fe24a3dc4bc553ba272b93144afae555f88655d
• 77-multiselect-per-facet
• 79-software-badge
• august-sprint
• august-sprint-329
• august-sprint-329-missing-forward-slash
• august-sprint-334
• august-sprint-415-exclude-documents-without-title
• august-sprint-418-academic-age-group
• august-sprint-423
• august-sprint-docker-compose-update
• august-sprint-javadocs
• august-sprint-staging
• august-sprint-staging-temp
• august-sprint-test-resources
• august-sprint-unsdg-organization-filter
• augusut-sprint-418-academic-age-group
• auth-update
• authorizations
• caching-solr-client
• codeql-scanning
• codeql-setup
• collection-view-fields
• creative-works-participants
• data-analytics-filters
• dependabot/maven/com.github.ben-manes.caffeine-caffeine-3.1.4
• dependabot/maven/com.github.ben-manes.caffeine-caffeine-3.1.5
• dependabot/maven/com.github.ben-manes.caffeine-caffeine-3.1.6
• dependabot/maven/com.github.ben-manes.caffeine-caffeine-3.1.7
• dependabot/maven/com.github.ben-manes.caffeine-caffeine-3.1.8
• dependabot/maven/com.jayway.jsonpath-json-path-2.9.0
• dependabot/maven/org.apache.commons-commons-compress-1.24.0
• dependabot/maven/org.asciidoctor-asciidoctor-maven-plugin-2.2.2
• dependabot/maven/org.asciidoctor-asciidoctor-maven-plugin-2.2.3
• dependabot/maven/org.jacoco-jacoco-maven-plugin-0.8.10
• dependabot/maven/org.passay-passay-1.6.3
• dependabot/maven/org.passay-passay-1.6.4
• dependabot/maven/org.springframework.restdocs-spring-restdocs-asciidoctor-3.0.0
• discovery-facet-page-fix
• discovery-view-browse-by-letter
• docx-exporter-regression
• e042afc7f9ecf32b7e6ad20b6af3ee20e5fe4f93
• ee30a62341b665bc86f85ad50bf0805b75be38ea
• fix-resource-loading
• gitless
• graphql-facet-fix
• indexing-status-code
• issue-175
• june-2023-sprint
• june-2023-sprint-staging
• liquibase
• main
• many-author-update
• master
• master-merger
• master-sprint10
• master-sprint10-staging
• maven-workflow-ubuntu-latest
• may-2023-sprint
• may-2023-sprint-staging
• network-update
• oct-2021-sprint
• oct-2021-sprint-110-export-view-update
• oct-2021-sprint-113-community-theme
• oct-2021-sprint-114-document-citation-update
• oct-2021-sprint-115-upgrade-dependencies
• oct-2021-sprint-all-discovery
• oct-2021-sprint-staging
• refs/heads/241-data-network-tests
• refs/heads/dependabot/maven/com.jayway.jsonpath-json-path-2.8.0
• refs/heads/dependabot/maven/org.apache.commons-commons-compress-1.23.0
• refs/heads/dependabot/maven/org.asciidoctor-asciidoctor-maven-plugin-2.2.4
• refs/heads/may-2023-sprint-regressions
• refs/heads/may-2023-sprint-staging
• refs/tags/tamu_p1.1.0
• refs/tags/tamu_p1.1.2
• refs/tags/tamu_p1.1.2-2
• refs/tags/tamu_p1.2.0
• refs/tags/tamu_p1.3.0
• refs/tags/tamu_p1.3.1
• refs/tags/tamu_p1.4.0
• refs/tags/tamu_p1.4.1
• refs/tags/tamu_p1.4.1-rc2
• refs/tags/tamu_v1.1.0
• refs/tags/tamu_v1.1.1
• refs/tags/tamu_v1.1.2
• refs/tags/tamu_v1.2.0
• refs/tags/tamu_v1.3.0
• refs/tags/tamu_v1.3.1
• refs/tags/tamu_v1.3.2
• refs/tags/tamu_v1.3.3
• refs/tags/tamu_v1.4.0
• refs/tags/tamu_v1.4.1
• registration-fix
• remove-graphql
• sa-64-search_tips-theme
• serial-harvest-index
• snyk-fix-038f1e57909177ef6c41757a086cbbc8
• snyk-fix-0da05be526ccac29506a6191a0371884
• snyk-fix-c88db868069358a45179fa1a6391186b
• snyk-upgrade-0dbb00f6582b4d8bffe489a5005783d1
• snyk-upgrade-3075a71ead8ca88ba5949a362e4e8992
• snyk-upgrade-4d965c9a9f168c1badd4078e7f38f2fc
• snyk-upgrade-5ee6e35ad2017af4d27c87ae89a864ab
• snyk-upgrade-7df4846b659e4ea576112aa6443c28ae
• snyk-upgrade-8266e6c52824eab620d0683896e09fd4
• snyk-upgrade-d3b8632d0165191e81775ee3bf856821
• snyk-upgrade-daf97d952dbb202a1bc913bdbe91ffe2
• snyk-upgrade-df3c88ba46444055e6f2cb79520d919a
• snyk-upgrade-e777399804b9c7eb956c22d82ebebbb5
• snyk-upgrade-eea0071e566bf6eb06d9dd140d7c9da0
• solr-cloud-upload-and-create
• sprint
• sprint-7
• sprint-7-staging
• sprint-staging
• sprint-staging-ff
• sprint14
• sprint14-143-publicationVenue
• sprint14-147-cannot_execute
• sprint14-staging
• staging-bug-fixes
• synk-upgrades
• tamu-development
• tamu-indexing-endpoint
• tamu-main
• tamu-main-debug
• tamu-main-log4j-patch
• tamu-master
• tamu-master-debug
• tamu-master-gh-actions
• tamu-master-gh-actions-dry-run
• tamu-sprint
• tamu-sprint-merge-oct-2021-sprint-staging
• tamu-sprint-staging
• tamu-sprint10
• tamu-sprint10-1
• tamu-sprint10-10-research-overview
• tamu-sprint10-11
• tamu-sprint10-12-news
• tamu-sprint10-13
• tamu-sprint10-16
• tamu-sprint10-17
• tamu-sprint10-196
• tamu-sprint10-2-6-14
• tamu-sprint10-204
• tamu-sprint10-21
• tamu-sprint10-26
• tamu-sprint10-27
• tamu-sprint10-3
• tamu-sprint10-3-merger
• tamu-sprint10-4-software
• tamu-sprint10-42
• tamu-sprint10-46
• tamu-sprint10-5
• tamu-sprint10-7
• tamu-sprint10-8
• tamu-sprint10-9
• tamu-sprint10-9-merger
• tamu-sprint10-collection-view-fields
• tamu-sprint10-staging
• tamu-sprint10-wrapup
• tamu-sprint11
• tamu-sprint11-56-investigator-order
• tamu-sprint11-57-grant-contributor
• tamu-sprint11-61-news-sort
• tamu-sprint11-62-concept-research-area-of
• tamu-sprint11-63-person-teaching
• tamu-sprint11-64-dashboard-link
• tamu-sprint11-66-grant-abstract-full-text-search
• tamu-sprint11-76-range-facet-support
• tamu-sprint11-http2
• tamu-sprint11-optimizations
• tamu-sprint11-staging
• tamu-sprint11-staging-debug
• tamu-sprint11-upgrades
• tamu_p0.8.0
• tamu_p0.8.1
• tamu_p0.8.2
• tamu_p0.8.3
• tamu_p0.8.4
• tamu_p1.0.0
• tamu_p1.0.1
• tamu_p1.0.2
• tamu_v0.8.4
• tamu_v1.0.0
• tamu_v1.0.1
• tamu_v1.0.2
• test-embedded-solr-proxy-mode
• updates
• upgrades
• v.1.3.1
• v1.3.0
• v1.3.1
• v1.3.2
• v1.3.3
• vstf-staging
• workflow-updates
• wwelling-patch-1
• wwelling-patch-2

Build # 5822553692

Build Type

Pull #361

github

Committed by wwelling

Commit Message

Remove over encapsulation and correct separation of concern

The helper classes in discovery package are violating common principles and are not providing abstraction to multiple implementations of their use.

Pull Request Pull Request #361: [Issue 360] Remove over encapsulation and correct separation of concern

Run Details

15 of 15 new or added lines in 1 file covered. (100.0%)

3578 of 4719 relevant lines covered (75.82%)

4.55 hits per line