• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

TAMULib / IRIIIFService
49%
master: 86%

Build:
Build:
LAST BUILD BRANCH: refs/tags/v0.6.1
DEFAULT BRANCH: master
Repo Added 23 Apr 2018 03:33PM UTC
Files 65
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH 150-add_encoding_unit_tests
branch: 150-add_encoding_unit_tests
CHANGE BRANCH
x
Reset
  • 150-add_encoding_unit_tests
  • 0.2.4
  • 0.6.0
  • 0.6.1
  • 110-weaver_rc9
  • 110-weaver_updates
  • 112-remove_devtools
  • 116-pcdm-examples
  • 126-redis-manifest-regression
  • 137-fedora-multipage-pdf-presentation-manifests
  • 150-add_encoding_unit_tests-test_revert_space
  • 150-encoding_test-1
  • 500-on-metadata-not-found
  • 81-repeated-metadata
  • 82-context-metadata
  • B-03605-prefer-rdfs-label
  • B-03653-fedora-rdf
  • B-03696-redis-resource-store
  • UTF-8-encoding
  • b03880-b03881-b03882-listen-to-cap
  • bp0.5.5
  • cantaloupe_sprint_2_base
  • cantaloupe_sprint_2_staging
  • cantaloupe_sprint_2_staging-conservative_changes
  • cantaloupe_sprint_2_staging-revert_problems
  • cantaloupe_sprint_2_staging-revert_problems-2
  • collection-manifest-revert
  • component-scan-weaver
  • configurable-metadata
  • configurable-repository-identifiers
  • configurable-repository-path
  • context-query-regression
  • dependabot/maven/com.google.guava-guava-32.0.0-jre
  • dependabot/maven/org.apache.commons-commons-text-1.10.0
  • discovery-view-2020-q1-75-schema
  • discovery-view-2020-q1-76
  • discovery-view-2020-q1-78-external-resolver
  • discovery-view-2020-q1-78-resolver
  • discovery-view-2020-q1-staging
  • docs
  • dpsace-iiif-generator-regression
  • dspace-bitstream-collection
  • dspace-canvas-id
  • dspace-handle-matcher
  • dspace-metadata
  • exclude-empty-canvas
  • fedora-collection-labels
  • fedora-collection-presentaiton
  • filter-images
  • get-mapping
  • gh-page
  • handle-redirect-with-unencoded-location
  • http-client-issues
  • issue-139
  • issue-89
  • issue-92
  • issue-templates
  • main
  • maintenance-2020-q1
  • manifest-improvements
  • master
  • metadata
  • p0.1.0
  • p0.2.0
  • p0.2.0.1
  • p0.2.0.2
  • p0.2.0.3
  • p0.2.1
  • p0.2.1.1
  • p0.2.2
  • p0.2.3
  • p0.2.3.1
  • p0.2.3.2
  • p0.2.3.4
  • p0.2.5
  • p0.3.0
  • p0.3.1
  • p0.3.2
  • p0.3.3
  • p0.4.0
  • p0.4.1
  • p0.5.0
  • p0.5.1
  • p0.5.2
  • p0.5.3
  • pdf-pages
  • pr-template
  • readme-update
  • redirect-location-with-spaces
  • refactoring
  • refs/tags/p0.5.4
  • refs/tags/p0.5.5
  • refs/tags/p0.6.0-rc1
  • refs/tags/p0.6.0-rc2
  • refs/tags/p0.6.0-rc3
  • refs/tags/p0.6.1-rc1
  • refs/tags/v0.5.4
  • refs/tags/v0.5.5
  • refs/tags/v0.6.0
  • refs/tags/v0.6.1
  • snyk-fix-206c69072a32b9d76de08c90aaf8303e
  • snyk-fix-e49ee5feee63cafdf8d1968119a4901c
  • snyk-upgrade-27f274ae76ee746753b70c99bf68e222
  • snyk-upgrade-b7e9c57170f8b3e8736245f01bd30f36
  • spring-docs
  • sprint-action-98-github-actions-migration
  • sprint_upgrade-staging
  • staging
  • store-allow-disallow-in-manifest-id
  • tamu-june-dame-sprint-b03507-mime-types
  • tech-debt-upgrade
  • time-to-live
  • unescape-json
  • update
  • v0.2.0
  • v0.2.1
  • v0.2.2
  • v0.2.4
  • v0.3.0
  • v0.3.1
  • v0.3.2
  • v0.3.3
  • v0.5.0
  • v0.5.1
  • v0.5.2
  • v0.5.3
  • varying-pcdm-support
  • weaver-upgrade
  • wildcard-path-context
  • wrapup
  • wrapup-changes

18 Oct 2024 08:51PM UTC coverage: 48.862% (-33.2%) from 82.103%
11410860056

Pull #151

github

kaladay
Issue 150: Fix discovered problems and update unit tests.

This is a follow up to the commit fe69b97d4.

A bug with the processing of the percent encoded URLs is due to custom code being used to build the RDF Model.
Remove that code and use the Apache Jena API directly.
This fixes the problems but changes the network HTTP fetch approach that forces a change to the unit test logic.

Several unit tests are now failing, possibly due to problems exposed by the new testing approach.
I ran out of time and so I am simply disabling tests that I have not had enough time to determine what is wrong.

The unit tests exposed a NULL pointer error handling in the `getMimeType()` function.
The headers is being returned as `NULL` and it is not being safely handled.
The cause of this is unknown and needs further investigation.
Regardless of this problem, the `getMimeType()` should not be failing on a `NULL` pointer error and now no longer is.
The `try..catch..` in that function is hiding the actual error and has been removed.

The original `createRdfModel()` has been copied over into individual tests to avoid rewriting all of the existing unit tests.
These needs to be changed and removed in the future.
Pull Request #151: Issue 150: Fix problems with encoding/decoding and add encoding unit tests.

2 of 15 new or added lines in 3 files covered. (13.33%)

402 existing lines in 19 files now uncovered.

601 of 1230 relevant lines covered (48.86%)

0.49 hits per line

Relevant lines Covered
Build:
Build:
1230 RELEVANT LINES 601 COVERED LINES
0.49 HITS PER LINE
Source Files on 150-add_encoding_unit_tests
  • Tree
  • List 65
  • Changed 25
  • Source Changed 11
  • Coverage Changed 24
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
11410860056 150-add_encoding_unit_tests Issue 150: Fix discovered problems and update unit tests. This is a follow up to the commit fe69b97d4. A bug with the processing of the percent encoded URLs is due to custom code being used to build the RDF Model. ... Pull #151 18 Oct 2024 08:54PM UTC kaladay github
48.86
11372897268 150-add_encoding_unit_tests Merge fe69b97d4 into 426d39335 Pull #151 16 Oct 2024 07:58PM UTC web-flow github
82.1
11372863446 150-add_encoding_unit_tests Issue 150: Update unit tests for Dspace and update Fedora tests. This is a follow up to commit 41731b8dc. This primarily focuses on updating the DSpace unit tests to match the new behavior that the Fedora unit test... push 16 Oct 2024 07:55PM UTC kaladay github
82.1
11372439874 150-add_encoding_unit_tests WIP: 2024/10/16 - 2. push 16 Oct 2024 07:23PM UTC kaladay github
82.1
11369468663 150-add_encoding_unit_tests WIP: 2024/10/16 - 1. push 16 Oct 2024 04:04PM UTC kaladay github
82.1
11354881561 150-add_encoding_unit_tests Issue 150: Fix problems with escaping and update unit tests. This primarily focuses solving the problems with Fedora but many of the changes are broader than Fedora such that they may impact DSpace. The data from the client should throw an error... push 15 Oct 2024 09:47PM UTC kaladay github
82.1
11353963671 150-add_encoding_unit_tests WIP: 2024/10/15 - 2. push 15 Oct 2024 08:36PM UTC kaladay github
82.03
11350740020 150-add_encoding_unit_tests WIP: 2024/10/15 - 1. push 15 Oct 2024 04:55PM UTC kaladay github
82.13
See All Builds (614)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc